From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22e.google.com (mail-oi1-x22e.google.com [IPv6:2607:f8b0:4864:20::22e]) by sourceware.org (Postfix) with ESMTPS id 239FE3858D1E for ; Mon, 5 Feb 2024 14:56:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 239FE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 239FE3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707144970; cv=none; b=ZcuouZL9RWNqprNmQuONOkYTfAgT/QULi/odZoSAN9lhcxIbBMAM902Kt2+hyGANHRiLf+hqeUy8tOazd7RW32WgppYSky/mywAZ7p0bkWPTttc6Oqkb+XRNRP22Q7YHMs86pQXWR2pVPuRLGAf+TWNdKesb6SCKDisZx0u4SQk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707144970; c=relaxed/simple; bh=S4zC7NyqIOJxFTkdjn0p2OP89Wd9BVYhUiUOypF0Apg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=sFZgV++XriGithKyrTrHb9j/XKb0ZROMcxxaYwOjay5j2ni1C12stsomG1b4tAzzG9F5ldzG3Kzy6RjQm0actdCxSxcjxTrpSHuxtcj8IDfhiZGfVM+zUeY7940e1SCluWIrq7jK5HVfQDg30+wir8q28X9zEalWywB/g8MgbwQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22e.google.com with SMTP id 5614622812f47-3be48947186so2544447b6e.3 for ; Mon, 05 Feb 2024 06:56:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707144968; x=1707749768; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W/qdWcXl1DrvzZc9rkWRLhrFZ71Z+CPDt6MI12jX5SY=; b=ivd8/VUkpJjjkciV0t6BvHrTKVo7VIDF5B7DCVgxyiBMULaWTwadR1Z3uxN9Tt3VO7 HCG4AXRcFJLu2JcfnTh/NvTInALPPO29xsGTsc2q1DnPfCm8ps05g8tXqynsioZiNyan NQfcjBTTWrsAWrycnko+GSWjqdVvlNIwvEJ/dEY56o234Zyo1nfoaSkqez8ck2IX4EtG 05fNrdAG9zbfXZlPSXymX9i8uyxrEL5McupnQmsQ4AelrhhQ4ujWFm2dm43ST3SJKqKu ZsmTze2gCuspnjWptNpkyvHWtxRgFNxms884jxWrYcxVgmB3KYb7dZm6ItnZ8c/1Zc+a eXqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707144968; x=1707749768; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=W/qdWcXl1DrvzZc9rkWRLhrFZ71Z+CPDt6MI12jX5SY=; b=R0IDrktGyDXbG83JMybS9rKD2DAkT14RjLiggwnfExH56zKq7nd37xYplEmfJjXNkf uZfDeQjb50H/t9pmn30hTeSCHX3nPrZq/ipLPS2IrPA65bZtoU0n1aAW2ZbZT5g8esKO Lr+NYjunrVVtklqAgCxBLo1L7HQFRa/QEu2du9I05JmysaKSE/YrTLO4j/5FPbWDgutF 1uITYcZ4eV/U0il1U++oRWZTT7XDxqPae5vUCoWfK9MppZhMY53F5stnHl9vO483e8A6 5TXwjYJagno120wcr4Rix99BDzK5Xa88Ex+uJdOMDlMYN1YMkMXkPbGZPKWdfYg/n795 v8oA== X-Gm-Message-State: AOJu0Yz7Tnmlc7TzUpfmgZqFu3lkTs9XzZ7mJ5zZTV2TJblFgqoE001r CYdkn60gDkJnRswtWfEe8sKiCevsuxg+D/bef0EqCqtChZMRAWLU X-Google-Smtp-Source: AGHT+IHnCLf3iiwI448Qh9L9QP1g5rifh1ha4rM2CG7a30VJd2E02wFwKDDrKBn250hpRqB2qNubGg== X-Received: by 2002:a05:6808:318a:b0:3bf:d9fb:4d7d with SMTP id cd10-20020a056808318a00b003bfd9fb4d7dmr5463752oib.19.1707144968333; Mon, 05 Feb 2024 06:56:08 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUBOBxRB+2m+fWtxeQRAnsD4iCgmyg5tm0gVTrZMGwH/hAjVkdRTBJnu4+6tuFSFpzv5ml3t6/MuQqwnHnOwK4k+aQXZA3/nM54C4+1PJe/IzyoelEI4b7HsQxnb2r1y1s/qSLpa11NIJMN0SJadLUqADaUwvqeDoDfMZ/mHGbyO8urQjTsDUgY5otAozWMenLD3ZkpHb4GE2CIrkeJulpV8Th5+RHp1B70r1HxgKPOxDe1EHjVrzbkLbDgdN6GsBB5SGQOnOVv5UOzIRs0xqfd/m91264/xjrOFPIzG4f5CNu7nwhC7Rjc0h4= Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id c2-20020aca1c02000000b003be4835ba31sm1522oic.32.2024.02.05.06.56.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Feb 2024 06:56:07 -0800 (PST) Message-ID: <34c6de4e-38ea-4d18-b9b9-b1fa224b9e73@gmail.com> Date: Mon, 5 Feb 2024 07:56:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] RISC-V: THEAD: Fix improper immediate value for MODIFY_DISP instruction on 32-bit systems. Content-Language: en-US To: =?UTF-8?Q?Christoph_M=C3=BCllner?= , Andreas Schwab Cc: Kito Cheng , Jin Ma , GCC Patches , Palmer Dabbelt , "richard.sandiford" , Robin Dapp , =?UTF-8?B?6ZKf5bGF5ZOy?= , "jinma.contrib" References: <20240129092016.1176-1-jinma@linux.alibaba.com> <20240129095700.1245-1-jinma@linux.alibaba.com> <87il35itf2.fsf@igel.home> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/5/24 05:00, Christoph Müllner wrote: > On Sat, Feb 3, 2024 at 2:11 PM Andreas Schwab > wrote: >> >> On Jan 30 2024, Christoph Müllner wrote: >> >>> retested >> >> Nope. > > Sorry for this. I tested for no regressions in the test suite with a > cross-build and QEMU and did not do a Werror bootstrap build. I'll > provide a fix for this later today (also breaking the line as it is > longer than needed). Right. And that's pretty standard given the state of the RISC-V platforms. We've got a platform here that can bootstrap in a reasonable amount of time, but I haven't set that up in the CI system yet. Until such systems are common, these niggling issues are bound to show up. It's just whitespace around the HOST_WIDE_INT_PRINT_DEC and wrapping the long line, right? I've got that in my tree that's bootstrapping now. I don't mind committing it later today. But if you get to it before my bootstrap is done, feel free to commit as pre-approved. jeff