Re: [PATCH] C++: target attribute - local decl

[Jason Merrill <jason@redhat.com>]

On 3/1/21 11:59 AM, Martin Liška wrote:
> On 3/1/21 5:36 PM, Jason Merrill wrote:
>> On 3/1/21 7:43 AM, Martin Liška wrote:
>>> On 2/22/21 11:53 PM, Jason Merrill wrote:
>>>> The problem seems to be with the handling of local decls.  If 
>>>> DECL_LOCAL_DECL_P, you need to look at DECL_LOCAL_DECL_ALIAS to find 
>>>> the namespace-scope decl.  But then if there is no preceding 
>>>> namespace-scope declaration, the new decl created by 
>>>> push_local_extern_decl_alias doesn't have a cgraph node, either.  I 
>>>> guess maybe_function_versions 
>>>> also needs to look through DECL_LOCAL_DECL_ALIAS.
>>>
>>> Ah, I see. Are you sure about the name 'maybe_function_versions'? I 
>>> can't find it.
>>
>> Ah, it's maybe_version_functions, sorry.
> 
> Thanks, I see the function now.
> So about your guess:
> 
>> I guess maybe_function_versions also needs to look through 
>> DECL_LOCAL_DECL_ALIAS.
> 
> Do you mean maybe_version_functions's argument 'record' should depend on 
> DECL_LOCAL_DECL_ALIAS of newdecl/oldddecl
> (if present)? Or that DECL_FUNCTION_VERSIONED should be set for 
> DECL_LOCAL_DECL_ALIASes of the newdecl/olddecl
> function declarations?

The latter.

Jason