From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 81CA63858D38 for ; Thu, 9 Nov 2023 23:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 81CA63858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 81CA63858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699574175; cv=none; b=pgO4v+MU+EdStwifQm5wfWYrmb417f1kCwhBW/+uAYLEA4Sjp+AMQ/PzvEKpkKui81Uh13EuGm65j7eGXisFkLZ6TK0ZWXevC/arxjK9e72EPrbPO3SHrohKfZbPw4vuPX2fZhdE+KjQpo05ZBNCKzPongDVHAbWOCq7pmzgNKo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699574175; c=relaxed/simple; bh=vjs3XljDJh7velH5AoT8IPhBbgr/fcl6EHzCmGTsEyA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=lCePE0dR3DksL08B+L1cFUoD41rUUWeKKd+44nZyeyAejUkKCRYSRSFEtx+LNS2ic98jV8YjVM3nkFnKLpKSqKi17N74pB47W3kbgZaW5+zEQycsE/jgZtvxmZG8oSwyITNs54wJevhPhivI3+95JRx1gaNAS431ytBgz6BqGTg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7a93df91813so53570839f.2 for ; Thu, 09 Nov 2023 15:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699574173; x=1700178973; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nOiXpkWPdLr8PUfs0tdpQJxwTa5YQdgZpgn61+UYvmg=; b=juYKhyZ0DJgcfnmxDf2OquYEHkOnmXJ2AXYilfdpl75xqe79VhgG9iLFNUIRzpS/0W 7aNYdFhRhzXsGPwZ5jHMnuXYlH+iB5clYlQh6Z4MzfHfX+ZzjAPgpjCvog+Xln5L0w31 d5+TwePFHL+sH2eCF3qs7LNTOk9qgaiRJGk2bz/EkkwbnOdUvuSkix22oby6geKGtIAm DRgggy6MHz/rKuTLmnK/y/YdE0CvBjPYNwu3ZPmhbHe/LIaNb+UsNJlzdhFbY7XE/5fv wbAz1KpGqENzFbIiTRehEV8rZzyadmLgMTDLB7h2who6jnn/PKfDffLS4+2hs9AuP9hB LVpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699574173; x=1700178973; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nOiXpkWPdLr8PUfs0tdpQJxwTa5YQdgZpgn61+UYvmg=; b=SilE6l05alJErAAXLdGLbEBd1HgL2419QyHaHNsjSokShfBvWQaZtLnj3QqyMk1LAr QAEQBSOamnDurMPARyHc0Qsvv5YQfjCKOy3sZfIcKVhlkMavBKWZoYo59gn72n45Bpw0 5h7FsTzbg/lwuSoaM5qF97CGFh3lL4YhTTSfUSdEgSmiF5wJSCLWBBOJVG5zjSAEtVs9 eEtI7FTZnExmZ8xaMw0Nq6zOTnRP+rJXQGuyeg8BkPx2nITIXUwXYwjGlRThpjvjyafp PVMT21KjTzuL807Clq4IKGQf8vk3W2WbNKHxlHXLigR0TcFo1qNpCGVhR7wmZYVTxVtj bXdg== X-Gm-Message-State: AOJu0Yyhn1Bs21icK3QBG4b6XjJSRpeaojUgHwbEBnkWD4P7VYsLXhot vuADCVtWC1Sd+SysxjBVOaI= X-Google-Smtp-Source: AGHT+IH4zs2lPd2kIidb+jYm0Js8XHkem98Md1qMkrM8SWKZIfGcnQUT1cWg8lPVpq1TzDOkkXy83A== X-Received: by 2002:a05:6e02:1d05:b0:357:a1cd:a16 with SMTP id i5-20020a056e021d0500b00357a1cd0a16mr8262143ila.6.1699574173617; Thu, 09 Nov 2023 15:56:13 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id v6-20020a056638358600b00463fcddf28bsm3541641jal.167.2023.11.09.15.56.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Nov 2023 15:56:12 -0800 (PST) Message-ID: <34dbbd47-c3b3-4851-97d5-af186656bdcf@gmail.com> Date: Thu, 9 Nov 2023 16:56:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISC-V: Move cond_copysign from combine pattern to autovec pattern Content-Language: en-US To: Juzhe-Zhong , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, rdapp.gcc@gmail.com References: <20231109233325.2189755-1-juzhe.zhong@rivai.ai> From: Jeff Law In-Reply-To: <20231109233325.2189755-1-juzhe.zhong@rivai.ai> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/23 16:33, Juzhe-Zhong wrote: > Since cond_copysign has been support into match.pd (middle-end). > We don't need to support conditional copysign by RTL combine pass. > > Instead, we can support it by direct explicit cond_copysign optab. > > conditional copysign tests are already available in the testsuite. > No need to add tests. > > gcc/ChangeLog: > > * config/riscv/autovec-opt.md (*cond_copysign): Remove. > * config/riscv/autovec.md (cond_copysign): New pattern. I assume you ran the testsuite after this change to ensure there weren't any regressions? We need to make sure that we indicate what testing we've done. You don't need to run every multilib or anything like that. For a given change I trust you to run a reasonable set of test. OK assuming you've done a testsuite run. Jeff