From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id D6C3E385840E for ; Mon, 11 Mar 2024 10:31:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6C3E385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6C3E385840E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710153114; cv=none; b=KOhK39PFboGQP6GQA6Ayx8PfRAaxBAjij0oo2LOnsqhneYNLj+YxIEEye6Jq06AVmQUxjMT4gTnjHMJyMPGxcBsscMWHi4VTLBZ8f3rtPSlNgNTBbGEwECdduocA9gLEPsS6OjWpp9FJYHdHryFVPWiIiamQLbM1DnNEqbZ7bc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710153114; c=relaxed/simple; bh=zWhCx/y6rM6/gNuivRlMMPxwjNzvFBG62UfnrKoQ2Uc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=tYwK9m7GNjA7rFYc5g7MCrkKpZrn0Y8KbmitzTKPWRMlk09QysDRCZRZ9/IJVkFntxwSc748CamCVUQDXhv19Ig56mJaFkoWZvUAH4SX+5X+Z+Y/uSi8hnx6Uujl/x/OoVwYzFSkvkMvrfk+pO4eE/zSUxqgwG41yh3I0GkSv0A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C3D455C553; Mon, 11 Mar 2024 10:31:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710153111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jpEYzaKflxv+lIpZAge0kMWR3DjwKEH6JzrOvQUhUU=; b=bUZtMDUrzukikpWzTaLOUxXCTxqkoEgW7GqVovj8Rgd4Rj4jfQ/vzdvD5PE95dH03Q3MnM RZgYX6r5lDLh3vw3HtQ0HtpqvuACB90as86l77BCynVg9ijL7k57esEKKukg+hSVYmtEZp 2U5FGhrUCwzD1HSIdbfTwR9o2cQmjZg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710153111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jpEYzaKflxv+lIpZAge0kMWR3DjwKEH6JzrOvQUhUU=; b=Q/HJ0qDjPtainREIqJA/ujubAgmZUnBcYV0QUPJwkpVUoH4ftcs5Sh7wYdjdvL5BOx5QLF Akqd1w2GVsY7ACBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1710153111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jpEYzaKflxv+lIpZAge0kMWR3DjwKEH6JzrOvQUhUU=; b=bUZtMDUrzukikpWzTaLOUxXCTxqkoEgW7GqVovj8Rgd4Rj4jfQ/vzdvD5PE95dH03Q3MnM RZgYX6r5lDLh3vw3HtQ0HtpqvuACB90as86l77BCynVg9ijL7k57esEKKukg+hSVYmtEZp 2U5FGhrUCwzD1HSIdbfTwR9o2cQmjZg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1710153111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1jpEYzaKflxv+lIpZAge0kMWR3DjwKEH6JzrOvQUhUU=; b=Q/HJ0qDjPtainREIqJA/ujubAgmZUnBcYV0QUPJwkpVUoH4ftcs5Sh7wYdjdvL5BOx5QLF Akqd1w2GVsY7ACBw== Date: Mon, 11 Mar 2024 11:31:51 +0100 (CET) From: Richard Biener To: Jakub Jelinek cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bitint, v2: Avoid rewriting large/huge _BitInt vars into SSA after bitint lowering [PR114278] In-Reply-To: Message-ID: <34s83n35-sss1-6640-943n-4qsqs74771qr@fhfr.qr> References: <75DCD6B5-A571-46F4-B735-F5C9DE2F0949@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out2.suse.de; none X-Spamd-Result: default: False [-3.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,tree-ssa.cc:url]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Score: -3.10 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 11 Mar 2024, Jakub Jelinek wrote: > On Sat, Mar 09, 2024 at 12:25:42PM +0100, Richard Biener wrote: > > Ideally we?d clear TREE_ADDRESSABLE but set DECL_NOT_GIMPLE_REG, > > I think the analysis where we check the base would be a more > > appropriate place to enforce that. > > So like this? Hm, I was thinking of non_rewritable_lvalue_p/non_rewritable_mem_ref_base though that requires duplicating, so I guess handling in maybe_optimize_var would work. I do now wonder whether setting DECL_NOT_GIMPLE_REG_P in bitfield lowering would prevail? (sorry for approving the earlier patch now, I was too quick and didn't remember the discussion) Richard. > Bootstrapped/regtested on x86_64-linux and i686-linux. > > 2024-03-11 Jakub Jelinek > > PR tree-optimization/114278 > * tree-ssa.cc (maybe_optimize_var): If large/huge _BitInt vars are no > longer addressable, set DECL_NOT_GIMPLE_REG_P on them. > > * gcc.dg/bitint-99.c: New test. > > --- gcc/tree-ssa.cc.jj 2024-01-03 11:51:39.902615009 +0100 > +++ gcc/tree-ssa.cc 2024-03-09 23:34:12.469223987 +0100 > @@ -1785,6 +1785,20 @@ maybe_optimize_var (tree var, bitmap add > fprintf (dump_file, "\n"); > } > } > + else if (TREE_CODE (TREE_TYPE (var)) == BITINT_TYPE > + && (cfun->curr_properties & PROP_gimple_lbitint) != 0 > + && TYPE_PRECISION (TREE_TYPE (var)) > MAX_FIXED_MODE_SIZE) > + { > + /* Don't rewrite large/huge _BitInt vars after _BitInt lowering > + into SSA form. */ > + DECL_NOT_GIMPLE_REG_P (var) = 1; > + if (dump_file) > + { > + fprintf (dump_file, "_BitInt var after its lowering: "); > + print_generic_expr (dump_file, var); > + fprintf (dump_file, "\n"); > + } > + } > else if (DECL_NOT_GIMPLE_REG_P (var)) > { > maybe_reg = true; > --- gcc/testsuite/gcc.dg/bitint-99.c.jj 2024-03-08 14:26:17.658069942 +0100 > +++ gcc/testsuite/gcc.dg/bitint-99.c 2024-03-08 14:25:36.292645965 +0100 > @@ -0,0 +1,26 @@ > +/* PR tree-optimization/114278 */ > +/* { dg-do compile { target bitint } } */ > +/* { dg-options "-O2 -fno-tree-dce -fno-tree-dse -fno-tree-ccp" } */ > +/* { dg-additional-options "-mavx2" { target i?86-*-* x86_64-*-* } } */ > + > +void > +foo (void *p) > +{ > + _BitInt(64) b = *(_BitInt(64) *) __builtin_memmove (&b, p, sizeof (_BitInt(64))); > +} > + > +#if __BITINT_MAXWIDTH__ >= 128 > +void > +bar (void *p) > +{ > + _BitInt(128) b = *(_BitInt(128) *) __builtin_memmove (&b, p, sizeof (_BitInt(128))); > +} > +#endif > + > +#if __BITINT_MAXWIDTH__ >= 256 > +void > +baz (void *p) > +{ > + _BitInt(256) b = *(_BitInt(256) *) __builtin_memmove (&b, p, sizeof (_BitInt(256))); > +} > +#endif > > Jakub > > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)