From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40405 invoked by alias); 1 Dec 2017 10:18:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40385 invoked by uid 89); 1 Dec 2017 10:18:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_SHORT,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr50051.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.107.5.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Dec 2017 10:18:18 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Sudi.Das@arm.com; Received: from [10.2.206.246] (217.140.96.140) by VI1PR08MB1054.eurprd08.prod.outlook.com (2a01:111:e400:c549::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.282.5; Fri, 1 Dec 2017 10:18:13 +0000 Subject: Re: [PATCH][ARM] Fix wrong code by arm_final_prescan with fp16 move instructions To: Kyrill Tkachov , "gcc-patches@gcc.gnu.org" References: <4db1e5be-24b1-bab7-d351-b00ef5332728@arm.com> <5A1C0434.5000109@foss.arm.com> <2662e77b-cf75-8072-d6ef-14e184ce95c1@arm.com> <5A202CDE.10906@foss.arm.com> Cc: nd , Ramana Radhakrishnan , Richard Earnshaw From: Sudakshina Das Message-ID: <35398dba-0460-4c3d-4da7-2f6c2b34f006@arm.com> Date: Fri, 01 Dec 2017 10:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5A202CDE.10906@foss.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR0402CA0003.eurprd04.prod.outlook.com (2603:10a6:3:d0::13) To VI1PR08MB1054.eurprd08.prod.outlook.com (2a01:111:e400:c549::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 31424db5-7caf-4bee-647f-08d538a4d4da X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603286);SRVR:VI1PR08MB1054; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1054;3:cDbiJmiig68D7y20Hu17Pb1z5H/FT3oxw9yWKAevSpDbMdYOiEh4x8dj/ATQV/iAhC0lLqAoGIv6lHRx+cyt0ss69h1ZOn/6p59ly8vB6QPbVMG2PYUC5r+mm/g9bh8P4T4tx1AoRZoDDMnjng1MbIP7I6VVD2wLeXjBFInBMjVN9e0LxZE6ktuwEC/cIeHodsfh+HoFHt3w6+3nChvCIG0Tbihwfj1Bz4I4CQ3cIIny2pqRPBw3kGGOVV9Bybws;25:hlL9hR8yzwskTn9gwmTPUH7u4olAMllz7me3C/g6i8KONu6PJzI2ZH3vTIJATqqCwie3iV7M62bYtZJuIrl/2pdc1w2y5++7CbKNRcqwhjvK2Ih3l+BDtsgdzbt5j+0z6UVLXvFoE98EBLCQoQIbXYHaoxgshqulbDBuKoHimtkiAPRcM58VHZrjF0sevMoEkRLQALU3dEtRSYpqZ9E9W32I13OesMT9UK9jqJ/ov3AH4lxiOQ3wC51dhQRSUrFE+cOuDfAVnsT1LI0AMHb/Goj1kM7NkP4RfXshSz74Kc9ovzDkb831sAkY4LNfo0NW0/oxx58G1oVJqtuvcI7ylA==;31:UPQImZjpCVgNdYEEJLgTSzgK78b/qiUg4EMRM3mNzXg4o/kU+v9xxgQAueL56e23sIBg2uilax7rso02hdmCgBZub9nNEU8x0ijwchuINXiWm16QJ83ejKAS48mqGhJqsK0GI3geZM67n66042rTiJnldpmo3wdlcmH+2d3aT/Gjk8lgOf0Faw0/dF+lVWE4XcXbWvz6P0Wkc5wrjWQ4DYWMmZ+tZqokGu0FLkVkuJ0= X-MS-TrafficTypeDiagnostic: VI1PR08MB1054: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1054;20:6DEzcUNXlyWRc78JB2n6J9K3pfvU9qqNGb3NcIn6Mu4jbll1o9lyXHrypXP5CXZU51z22bUPev3jlWYs5Z+qxA/BHNbAKFYQmNgUVvTeL+ocRv3cs8jVDnCI9O5Lj51fU5Hj8cXkDYeikGXYFsiRKtEMyaEL0pAKwrFamZCF0W8=;4:bQv1YLf/GbjikL3JhsKO9Zi2dsjNnNaqiXJuzbAXC6vcnMXLopUjEFD0ZjLz7A6nBid3N+yBzO40qgsRkronMGC2RH1nvnK+023DN/J11tE02N+kJVc4I9kIZFEPR5KQZ6mY2ltSj1f13TU8bORtajcQlkUTQ9El8iNpJRM3fa4FzqPnpMOe6ACZINUCvVEmdQollhg9qS2SSaqKehDIvs/3tFn03FXvxeKJxhP89fc4+KzZZuVZuDBPDElqOCmWDAMz3fPn0LQQ7qWodlZEKaYmpb2BOzaRnfX7tt7h68M6x9hCovY1smkj7RfnQ5e3rVaW3oFFzeReVuQjooNZzFqEAjDoolFw8gPt75pkC2CqOIjExFqxTDelfijjGeLH X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(22074186197030)(183786458502308); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3231022)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(20161123560025)(20161123555025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011);SRVR:VI1PR08MB1054;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR08MB1054; X-Forefront-PRVS: 05087F0C24 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(346002)(366004)(39860400002)(199003)(189002)(24454002)(54534003)(377424004)(6306002)(77096006)(6486002)(68736007)(64126003)(2950100002)(5660300001)(53546010)(33646002)(16526018)(6666003)(2501003)(16576012)(6246003)(53936002)(54356011)(76176011)(230700001)(229853002)(54906003)(50466002)(58126008)(2906002)(110136005)(316002)(7736002)(25786009)(81166006)(305945005)(81156014)(478600001)(8676002)(3846002)(6116002)(4326008)(106356001)(23676004)(31686004)(4001150100001)(93886005)(65826007)(86362001)(8936002)(36756003)(105586002)(47776003)(52116002)(83506002)(31696002)(189998001)(966005)(65806001)(72206003)(2486003)(65956001)(97736004)(52146003)(67846002)(66066001)(101416001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB1054;H:[10.2.206.246];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4TUIxMDU0OzIzOk0vdlBOb3Q5ck1LQ3Y0SDhOREpQYTBQb3VX?= =?utf-8?B?STNPb2lOZEt3b2JBOUVJbUgxTng1UzRlN1A1Rk5aa2FEZUZNVUQwSUwvM2xW?= =?utf-8?B?aXU3R2dEdy9mdGVNTFRwOGFTZVJGdnVtai85eURiTWpIRm14V08razVtTTJB?= =?utf-8?B?Q3c2cFk3SVJkSmdZQXpYWVptenFlS1diZUpSYXVjdW1DaHBHRHRuT3Nndzhu?= =?utf-8?B?cGFCS3dLSG55SFFqbHd5cysvdVNicnFHZ1BSZE5sUjNWSnlkTUNaUElDeHlD?= =?utf-8?B?YmpIT3Z5Y1huNXp1a2hJVXQwcTBRMnhJRjJ2VzlFZ2M5OEV4cCtYODZTcEpv?= =?utf-8?B?Tk5hRktkbkEzeTVNRW1neEtscXpUYUFPTXJUUlFGVy9YaVBqMFEva2dETGlx?= =?utf-8?B?S040T1ZWUmJrZXVRSDBVVnMwbGtMS2QvbmU2akNOQy9SUWlZaG1wV3pXV1dR?= =?utf-8?B?YUN2QU9YMFhSWENhdEl6Q01EdVk5TVdTWnRqVGJROXVHWWhWblVZUVk0b3Nx?= =?utf-8?B?S2p5eERoWmpFR1MrcnpmeHVRcWFUNlcyZEJkQTBoYmNSRGhwanZ6VUhHVi9T?= =?utf-8?B?ekNNNnZaVEpjbzRzaVAyWFUvQlkzL1ZwbWI5cFFmS3hKa2YvR3JkT1ViV2cr?= =?utf-8?B?LzFMUjk0Q0JHc3ZTdFR1MXZuQ3d2alFIaHpQQUFqK0lkQUhzYnl0Z1lZeFIr?= =?utf-8?B?c2xFZ3JIMTZudFZpbHBPRFZPVXVmZllpZytWbzkyVFNWQ2FnejRrYitxR3Vv?= =?utf-8?B?WVc2YmJka0RTNzU0ZnpGMEtCVEQwS05ZVkZlTW5kOXl1NWM5K1hJeSswRDhy?= =?utf-8?B?VDZ0VnpQY2lsL3BIK1ZIbmJUVDJvZzBWeWd6MUhUN1BSQzJZLyt5QmJjZFVr?= =?utf-8?B?YzcwZStleHBvUk5RUGlKOGRyaUpodEJsajd6QUFaQS9iODhOMldxMDdVWWFw?= =?utf-8?B?T0FQVU1MQ0dieXVTamtFeUdDWGkramlWdGlGKytGa1RGTG5tOFMyamNrbnZM?= =?utf-8?B?bnU0aDFnNDNtcUoyaldJQU9lU2FsRDYyblFWSHpKeElUVGE4UEdjeVluOEpj?= =?utf-8?B?dk0rTjZJUTZlc2I4dGJTU1RBdjYwakU5UXp4MHdsSzJLNFQxRkRMTU1OUzJq?= =?utf-8?B?ZWc4TUVOdllVSmdlbHBnem13eG0xYXhCb0JpTjBMNzlxRkpDNHdBTWYxYXN6?= =?utf-8?B?d3JlRFFGUitUbFovOUx2MnNHQUM0a2lvNGRDT1BxanRNL3lkb1Z1K0psSTJU?= =?utf-8?B?VktheS9rN045QTIzcEl4OEZtUTZCNHlGZVAyTDZHSTVmOXFCWi9Yc0V1ZUw3?= =?utf-8?B?bUExbnFQenJzTys5clhhVkJEWUdVYU1KbEcrVllPbE5iUHQwQVU0OExYSUI3?= =?utf-8?B?TTl6aFZTUnBEY0FFR0E1TUJZdHRDQkc2UXVVKzRKa0lFWCs3WDczSnJMWXFj?= =?utf-8?B?dFVYV0dtNlc4NGYrRFlHUUNvV3U2RTM5Qm9COEQ3dHJrTVROY3U4ZDg5WTZW?= =?utf-8?B?OE9ENzNhTjFQb2xNa2N2dkpRZXVmOEZobUk4QjVvSE1Uai9DMlZHdjVvYk1q?= =?utf-8?B?bWRUbWFsMUdjR2pBWFdRNElHcHZTUnJpdVoyL0ErYVpLWVFlY0VjcHBXNjVE?= =?utf-8?B?Szg2UXZlYzJGcjhRRUJWRlNVWW9TYjJPc085TXhtVDBTQVZIZ3FEa1A2c3lt?= =?utf-8?B?K2dWMC9uVlpYNHZnWGdBWVJncWkva3hoSlJhalJyemtnQWd2ZmwwektiU2tH?= =?utf-8?B?eExMNHZCaXQ2NmdBeEx0Mzdrc0NGNWVSckZ3T3lkQVh5ZWQxN1ZybGVZMG1P?= =?utf-8?B?SHp0V0R5L0ZldVU0aVpxOWJOVjBRS1V0bUJPemRwRUlzVzVYTi9XWGZDWnlL?= =?utf-8?B?Q2VmUFFxbkIxNnlyOFBldTVjQmd0anZEZkM5NEJIZ3FSM3RhQ2VwMS91ZnJT?= =?utf-8?B?SmEvM2hlK2ZYNi9uVlRmRnl4dWhSVUltL3ZtdWZlS21EdGRQV2owZmYwWG9h?= =?utf-8?B?Z3BjblViYnBZaXpQY1FtT2pPUUUxQjQ4UHRjUjNzYmVVblphUitSSzB1UjQz?= =?utf-8?B?RHN0S29WMUpVaVlNcCt1Y1F5WUh2blF2VlpWRlVCVyt2RlJwTysySFg2VUNB?= =?utf-8?B?dGNldm1qdGtrWmJPZklaT2p3SjZaTTB4eUNTUjdYVWUxTW5tR1hvRDZUYlJz?= =?utf-8?B?TUpraTBtazFoN0x6V1ZKek8wVGp3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB1054;6:8VkVk5xaBX8B7XJGwLAq+gWAYqL0jymFykoiOf1kDifOmB1pP7Baxcb/96vpgSy2sLnXQjfSsAUehDnZBsTDsyedl9UX+p1rloqjBas4jNcAL0o66wHpZE4JCiG7kXiTNdmp60LMdZT+GJMAPy+cUvMy2mXkdVjk3+/TlCmjEAOQgNvEYrpCT0HLvNSCWBNpLr9RI3AsLZDgZ/Jbl2KwGMENcjI2z/TFcEllOCzjFSFNwufSsS4PCRaiwLfVVG8FI/au2qBL3EKuUpAb1OavR/7MtSnFGYYYKKt9QiFNr3ijXykPrZkzez1qtSjWjuSw1wxhG+d/7VK6Xj6diMvxOkFHH8DS2C7qmPtDaYG+Xes=;5:Fe8KwMTsqT26J7zLHkgarSScgQ436dXv6tfmjEY1+/lZfGrj1132+kEClq3yToljywwFNIvD1KYRdjgVdmkyMCbQEt2Vh7naigPwUcXAjgd8QKKMeaUPtsv1rX0GpJ4Z3hhb6AWXI4KmV2/OdOKGTsoKBtGSfNdkHEktawbRGjY=;24:G1e7J4r6qmHklU7kK8+booqkEoqxH0ED67iW+15kqnOcmC3SLqpH+zPhXv72saZgy0ZA7a/MG/J1+bPJQTKmJZxbgapu2GJYm3bqymyFjE8=;7:S7i69SVgQ1WnIdUAIxwBTaTDYq5kEXjjHWtLx68jpHaIw27hT2EUlbgywTVws3bVMB5P8eEAosVJhKZNzAzugT+X2K+peJFI1x41PsWiKzeMHRL6DAV7nPhg3P3cplf95duZ9U6qkB2eZbJFyN49p8YKkF0a/3OSKW1f4MbHOBcGD+hvmdgDZl87dOWE0YdCvMuLxU0MdCtkqvLdlohFtKJiQG9KLD4pjOv6tIBcBVCWGfTg8B4jHm3icI5a5MKR SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 10:18:13.3886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31424db5-7caf-4bee-647f-08d538a4d4da X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB1054 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00025.txt.bz2 On 30/11/17 16:07, Kyrill Tkachov wrote: > > On 30/11/17 16:06, Sudakshina Das wrote: >> Hi Kyrill >> >> On 27/11/17 12:25, Kyrill Tkachov wrote: >> > Hi Sudi, >> > >> > On 24/11/17 14:57, Sudi Das wrote: >> >> Hi >> >> >> >> For the following test case: >> >> __fp16 >> >> test_select (__fp16 a, __fp16 b, __fp16 c) >> >> { >> >> return (a < b) ? b : c; >> >> } >> >> >> >> when compiled with -mfpu=fp-armv8 -march=armv8.2-a+fp16 -marm >> >> -mfloat-abi=hard trunk generates wrong code: >> >> >> >> test_select: >> >> @ args = 0, pretend = 0, frame = 0 >> >> @ frame_needed = 0, uses_anonymous_args = 0 >> >> @ link register save eliminated. >> >> vcvtb.f32.f16 s0, s0 >> >> vcvtb.f32.f16 s15, s1 >> >> vcmpe.f32 s0, s15 >> >> vmrs APSR_nzcv, FPSCR >> >> // <------ No conditional branch! >> >> vmov s1, s2 @ __fp16 >> >> .L2: >> >> vmov s0, s1 @ __fp16 >> >> bx lr >> >> >> >> There should have been a conditional branch there to skip one of the >> >> VMOVs. >> >> This patch fixes this problem by making *movhf_vfp_fp16 unconditional >> >> wherever needed. >> >> >> >> Testing done: Add a new test case and checked for regressions >> >> arm-none-linux-gnueabihf. >> >> >> >> Is this ok for trunk? >> >> >> > >> > This is ok after assuming a bootstrap on arm-none-linux-gnueabihf >> passes >> > as well. >> > Does this bug appear on the GCC 7 branch? >> > If so, could you please test this patch on that branch as well if so? >> > >> >> I have tested the patch and also sent a new patch request for gcc-7 >> https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02577.html >> > > Thanks Sudi, this is ok to commit to the branch after we let this patch > bake on trunk for a week without problems. > Committed as r255301 on trunk. Will wait for a week before committing to gcc-7. Thanks Sudi > Kyrill > > >> Thanks >> Sudi >> >> > Thanks, >> > Kyrill >> > >> >> Sudi >> >> >> >> ChangeLog entry are as follow: >> >> >> >> *** gcc/ChangeLog *** >> >> >> >> 2017-11-24 Sudakshina Das >> >> >> >> * config/arm/vfp.md (*movhf_vfp_fp16): Add conds attribute. >> >> >> >> *** gcc/testsuite/ChangeLog *** >> >> >> >> 2017-11-24 Sudakshina Das >> >> >> >> * gcc.target/arm/armv8_2-fp16-move-2.c: New test. >> > >> >