From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 889ED3858D28 for ; Sat, 17 Jun 2023 22:03:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 889ED3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-6686c74183cso497123b3a.1 for ; Sat, 17 Jun 2023 15:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687039400; x=1689631400; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=px8vX1DOzmq/2IH1qc0YKqsD4tYb4TwpbaAylGeBEcY=; b=mAdEo/+hmcQYE29pxMHK9UAtHKEctZFRwRYSjU7lnvkOwfrI84GYBgowypyM8dxz6s nkhua6KUZvLtCQN5VelBNCzCnZNSAU/qmBoGVKxOifn+Cy9W3hiVpVQuwQIuySzXvUBn CjJwZX1/QlljHGJEpYwskRci+ICH5Mtj1OnbkvyydXnQ9Ivq+ZEqCdLEpxc/LQxgQNhB b4rCfazp5Djd1KACLuolGigRcNoqz6VqRbHTohwJNVK0r+qOoGkPfwvCz71HNwuqnxyP SCbK5rpYLW078n04jqZcNCOkdx8L7kex+ZU+3WROuCJCB8g4iEN3V3Up/obs/SmKQ2Jw KscA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687039400; x=1689631400; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=px8vX1DOzmq/2IH1qc0YKqsD4tYb4TwpbaAylGeBEcY=; b=RasCfUNcWrRKiet6L/t/1MZgXlG4B/lHTOY3oiOlA5sLilt097JqFTpghI6uMBQaTV qNn8Gla69RnC4wz5PnAAsQHnrK4Y0TASSXjQa0MDwByVgE6ryusVmqAZYMN1/TuIhDFd 8nzl73dlXOiQ/KWJcLUcnK9IBkYm9RQglGYI3CAT3BUl74G7wHcMNgltH5UctLyxj3Qn yPo46PH+Bpiktoj6+gsxFFD/AOVOZ3ScqLONnHfCA3Utx9peHNx4gre94du5l9m2ZhEP mPDnhHVe/DOtUBQPFjeAo6l/YWHvpw3Aj7bHwprkX/9h08f1c1qiB2WWdVhCYHkEZp7P GIOg== X-Gm-Message-State: AC+VfDxrNBmLymUUm6f9a4A9rB/LpHRbsegWyPuYxWQO8KgebI1E1XvW O0yR/byxO0VgBeATGAjwkyg= X-Google-Smtp-Source: ACHHUZ6SH3joVN2Y3S9jHI+p8Pd6r+4xEsQn7GZIvWTdPL3Wvc09R4puSUqZtLCHEjsucdVKmyaXGw== X-Received: by 2002:a05:6a00:182a:b0:668:6eed:7c18 with SMTP id y42-20020a056a00182a00b006686eed7c18mr2300489pfa.9.1687039400414; Sat, 17 Jun 2023 15:03:20 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id u5-20020aa78385000000b0064d4d11b8bfsm15264828pfm.59.2023.06.17.15.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jun 2023 15:03:19 -0700 (PDT) Message-ID: <3566ed67-3689-bc4e-6ce4-45da7b8be467@gmail.com> Date: Sat, 17 Jun 2023 16:03:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] [contrib] validate_failures.py: Don't consider summary line in wrong place Content-Language: en-US To: Thiago Jung Bauermann , gcc-patches@gcc.gnu.org References: <20230616120214.114098-1-thiago.bauermann@linaro.org> From: Jeff Law In-Reply-To: <20230616120214.114098-1-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/16/23 06:02, Thiago Jung Bauermann via Gcc-patches wrote: > When parsing a summary or manifest file, if we're not either after a tool > line (e.g. "=== gdb tests ===") or before a summary line (e.g., > "=== gdb Summary ===") then the current line can't be a valid result line > so ignore it. > > This addresses a problem we're seeing when running the GDB testsuite in > our CI environment where it produces a valid summary file, but then after > the "=== gdb Summary ===" section it outputs a series of Tcl errors that > match _VALID_TEST_RESULTS_REX and thus confuse the parsing logic: > > 05: 14:32 .sum file seems to be broken: tool="None", exp="None", summary_line="ERROR: -------------------------------------------" > 05: 14:32 Traceback (most recent call last): > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 706, in > 05: 14:32 retval = Main(sys.argv) > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 697, in Main > 05: 14:32 retval = CheckExpectedResults() > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 572, in CheckExpectedResults > 05: 14:32 actual = GetResults(sum_files) > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 447, in GetResults > 05: 14:32 build_results.update(ParseSummary(sum_fname)) > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 389, in ParseSummary > 05: 14:32 result = result_set.MakeTestResult(line, ordinal) > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 236, in MakeTestResult > 05: 14:32 return TestResult(summary_line, ordinal, > 05: 14:32 File "/path/to/gcc/contrib/testsuite-management/validate_failures.py", line 148, in __init__ > 05: 14:32 raise > > contrib/ChangeLog: > > * testsuite-management/validate_failures.py (IsInterestingResult): > Add result_set argument and use it. Adjust callers. Thanks. I pushed this to the trunk. jeff