From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 96834 invoked by alias); 2 Jun 2016 20:50:30 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 96819 invoked by uid 89); 2 Jun 2016 20:50:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=dgskipif, dg-skip-if, lxvx, stxvx X-HELO: e19.ny.us.ibm.com Received: from e19.ny.us.ibm.com (HELO e19.ny.us.ibm.com) (129.33.205.209) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Thu, 02 Jun 2016 20:50:28 +0000 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 Jun 2016 16:50:26 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Thu, 2 Jun 2016 16:50:23 -0400 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: wschmidt@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org;dje.gcc@gmail.com;segher@kernel.crashing.org Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com [9.57.198.25]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id C9170C9003E; Thu, 2 Jun 2016 16:50:14 -0400 (EDT) Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u52KoML138862974; Thu, 2 Jun 2016 20:50:22 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6242028041; Thu, 2 Jun 2016 16:50:22 -0400 (EDT) Received: from [9.80.223.192] (unknown [9.80.223.192]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTPS id 1C8E02803A; Thu, 2 Jun 2016 16:50:22 -0400 (EDT) From: Bill Schmidt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: [PATCH, rs6000] Fix PR70957 (skip vsx-elemrev-[24].c tests for a downlevel assembler) Date: Thu, 02 Jun 2016 20:50:00 -0000 Message-Id: <357F7A5D-0FB5-41F9-8959-E9A3366A0D51@linux.vnet.ibm.com> Cc: Segher Boessenkool , David Edelsohn To: GCC Patches Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16060220-0057-0000-0000-0000047F3DFA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused X-IsSubscribed: yes X-SW-Source: 2016-06/txt/msg00218.txt.bz2 Hi, PR70957 reports that the two subject tests fail on an older P7 machine. Th= ese tests rely on built-ins that exploit POWER9 vector support. It turns out that the failur= e occurs because the configured assembler is downlevel, and does not support even POWER8 instruc= tions. This=20 causes TARGET_P8_VECTOR to be set to false, which in turn causes TARGET_P9_= VECTOR to be set to false, so the built-ins in question are not linked into the ov= erloaded built-in table. The only way I know to make the test predictable is to use a run-time test = to check whether P9 vector instructions will execute. Thus this solution. I=E2=80=99ve ver= ified we no longer have test failures on machines with a downlevel assembler, and the tests run correctl= y on machines with an up-to-date assembler. Is this ok for trunk and 6.2? Thanks, Bill [2016-06-02] Bill Schmidt PR target/70957 * gcc.target/powerpc/vsx-elemrev-2.c: Require p9vector hardware support. * gcc.target/powerpc/vsx-elemrev-4.c: Likewise. Index: gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c (revision 237044) +++ gcc/testsuite/gcc.target/powerpc/vsx-elemrev-2.c (working copy) @@ -1,6 +1,7 @@ /* { dg-do compile { target { powerpc64le*-*-* } } } */ /* { dg-skip-if "do not override mcpu" { powerpc*-*-* } { "-mcpu=3D*" } { = "-mcpu=3Dpower9" } } */ /* { dg-options "-mcpu=3Dpower9 -O0" } */ +/* { dg-require-effective-target p9vector_hw } */ /* { dg-final { scan-assembler-times "lxvd2x" 6 } } */ /* { dg-final { scan-assembler-times "lxvw4x" 6 } } */ /* { dg-final { scan-assembler-times "lxvh8x" 4 } } */ Index: gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c (revision 237044) +++ gcc/testsuite/gcc.target/powerpc/vsx-elemrev-4.c (working copy) @@ -1,6 +1,7 @@ /* { dg-do compile { target { powerpc64-*-* } } } */ /* { dg-skip-if "do not override mcpu" { powerpc*-*-* } { "-mcpu=3D*" } { = "-mcpu=3Dpower9" } } */ /* { dg-options "-mcpu=3Dpower9 -O0" } */ +/* { dg-require-effective-target p9vector_hw } */ /* { dg-final { scan-assembler-times "lxvx" 40 } } */ /* { dg-final { scan-assembler-times "stxvx" 40 } } */ =20