public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Harald Anlauf <anlauf@gmx.de>
To: Paul Richard Thomas <paul.richard.thomas@gmail.com>,
	"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault
Date: Sat, 17 Jun 2023 20:01:32 +0200	[thread overview]
Message-ID: <358e8e69-8fc9-8d00-7fde-9aaa86371c87@gmx.de> (raw)
In-Reply-To: <CAGkQGiJyZDofE5VhYpCgKKyHg8YSQBLBZMYJspfJ40Kf6J+PcA@mail.gmail.com>

Hi Paul,

On 6/17/23 11:14, Paul Richard Thomas via Gcc-patches wrote:
> Hi All,
>
> The attached patch is amply described by the comments and the
> changelog. It also includes the fix for the memory leak in decl.cc, as
> promised some days ago.
>
> OK for trunk?

I hate to say it, but you forgot to add the testcase again... :-(

The patch fixes your "extended" testcase in

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107900#c2

but the original one in comment ICEs for me here:

% gfc-14 pr107900.f90
f951: internal compiler error: Segmentation fault
0x1025c2f crash_signal
         ../../gcc-trunk/gcc/toplev.cc:314
0x9d31d3 resolve_select_type
         ../../gcc-trunk/gcc/fortran/resolve.cc:9791
0x9cef5e gfc_resolve_code(gfc_code*, gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:12588
0x9d2431 resolve_codes
         ../../gcc-trunk/gcc/fortran/resolve.cc:18057
0x9d24fe gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18092
0x9cf0ee gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18077
0x9cf0ee resolve_block_construct
         ../../gcc-trunk/gcc/fortran/resolve.cc:10971
0x9cf0ee gfc_resolve_code(gfc_code*, gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:12596
0x9d2431 resolve_codes
         ../../gcc-trunk/gcc/fortran/resolve.cc:18057
0x9d24fe gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18092
0x9b11f1 resolve_all_program_units
         ../../gcc-trunk/gcc/fortran/parse.cc:6864
0x9b11f1 gfc_parse_file()
         ../../gcc-trunk/gcc/fortran/parse.cc:7120
0xa033ef gfc_be_parse_file
         ../../gcc-trunk/gcc/fortran/f95-lang.cc:229

It hits an assert here:

9790          st = gfc_find_symtree (ns->sym_root, name);
9791          gcc_assert (st->n.sym->assoc);

My tree is slightly modified, but the changes should not have
any effect here.

Can you please have a look, too?

Thanks,
Harald

> Regards
>
> Paul
>
> PS This leaves 89645 and 99065 as the only real blockers to PR87477.
> These will take a little while to fix. They come about because the
> type of the associate name is determined by that of a derived type
> function that hasn't been parsed at the time that component references
> are being parsed. If the order of the contained procedures is
> reversed, both test cases compile correctly. The fix will comprise
> matching the component name to the accessible derived types, while
> keeping track of all the references in case the match is ambiguous and
> has to be fixed up later.


WARNING: multiple messages have this Message-ID
From: Harald Anlauf <anlauf@gmx.de>
To: gcc-patches@gcc.gnu.org
Cc: fortran@gcc.gnu.org
Subject: Re: [Patch, fortran] PR107900 Select type with intrinsic type inside associate causes ICE / Segmenation fault
Date: Sat, 17 Jun 2023 20:01:32 +0200	[thread overview]
Message-ID: <358e8e69-8fc9-8d00-7fde-9aaa86371c87@gmx.de> (raw)
Message-ID: <20230617180132.HzKM_mE5oenJ_g0f7IWs_juydzZtjtFZKdOudsMpnXk@z> (raw)
In-Reply-To: <CAGkQGiJyZDofE5VhYpCgKKyHg8YSQBLBZMYJspfJ40Kf6J+PcA@mail.gmail.com>

Hi Paul,

On 6/17/23 11:14, Paul Richard Thomas via Gcc-patches wrote:
> Hi All,
> 
> The attached patch is amply described by the comments and the
> changelog. It also includes the fix for the memory leak in decl.cc, as
> promised some days ago.
> 
> OK for trunk?

I hate to say it, but you forgot to add the testcase again... :-(

The patch fixes your "extended" testcase in

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107900#c2

but the original one in comment ICEs for me here:

% gfc-14 pr107900.f90
f951: internal compiler error: Segmentation fault
0x1025c2f crash_signal
         ../../gcc-trunk/gcc/toplev.cc:314
0x9d31d3 resolve_select_type
         ../../gcc-trunk/gcc/fortran/resolve.cc:9791
0x9cef5e gfc_resolve_code(gfc_code*, gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:12588
0x9d2431 resolve_codes
         ../../gcc-trunk/gcc/fortran/resolve.cc:18057
0x9d24fe gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18092
0x9cf0ee gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18077
0x9cf0ee resolve_block_construct
         ../../gcc-trunk/gcc/fortran/resolve.cc:10971
0x9cf0ee gfc_resolve_code(gfc_code*, gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:12596
0x9d2431 resolve_codes
         ../../gcc-trunk/gcc/fortran/resolve.cc:18057
0x9d24fe gfc_resolve(gfc_namespace*)
         ../../gcc-trunk/gcc/fortran/resolve.cc:18092
0x9b11f1 resolve_all_program_units
         ../../gcc-trunk/gcc/fortran/parse.cc:6864
0x9b11f1 gfc_parse_file()
         ../../gcc-trunk/gcc/fortran/parse.cc:7120
0xa033ef gfc_be_parse_file
         ../../gcc-trunk/gcc/fortran/f95-lang.cc:229

It hits an assert here:

9790          st = gfc_find_symtree (ns->sym_root, name);
9791          gcc_assert (st->n.sym->assoc);

My tree is slightly modified, but the changes should not have
any effect here.

Can you please have a look, too?

Thanks,
Harald

> Regards
> 
> Paul
> 
> PS This leaves 89645 and 99065 as the only real blockers to PR87477.
> These will take a little while to fix. They come about because the
> type of the associate name is determined by that of a derived type
> function that hasn't been parsed at the time that component references
> are being parsed. If the order of the contained procedures is
> reversed, both test cases compile correctly. The fix will comprise
> matching the component name to the accessible derived types, while
> keeping track of all the references in case the match is ambiguous and
> has to be fixed up later.



  parent reply	other threads:[~2023-06-17 18:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-17  9:14 Paul Richard Thomas
2023-06-17 15:33 ` Steve Kargl
2023-06-17 18:01 ` Harald Anlauf [this message]
2023-06-17 18:01   ` Harald Anlauf
     [not found]   ` <CAGkQGi+A5OuESANYKB=SOv1a4VqogCinV5+YCijn3+y+Pbq+mA@mail.gmail.com>
2023-06-20 10:54     ` Paul Richard Thomas
2023-06-20 21:57       ` Harald Anlauf
2023-06-20 21:57         ` Harald Anlauf
2023-06-21 16:12         ` Paul Richard Thomas
2023-06-21 16:46           ` Steve Kargl
2023-06-21 18:40           ` Harald Anlauf
2023-06-21 18:40             ` Harald Anlauf
2023-06-21 19:17       ` Bernhard Reutner-Fischer
2023-06-22  6:19         ` Paul Richard Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=358e8e69-8fc9-8d00-7fde-9aaa86371c87@gmx.de \
    --to=anlauf@gmx.de \
    --cc=fortran@gcc.gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=paul.richard.thomas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).