From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <rguenther@suse.de>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
 by sourceware.org (Postfix) with ESMTPS id CBB843858013
 for <gcc-patches@gcc.gnu.org>; Wed,  2 Mar 2022 09:45:14 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CBB843858013
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out1.suse.de (Postfix) with ESMTP id 07AB9218A9;
 Wed,  2 Mar 2022 09:45:14 +0000 (UTC)
Received: from murzim.suse.de (murzim.suse.de [10.160.4.192])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id F3D05A3B8F;
 Wed,  2 Mar 2022 09:45:13 +0000 (UTC)
Date: Wed, 2 Mar 2022 10:45:13 +0100 (CET)
From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details
In-Reply-To: <Yh86/AnXVJpoV6yR@tucnak>
Message-ID: <359rr82-8s98-1s58-s498-213o9no62s55@fhfr.qr>
References: <Yh86/AnXVJpoV6yR@tucnak>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2022 09:45:15 -0000

On Wed, 2 Mar 2022, Jakub Jelinek wrote:

> Hi!
> 
> When debugging the PR104589 issue, I've run into a problem that
> goto_locus doesn't show up in the logs, so it wasn't clear if
> the bug hasn't been introduced far earlier just by divergence
> in goto_locus of some edge.
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk,
> or for GCC 13?

OK for trunk.

Richard.

> 2022-03-02  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* cfg.cc (dump_edge_info): Dump goto_locus if present.
> 
> --- gcc/cfg.cc.jj	2022-01-18 11:58:58.944991171 +0100
> +++ gcc/cfg.cc	2022-03-01 15:33:08.170217978 +0100
> @@ -555,6 +555,10 @@ dump_edge_info (FILE *file, edge e, dump
>  
>        fputc (')', file);
>      }
> +
> +  if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION)
> +    fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus),
> +	     LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus));
>  }
>  
>  DEBUG_FUNCTION void
> 
> 	Jakub
> 
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)