* [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details
@ 2022-03-02 9:38 Jakub Jelinek
2022-03-02 9:45 ` Richard Biener
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Jelinek @ 2022-03-02 9:38 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
Hi!
When debugging the PR104589 issue, I've run into a problem that
goto_locus doesn't show up in the logs, so it wasn't clear if
the bug hasn't been introduced far earlier just by divergence
in goto_locus of some edge.
Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk,
or for GCC 13?
2022-03-02 Jakub Jelinek <jakub@redhat.com>
* cfg.cc (dump_edge_info): Dump goto_locus if present.
--- gcc/cfg.cc.jj 2022-01-18 11:58:58.944991171 +0100
+++ gcc/cfg.cc 2022-03-01 15:33:08.170217978 +0100
@@ -555,6 +555,10 @@ dump_edge_info (FILE *file, edge e, dump
fputc (')', file);
}
+
+ if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION)
+ fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus),
+ LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus));
}
DEBUG_FUNCTION void
Jakub
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details
2022-03-02 9:38 [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details Jakub Jelinek
@ 2022-03-02 9:45 ` Richard Biener
0 siblings, 0 replies; 2+ messages in thread
From: Richard Biener @ 2022-03-02 9:45 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: gcc-patches
On Wed, 2 Mar 2022, Jakub Jelinek wrote:
> Hi!
>
> When debugging the PR104589 issue, I've run into a problem that
> goto_locus doesn't show up in the logs, so it wasn't clear if
> the bug hasn't been introduced far earlier just by divergence
> in goto_locus of some edge.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk,
> or for GCC 13?
OK for trunk.
Richard.
> 2022-03-02 Jakub Jelinek <jakub@redhat.com>
>
> * cfg.cc (dump_edge_info): Dump goto_locus if present.
>
> --- gcc/cfg.cc.jj 2022-01-18 11:58:58.944991171 +0100
> +++ gcc/cfg.cc 2022-03-01 15:33:08.170217978 +0100
> @@ -555,6 +555,10 @@ dump_edge_info (FILE *file, edge e, dump
>
> fputc (')', file);
> }
> +
> + if (do_details && LOCATION_LOCUS (e->goto_locus) > BUILTINS_LOCATION)
> + fprintf (file, " %s:%d:%d", LOCATION_FILE (e->goto_locus),
> + LOCATION_LINE (e->goto_locus), LOCATION_COLUMN (e->goto_locus));
> }
>
> DEBUG_FUNCTION void
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-02 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-02 9:38 [PATCH] cfg: Dump goto_locus if -fdump-*-*-blocks-details Jakub Jelinek
2022-03-02 9:45 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).