From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id E13E93858408; Fri, 3 Mar 2023 12:54:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E13E93858408 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.98,230,1673942400"; d="scan'208";a="98704940" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 03 Mar 2023 04:54:18 -0800 IronPort-SDR: vXydGKWRUtW8qD+iBpJT/APmguOc3LR2vTpky3Mqj9nsg/8U/v7VOJiQzJZLeGN5Sc4ZtXBffh Src1V45bpnvcRuDwE1okcdaFZTAXRVAUPSrAhzpIhU+wmCIYYzyXOztbmcHAvyEW4IiCmUBEFR NtTN4/YWr5ck5Tyrfup3y4E9VTHel+Ev8sz/KyN7UWGwv1dkJknQT5tUQJxDC0l8tFNacnaJqs z/MOMWJkhpiDEBlBaLaosMAuv4pEQRDtiH+Y1TOLUAcKmrVxA+Hk1BCtmszl2Tm4gmhLEwnrpR mCI= Message-ID: <35a11e42-c5d7-3e56-3197-646dabddee23@codesourcery.com> Date: Fri, 3 Mar 2023 13:54:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCHv2, gfortran] Escalate failure when Hollerith constant to real conversion fails [PR103628] Content-Language: en-US To: HAO CHEN GUI , gcc-patches , fortran CC: Segher Boessenkool , David , Kewen.Lin , Peter Bergner References: <5049d46a-5edb-42c1-798a-b21410f6bdc0@codesourcery.com> From: Tobias Burnus In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Haochen, On 03.03.23 10:56, HAO CHEN GUI via Gcc-patches wrote: > Sure, I will merge it into the patch and do the regression test. Thanks :-) > Additionally, Kewen suggested: >>> Since this test case is powerpc only, I think it can be moved to gcc/te= stsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.expgcc.target/powerpc/pp= c-fortran. >> Which sounds reasonable. > Test cases under gcc.target are tested by check-gcc-c. It greps "warning" > and "error" (C style, lower case) from the output while check-gcc-fortran > greps "Warning" and "Error" (upper case). As the test case needs to check > the "Warning" and "Error" messages. I have to put it in gfortran.dg > directory. What's your opinion? Thanks for digging and giving a reason. Looks as if at some point, adapting gcc/testsuite/gcc.target/powerpc/ppc-fortran/ppc-fortran.exp to handle this as well could make sense. But placing it - as you did - under gcc/testsuite/gfortran.dg is fine and surely the simpler solution. Thus, leave it as it. Thanks, Tobias > > Gui Haochen > Thanks ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955