From: Tobias Burnus <tobias@codesourcery.com>
To: Thomas Koenig <tkoenig@netcologne.de>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch, fortran] Correct fndecls for some library functions
Date: Wed, 25 Nov 2020 12:58:29 +0100 [thread overview]
Message-ID: <35c31819-2a40-91a3-c917-8d4fb8f52ecc@codesourcery.com> (raw)
In-Reply-To: <7d637428-5aab-f3f6-e698-ecaf93084c96@netcologne.de>
Hello Thomas,
On 15.11.20 18:52, Thomas Koenig via Fortran wrote:
>
> this patch makes sure that we pass the correct fn decls for
> some of our library functions. cshift and others still remain
> to be implemented.
Thanks
> +#define ADD_CHAR(c) do { *fp++ = c; *fp++ = ' '; } while(0)
> ...
> + ADD_CHAR ('.'); /* Function return. */
Shouldn't this be ".c" instead of ". " as neither global memory is read
nor written to?
> + if (expr->rank == 0)
> + {
> + if (expr->ts.type == BT_CHARACTER)
> + {
> + ADD_CHAR ('w'); /* Address of character. */
> + ADD_CHAR ('.'); /* Length of character. */
> + }
> + }
> + else
> + ADD_CHAR ('w'); /* Return value is a descriptor. */
shouldn't this be "o"?
Otherwise, it looks good to me.
Tobias
-----------------
Mentor Graphics (Deutschland) GmbH, Arnulfstraße 201, 80634 München / Germany
Registergericht München HRB 106955, Geschäftsführer: Thomas Heurung, Alexander Walter
next prev parent reply other threads:[~2020-11-25 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 17:52 Thomas Koenig
2020-11-21 8:16 ` *ping* " Thomas Koenig
2020-11-23 21:29 ` Iain Sandoe
2020-11-23 22:16 ` Thomas Koenig
2020-11-25 11:58 ` Tobias Burnus [this message]
2020-11-27 15:46 ` Tobias Burnus
2020-11-28 11:42 ` Thomas Koenig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35c31819-2a40-91a3-c917-8d4fb8f52ecc@codesourcery.com \
--to=tobias@codesourcery.com \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tkoenig@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).