From: Jeff Law <jeffreyalaw@gmail.com>
To: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] tree-optimization/106422 - verify block copying in forward threading
Date: Sat, 30 Jul 2022 09:31:44 -0600 [thread overview]
Message-ID: <35d1df93-134c-43ed-6d8d-d3ad9cf26c66@gmail.com> (raw)
In-Reply-To: <20220729084701.C077113A1B@imap2.suse-dmz.suse.de>
On 7/29/2022 2:47 AM, Richard Biener via Gcc-patches wrote:
> The forward threader failed to check whether it can actually duplicate
> blocks. The following adds this in a similar place the backwards threader
> performs this check.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed.
>
> PR tree-optimization/106422
> * tree-ssa-threadupdate.cc (fwd_jt_path_registry::update_cfg):
> Check whether we can copy thread blocks and cancel the thread if not.
>
> * gcc.dg/torture/pr106422.c: New testcase.
I'm back from PTO. This looks obviously correct to me.
jeff
prev parent reply other threads:[~2022-07-30 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-29 8:47 Richard Biener
2022-07-30 15:31 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35d1df93-134c-43ed-6d8d-d3ad9cf26c66@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).