From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CBBF3858400 for ; Thu, 22 Sep 2022 19:00:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4CBBF3858400 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663873234; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q9jcDor9udpn1yLfD6osPFEGPymjGpENs6e98L6SQVs=; b=KbigNXcejf5tQBr7ycO/RihNiNaNX5GqKBmRvPc5/jef4xrqRcXx7hlz9YN53TbGVWwyQ3 HsJnRA3vsFPgDjfTHnGrlThQZwRtpEqlmYSGU4veI7ev/4ImOPO/BPnC8gsomwG1mkMBlL Q//p1EIdhBa4se88IBOSIFOOXwbsWjA= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-114-a3M6QIedP6GatNpJI3MnBQ-1; Thu, 22 Sep 2022 15:00:31 -0400 X-MC-Unique: a3M6QIedP6GatNpJI3MnBQ-1 Received: by mail-il1-f200.google.com with SMTP id k3-20020a056e02156300b002f5623faa62so6247685ilu.0 for ; Thu, 22 Sep 2022 12:00:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date; bh=lDKFnSHxu1YlwOOfaG35eg/oUUBm3ZcoQ+S4wNGrQcU=; b=Y/ja2bA9Xf+1IWh1hMwDqpFjss+S1PUjQ+cczHJWappi+sEI1fTuKuOoVjUhGEMjCY gJn1rScyan0k/f8jFBIOsfNgo90dJyBxS8C2fqDO6A/K1Ob86FLwn+As3cdTsJALTUf7 pQsmTk0/DMjmN2wgrBUuzMvZD0EHsd0+dekfP7m19xUCLsV9ZVDBbWkulzYIVXMyrFE4 rSBgm4b0yZiJYl3qwqLrjVVKbslKWn3cDCMIVVyFYnwS0vojW4ulNBcWpc5MeFA1JWt9 qaJCpVNAbcnjWSTsPEPOnTCKQ3Yd/RIW6QvmXMWA95cZAiLUoXmeESZKoxrynfKPo4Y4 uVXQ== X-Gm-Message-State: ACrzQf2RwBNv48M2MdNFzbaFeWQ/0916dUtSSRs3ovfbWLeWrUW6Kfn+ 0jgkwsCXlrTn5shgcpCWLZeSzAEXvrW5zvrnm45qcV5BM43K/lfBc/saMG1tH2zt3tRekNyKPBQ 4xzBICXCL3J/6+iWtjZ6XgTc7vTXF3UNyA1dRswBbsjEYtDmUYQQdJVgodIX9synCfR7Dvw== X-Received: by 2002:a92:c266:0:b0:2f5:f5eb:3510 with SMTP id h6-20020a92c266000000b002f5f5eb3510mr2413049ild.24.1663873229801; Thu, 22 Sep 2022 12:00:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Db7OZaf6LxVQ/b+5O7XY0yGJKwzF6p2qrrxwoKNRyS45HyaBaD4SI831bylntXBubeAi/sw== X-Received: by 2002:a92:c266:0:b0:2f5:f5eb:3510 with SMTP id h6-20020a92c266000000b002f5f5eb3510mr2413037ild.24.1663873229591; Thu, 22 Sep 2022 12:00:29 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::3dbe? ([2607:fea8:a263:f600::3dbe]) by smtp.gmail.com with ESMTPSA id n17-20020a027151000000b0034c14a6ea76sm2463362jaf.51.2022.09.22.12.00.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 12:00:28 -0700 (PDT) Message-ID: <35eb7b99-9e99-dded-2dbc-1bc400df0a48@redhat.com> Date: Thu, 22 Sep 2022 15:00:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: [PATCH 06/17] Always check the return value of fold_range. From: Andrew MacLeod To: gcc-patches Cc: "hernandez, aldy" References: <571782f9-72e6-5c30-da55-b8d62d3a153e@redhat.com> In-Reply-To: <571782f9-72e6-5c30-da55-b8d62d3a153e@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------1YsIao7JefEOMexDijn24qrK" Content-Language: en-US X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------1YsIao7JefEOMexDijn24qrK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit The fold_range routine in range-ops returns FALSE if the operation fails.  There are a few places which assume the operation was successful.  Fix those. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew --------------1YsIao7JefEOMexDijn24qrK Content-Type: text/x-patch; charset=UTF-8; name="0006-Always-check-the-return-value-of-fold_range.patch" Content-Disposition: attachment; filename="0006-Always-check-the-return-value-of-fold_range.patch" Content-Transfer-Encoding: base64 RnJvbSAyZjkyZjY4NWRhMmVmOWU4MmVlNjI2MjUxOTkxOTE4MGRmOGYyZGQ5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogV2VkLCAyMSBTZXAgMjAyMiAxNjoxNTowMiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMDYv MTddIEFsd2F5cyBjaGVjayB0aGUgcmV0dXJuIHZhbHVlIG9mIGZvbGRfcmFuZ2UuCgpUaGUgZm9s ZF9yYW5nZSByb3V0aW5lIGluIHJhbmdlLW9wcyByZXR1cm5zIEZBTFNFIGlmIHRoZSBvcGVyYXRp b24KZmFpbHMuICBUaGVyZSBhcmUgYSBmZXcgcGxhY2VzIHdoaWNoIGFzc3VtZSB0aGUgb3BlcmF0 aW9uIHdhcwpzdWNjZXNzZnVsLiAgRml4IHRob3NlLgoKCSogZ2ltcGxlLXJhbmdlLWZvbGQuY2Mg KHJhbmdlX29mX3JhbmdlX29wKTogU2V0IHJlc3VsdCB0bwoJVkFSWUlORyBpZiB0aGUgY2FsbCB0 byBmb2xkX3JhbmdlIGZhaWxzLgoJKiB0cmVlLWRhdGEtcmVmLmNjIChjb21wdXRlX2Rpc3RyaWJ1 dGl2ZV9yYW5nZSk6IERpdHRvLgoJKiB0cmVlLXZycC5jYyAocmFuZ2VfZm9sZF9iaW5hcnlfZXhw cik6IERpdHRvLgoJKHJhbmdlX2ZvbGRfdW5hcnlfZXhwcik6IERpdHRvLgoJKiB2YWx1ZS1xdWVy eS5jYyAocmFuZ2VfcXVlcnk6OmdldF90cmVlX3JhbmdlKTogRGl0dG8uCi0tLQogZ2NjL2dpbXBs ZS1yYW5nZS1mb2xkLmNjIHwgNiArKysrLS0KIGdjYy90cmVlLWRhdGEtcmVmLmNjICAgICB8IDYg KysrKy0tCiBnY2MvdHJlZS12cnAuY2MgICAgICAgICAgfCA2ICsrKystLQogZ2NjL3ZhbHVlLXF1 ZXJ5LmNjICAgICAgIHwgNiArKysrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygr KSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9nY2MvZ2ltcGxlLXJhbmdlLWZvbGQuY2Mg Yi9nY2MvZ2ltcGxlLXJhbmdlLWZvbGQuY2MKaW5kZXggYWRkZjNlN2YyNTQuLjQyNDA4MjU0YzM1 IDEwMDY0NAotLS0gYS9nY2MvZ2ltcGxlLXJhbmdlLWZvbGQuY2MKKysrIGIvZ2NjL2dpbXBsZS1y YW5nZS1mb2xkLmNjCkBAIC01NDQsNyArNTQ0LDggQEAgZm9sZF91c2luZ19yYW5nZTo6cmFuZ2Vf b2ZfcmFuZ2Vfb3AgKHZyYW5nZSAmciwKIAkgIC8vIEZvbGQgcmFuZ2UsIGFuZCByZWdpc3RlciBh bnkgZGVwZW5kZW5jeSBpZiBhdmFpbGFibGUuCiAJICBWYWx1ZV9SYW5nZSByMiAodHlwZSk7CiAJ ICByMi5zZXRfdmFyeWluZyAodHlwZSk7Ci0JICBoYW5kbGVyLmZvbGRfcmFuZ2UgKHIsIHR5cGUs IHJhbmdlMSwgcjIpOworCSAgaWYgKCFoYW5kbGVyLmZvbGRfcmFuZ2UgKHIsIHR5cGUsIHJhbmdl MSwgcjIpKQorCSAgICByLnNldF92YXJ5aW5nICh0eXBlKTsKIAkgIGlmIChsaHMgJiYgZ2ltcGxl X3JhbmdlX3NzYV9wIChvcDEpKQogCSAgICB7CiAJICAgICAgaWYgKHNyYy5nb3JpICgpKQpAQCAt NTY3LDcgKzU2OCw4IEBAIGZvbGRfdXNpbmdfcmFuZ2U6OnJhbmdlX29mX3JhbmdlX29wICh2cmFu Z2UgJnIsCiAJICAgICAgZnB1dGMgKCdcbicsIGR1bXBfZmlsZSk7CiAJICAgIH0KIAkgIC8vIEZv bGQgcmFuZ2UsIGFuZCByZWdpc3RlciBhbnkgZGVwZW5kZW5jeSBpZiBhdmFpbGFibGUuCi0JICBo YW5kbGVyLmZvbGRfcmFuZ2UgKHIsIHR5cGUsIHJhbmdlMSwgcmFuZ2UyLCByZWwpOworCSAgaWYg KCFoYW5kbGVyLmZvbGRfcmFuZ2UgKHIsIHR5cGUsIHJhbmdlMSwgcmFuZ2UyLCByZWwpKQorCSAg ICByLnNldF92YXJ5aW5nICh0eXBlKTsKIAkgIGlmIChpcmFuZ2U6OnN1cHBvcnRzX3AgKHR5cGUp KQogCSAgICByZWxhdGlvbl9mb2xkX2FuZF9vciAoYXNfYSA8aXJhbmdlPiAociksIHMsIHNyYyk7 CiAJICBpZiAobGhzKQpkaWZmIC0tZ2l0IGEvZ2NjL3RyZWUtZGF0YS1yZWYuY2MgYi9nY2MvdHJl ZS1kYXRhLXJlZi5jYwppbmRleCBmZjkzMjdmNmRlYi4uOTFiZmI2MTlkNjYgMTAwNjQ0Ci0tLSBh L2djYy90cmVlLWRhdGEtcmVmLmNjCisrKyBiL2djYy90cmVlLWRhdGEtcmVmLmNjCkBAIC01OTQs NyArNTk0LDggQEAgY29tcHV0ZV9kaXN0cmlidXRpdmVfcmFuZ2UgKHRyZWUgdHlwZSwgdmFsdWVf cmFuZ2UgJm9wMF9yYW5nZSwKICAgaWYgKHJlc3VsdF9yYW5nZSkKICAgICB7CiAgICAgICByYW5n ZV9vcF9oYW5kbGVyIG9wIChjb2RlLCB0eXBlKTsKLSAgICAgIG9wLmZvbGRfcmFuZ2UgKCpyZXN1 bHRfcmFuZ2UsIHR5cGUsIG9wMF9yYW5nZSwgb3AxX3JhbmdlKTsKKyAgICAgIGlmICghb3AuZm9s ZF9yYW5nZSAoKnJlc3VsdF9yYW5nZSwgdHlwZSwgb3AwX3JhbmdlLCBvcDFfcmFuZ2UpKQorCXJl c3VsdF9yYW5nZS0+c2V0X3ZhcnlpbmcgKHR5cGUpOwogICAgIH0KIAogICAvKiBUaGUgZGlzdHJp YnV0aXZlIHByb3BlcnR5IGd1YXJhbnRlZXMgdGhhdCBpZiBUWVBFIGlzIG5vIG5hcnJvd2VyCkBA IC02NDIsNyArNjQzLDggQEAgY29tcHV0ZV9kaXN0cmlidXRpdmVfcmFuZ2UgKHRyZWUgdHlwZSwg dmFsdWVfcmFuZ2UgJm9wMF9yYW5nZSwKICAgcmFuZ2Vfb3BfaGFuZGxlciBvcCAoY29kZSwgc3Np emV0eXBlKTsKICAgYm9vbCBzYXZlZF9mbGFnX3dyYXB2ID0gZmxhZ193cmFwdjsKICAgZmxhZ193 cmFwdiA9IDE7Ci0gIG9wLmZvbGRfcmFuZ2UgKHdpZGVfcmFuZ2UsIHNzaXpldHlwZSwgb3AwX3Jh bmdlLCBvcDFfcmFuZ2UpOworICBpZiAoIW9wLmZvbGRfcmFuZ2UgKHdpZGVfcmFuZ2UsIHNzaXpl dHlwZSwgb3AwX3JhbmdlLCBvcDFfcmFuZ2UpKQorICAgIHdpZGVfcmFuZ2Uuc2V0X3Zhcnlpbmcg KHNzaXpldHlwZSk7OwogICBmbGFnX3dyYXB2ID0gc2F2ZWRfZmxhZ193cmFwdjsKICAgaWYgKHdp ZGVfcmFuZ2UubnVtX3BhaXJzICgpICE9IDEgfHwgIXJhbmdlX2ludF9jc3RfcCAoJndpZGVfcmFu Z2UpKQogICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL2djYy90cmVlLXZycC5jYyBiL2dj Yy90cmVlLXZycC5jYwppbmRleCBjMzAzMGExYjEzMC4uOTM0ODJlNWQxMDIgMTAwNjQ0Ci0tLSBh L2djYy90cmVlLXZycC5jYworKysgYi9nY2MvdHJlZS12cnAuY2MKQEAgLTEwNjksNyArMTA2OSw4 IEBAIHJhbmdlX2ZvbGRfYmluYXJ5X2V4cHIgKHZhbHVlX3JhbmdlICp2ciwKICAgICB2cjEuc2V0 X3ZhcnlpbmcgKGV4cHJfdHlwZSk7CiAgIHZyMC5ub3JtYWxpemVfYWRkcmVzc2VzICgpOwogICB2 cjEubm9ybWFsaXplX2FkZHJlc3NlcyAoKTsKLSAgb3AuZm9sZF9yYW5nZSAoKnZyLCBleHByX3R5 cGUsIHZyMCwgdnIxKTsKKyAgaWYgKCFvcC5mb2xkX3JhbmdlICgqdnIsIGV4cHJfdHlwZSwgdnIw LCB2cjEpKQorICAgIHZyLT5zZXRfdmFyeWluZyAoZXhwcl90eXBlKTsKIH0KIAogLyogUGVyZm9y bSBhIHVuYXJ5IG9wZXJhdGlvbiBvbiBhIHJhbmdlLiAgKi8KQEAgLTEwOTUsNyArMTA5Niw4IEBA IHJhbmdlX2ZvbGRfdW5hcnlfZXhwciAodmFsdWVfcmFuZ2UgKnZyLAogCiAgIHZhbHVlX3Jhbmdl IHZyMF9jc3QgKCp2cjApOwogICB2cjBfY3N0Lm5vcm1hbGl6ZV9hZGRyZXNzZXMgKCk7Ci0gIG9w LmZvbGRfcmFuZ2UgKCp2ciwgZXhwcl90eXBlLCB2cjBfY3N0LCB2YWx1ZV9yYW5nZSAoZXhwcl90 eXBlKSk7CisgIGlmICghb3AuZm9sZF9yYW5nZSAoKnZyLCBleHByX3R5cGUsIHZyMF9jc3QsIHZh bHVlX3JhbmdlIChleHByX3R5cGUpKSkKKyAgICB2ci0+c2V0X3ZhcnlpbmcgKGV4cHJfdHlwZSk7 CiB9CiAKIC8qIElmIHRoZSByYW5nZSBvZiB2YWx1ZXMgdGFrZW4gYnkgT1AgY2FuIGJlIGluZmVy cmVkIGFmdGVyIFNUTVQgZXhlY3V0ZXMsCmRpZmYgLS1naXQgYS9nY2MvdmFsdWUtcXVlcnkuY2Mg Yi9nY2MvdmFsdWUtcXVlcnkuY2MKaW5kZXggMGJkZDY3MDk4MmIuLjI5Njc4NGJlMzFkIDEwMDY0 NAotLS0gYS9nY2MvdmFsdWUtcXVlcnkuY2MKKysrIGIvZ2NjL3ZhbHVlLXF1ZXJ5LmNjCkBAIC0y NTIsNyArMjUyLDggQEAgcmFuZ2VfcXVlcnk6OmdldF90cmVlX3JhbmdlICh2cmFuZ2UgJnIsIHRy ZWUgZXhwciwgZ2ltcGxlICpzdG10KQogCSAgVmFsdWVfUmFuZ2UgcjEgKFRSRUVfVFlQRSAoVFJF RV9PUEVSQU5EIChleHByLCAxKSkpOwogCSAgcmFuZ2Vfb2ZfZXhwciAocjAsIFRSRUVfT1BFUkFO RCAoZXhwciwgMCksIHN0bXQpOwogCSAgcmFuZ2Vfb2ZfZXhwciAocjEsIFRSRUVfT1BFUkFORCAo ZXhwciwgMSksIHN0bXQpOwotCSAgb3AuZm9sZF9yYW5nZSAociwgdHlwZSwgcjAsIHIxKTsKKwkg IGlmICghb3AuZm9sZF9yYW5nZSAociwgdHlwZSwgcjAsIHIxKSkKKwkgICAgci5zZXRfdmFyeWlu ZyAodHlwZSk7CiAJfQogICAgICAgZWxzZQogCXIuc2V0X3ZhcnlpbmcgKHR5cGUpOwpAQCAtMjY4 LDcgKzI2OSw4IEBAIHJhbmdlX3F1ZXJ5OjpnZXRfdHJlZV9yYW5nZSAodnJhbmdlICZyLCB0cmVl IGV4cHIsIGdpbXBsZSAqc3RtdCkKIAkgIFZhbHVlX1JhbmdlIHIxICh0eXBlKTsKIAkgIHIxLnNl dF92YXJ5aW5nICh0eXBlKTsKIAkgIHJhbmdlX29mX2V4cHIgKHIwLCBUUkVFX09QRVJBTkQgKGV4 cHIsIDApLCBzdG10KTsKLQkgIG9wLmZvbGRfcmFuZ2UgKHIsIHR5cGUsIHIwLCByMSk7CisJICBp ZiAoIW9wLmZvbGRfcmFuZ2UgKHIsIHR5cGUsIHIwLCByMSkpCisJICAgIHIuc2V0X3Zhcnlpbmcg KHR5cGUpOwogCX0KICAgICAgIGVsc2UKIAlyLnNldF92YXJ5aW5nICh0eXBlKTsKLS0gCjIuMzcu MwoK --------------1YsIao7JefEOMexDijn24qrK--