From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17542 invoked by alias); 31 Aug 2017 02:52:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17495 invoked by uid 89); 31 Aug 2017 02:52:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:2435 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Aug 2017 02:52:27 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B6F9EC0587D1; Thu, 31 Aug 2017 02:52:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B6F9EC0587D1 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=law@redhat.com Received: from localhost.localdomain (ovpn-112-17.rdu2.redhat.com [10.10.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 27C2694AD4; Thu, 31 Aug 2017 02:52:24 +0000 (UTC) Subject: Re: Improve DOM's ability to derive equivalences when traversing edges To: Christophe Lyon Cc: gcc-patches References: <6eee6bd5-cb64-925f-dfcd-e0dbdfbb835d@redhat.com> From: Jeff Law Message-ID: <361a4c24-180d-ea48-0117-e1e24d71a4ba@redhat.com> Date: Thu, 31 Aug 2017 09:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg01759.txt.bz2 On 08/29/2017 09:42 AM, Christophe Lyon wrote: > On 29 August 2017 at 17:28, Jeff Law wrote: >> On 08/29/2017 03:13 AM, Christophe Lyon wrote: >>> Hi Jeff, >> [ ... ] >>>> >>>> commit a370df2c52074abbb044d1921a0c7df235758050 >>>> Author: law >>>> Date: Tue Aug 29 05:03:36 2017 +0000 >>>> >>>> * tree-ssa-dom.c (edge_info::record_simple_equiv): Call >>>> derive_equivalences. >>>> (derive_equivalences_from_bit_ior, record_temporary_equivalences): >>>> Code moved into.... >>>> (edge_info::derive_equivalences): New private member function >>>> >>>> * gcc.dg/torture/pr57214.c: Fix type of loop counter. >>>> * gcc.dg/tree-ssa/ssa-sink-16.c: Disable DOM. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-11.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-12.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-13.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-14.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-15.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-16.c: New test. >>>> * gcc.dg/tree-ssa/ssa-dom-thread-17.c: New test. >>>> >>>> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@251397 138bc75d-0d04-0410-961f-82ee72b054a4 >>>> >>> >>> 3 of the new tests fail on arm-none-linux-gnueabihf >>> --with-cpu=cortex-a15 --with-fpu=vfpv3-d16-fp16 >>> >>> FAIL: gcc.dg/tree-ssa/ssa-dom-thread-11.c scan-tree-dump-times dom2 >>> "Threaded" 1 >>> FAIL: gcc.dg/tree-ssa/ssa-dom-thread-14.c scan-tree-dump-times dom2 >>> "Threaded" 1 >>> FAIL: gcc.dg/tree-ssa/ssa-dom-thread-16.c scan-tree-dump-times dom2 >>> "Threaded" 1 >>> >>> they do pass when configuring for cpu cortex-a9/a15 and fpu neon-fp16/neon-vfpv4 >>> >>> I do not have the dumps since it's automated testing; let me know if >>> you need me to >>> reproduce it manually and extract the dumps. >> Strange. I can't reproduce this. >> >> /home/law/gcc-testing/gcc2/configure --target=arm-none-linux-gnueabihf >> --with-cpu=cortex-a15 --with-fpu=vfpv3-d16-fp16 >> > > Sorry, it was a typo: I meant cortex-a5. Ah. I see it now. Isn't this really an indicator that the ARM test in check_effective_target_logical_op_short_circuit is wrong? AFAICT that test just looks to see if a particular preprocessor symbol is defined. WOuldn't it be better to check the output of -mprint-tune-info which should make the test DTRT in all situations? jeff