From: Aldy Hernandez <aldyh@redhat.com>
To: Jeff Law <law@redhat.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [committed][PATCH] Change order of processing blocks/threads in tree-ssa-threadupdate.c
Date: Wed, 15 Nov 2017 08:21:00 -0000 [thread overview]
Message-ID: <36298f9c-5ddb-6146-054a-0cda028a327c@redhat.com> (raw)
In-Reply-To: <f43c1f86-4003-ceef-f5ab-56ba1e0f479c@redhat.com>
On 11/14/2017 10:46 PM, Jeff Law wrote:
> With my local patches to remove jump threading from VRP I was seeing a
> fairly obvious jump threading path left in the CFG after DOM. This
> missed jump thread ultimately caused a false positive uninitialized warning.
This wouldn't be uninit-pred-[68]* or some such, which I also trigger
when messing around with the backwards threader ??.
> ping-ponging, but not due to this patch AFAICT. Also verified by visual
> inspection that the first DOM pass fully threaded the code in question
> when using a local branch that has my removal of threading from tree-vrp
> patches installed and bootstrapping that branch.
If DOM dumps the threads to the dump file you may want to bake that test
with some GIMPLE FE test.
> Installing on the trunk.
You forgot to attach the patch :).
Aldy
next prev parent reply other threads:[~2017-11-15 7:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 6:17 Jeff Law
2017-11-15 8:21 ` Aldy Hernandez [this message]
2017-11-16 17:55 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36298f9c-5ddb-6146-054a-0cda028a327c@redhat.com \
--to=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).