From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72884 invoked by alias); 7 Jul 2018 22:36:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72872 invoked by uid 89); 7 Jul 2018 22:36:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=forces, clue X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Jul 2018 22:36:04 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 955398139F; Sun, 8 Jul 2018 00:36:02 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eamnfZbsWP8I; Sun, 8 Jul 2018 00:36:02 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 5B9BC81398; Sun, 8 Jul 2018 00:36:02 +0200 (CEST) From: Eric Botcazou To: Jim Wilson Cc: GCC Patches , Pierre-Marie de Rodat Subject: Re: [PATCH, Ada] RISC-V: Initial riscv linux Ada port. Date: Sat, 07 Jul 2018 22:36:00 -0000 Message-ID: <3639449.hfrN8MdEsi@polaris> In-Reply-To: References: <20180705234444.5935-1-jimw@sifive.com> <3040525.m4Pn2gu4gY@polaris> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2018-07/txt/msg00381.txt.bz2 > I haven't tried looking at the failures yet, and might not spend much > more time on this. Two of them are debug related, and debug support > is a work in progress. I need to finish the native riscv64-linux > support before we can do anything useful there, and I'd like to get > back to working on that as soon as possible. No clue about debug11.adb, maybe Pierre-Marie could shed some light on it. > The GNU-stack error looks a little worrisome. I'd expect a linux port to > get GNU-stack stuff right without much trouble. The test checks that -ftrampolines forces the use of trampolines instead of descriptors. If trampolines are generated on the stack for RISC-V, then the stack should be made executable when there are built. Otherwise you can add the appropriate triplet to the dg-skip-if line. In any case, that's benign since trampolines are not generated by default now. > The last one is warn5.adb:29:30: warning: source alignment (4) < alignment > of "Element_Type" (8) Maybe something I copied from the mips linux port is > wrong for riscv64 linux. No, this looks as expected, you just need to add the appropriate triplet to the list on line 29 when you have 15 seconds to kill. Patchlet preapproved. -- Eric Botcazou