From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id 463FA385B510 for ; Tue, 11 Jun 2024 18:21:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 463FA385B510 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 463FA385B510 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::635 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718130113; cv=none; b=wmPTaHW+5zeYxaDTF2FzCps98hwe+1yj4GNS2HJlYxgKMgJ+B7/ScDpWe4zsNLwyBjAvSCD1BrZTA71+MEMec1tEAjGdcCWXOYJWoUOqIcsypyQV4SyXkWRdERhtsz6gfSBJP20zfx4q4G0NEksJV8scKxBpJxSbQdVvdTLZg/I= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718130113; c=relaxed/simple; bh=fHSjTMTyODtTmrr81vw1S+K8k48B9KJemhkEIMt5+UE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:From:To; b=DClrm8qb5LdE60zWqV1VhH+0G9VuDkKx5WEDqaL8rrxKukXWWE3PXFd9wqJWoGh2GGYa7PCBr5DJptp+B5XCS1fBAKRjzVvH5xpzwH1vGUe7NUu9mScemTWwY/BGlddZgOp3AkxuorQ4Suof+xeWxjQ3Js472ZpP1aJ+v14oJJI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1f70509b811so20604245ad.1 for ; Tue, 11 Jun 2024 11:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1718130110; x=1718734910; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=SG77Mltcea+HB9RPGsmi+ZMzFa/3EKb7QRCqPhTCiUE=; b=1xBNFepWwLtPP76twsjGBvDDPavRJKzGrrrK+y15Cmr6JeOgWW/tVms+J8igwnhEOs KjYFZSV79urZY4Vqz+YJiqrfiCsu8XIjoHTvY3/pbxaT4YW8561mYASCidA7cnchbdE9 VBzhMOo/3aTJkhPWrtMntcLN/HDji6hZQdXBzhyLV4TFNgqCBBSWDq3V784NrTXjZt9p 4erKD15ao4pESG94bslj6VXVZBeAtoVgjjEzFl1LJ8FAcjN/QiOj9rHsAG9xQBUoMV56 B3ixXYoHKVxV6WdONzECzQvCcLovPHvwPVPq87Q5PfNdSfCi3mXew7kYQzG23RdEbNH4 oOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718130110; x=1718734910; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SG77Mltcea+HB9RPGsmi+ZMzFa/3EKb7QRCqPhTCiUE=; b=FgySPiUoSEWXy10WsW39jcuIhzynIicy2xMOYFpoSdfWTbdBNAW1T7IPyy27upJ4Zi jammpDuYK+ejYGTATLkCNjUI1PGan0efNpmxtOWSx4k5tH15013Ke4OkjLCXlz7Zs+Y1 us9YR7amIMAARmpJ73pih5WHgcU44b6sWj8iUezRxZ27GZ2a60qPxZuD+qBOwjC91plM GhBTqyohofE4sz8YULtbiLC+YlC5ZCRXPXqge3CmVugK8hLc2LIeXJX4y/8cYGX/2PVA 2pUSYQdDFMTcaEfZ0QlWeGi3adqu0igtyeJ64r5rYy6WQch+mCyYttQXjZOv1YM+ZFEr F39g== X-Forwarded-Encrypted: i=1; AJvYcCV9Q09dWyZylYT0qduWhrHs110TaJskmFHFaeodTwBVytsRnZPwfCgeyAtz4bekdO5GaEBAJq4mxJA2C+0c4po8paRLi+JSPQ== X-Gm-Message-State: AOJu0YzTN9kVBMVI7YaKRfNbig4JWInLqGfdi5/BulyfqB/w2sOvs5jS 0taMOLSZPKu2h876WM8xpDl8Pse7GPSR3rNzpQO0WHATODsWXH5LD7Vscfwh7bK/Q91Dt/XGKXU 6 X-Google-Smtp-Source: AGHT+IFR9ar0jGYGYAVZ0vcjkvIvFwU19Ezx10yCubhu/G6BTNCTTtMsi+nyCC/cuc7ukiCUDOvqEw== X-Received: by 2002:a17:903:245:b0:1f4:5ad1:b65e with SMTP id d9443c01a7336-1f6d02f4821mr130990035ad.34.1718130110204; Tue, 11 Jun 2024 11:21:50 -0700 (PDT) Received: from [10.0.17.156] ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f734bf0ab7sm16150745ad.91.2024.06.11.11.21.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 11:21:49 -0700 (PDT) Message-ID: <3648a2ea-eed1-42cb-9d36-dd0cb2f8a23d@rivosinc.com> Date: Tue, 11 Jun 2024 11:21:47 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] RISC-V: Add Zalrsc and Zaamo testsuite support From: Patrick O'Neill To: Jeff Law , gcc-patches@gcc.gnu.org Cc: palmer@dabbelt.com, gnu-toolchain@rivosinc.com References: <20240603215329.2664893-1-patrick@rivosinc.com> <20240603215329.2664893-3-patrick@rivosinc.com> <1b8c5ee3-3f1b-4925-b421-4bb7033a6151@gmail.com> <99e38b66-f17a-4640-8a7f-0cc82cca50fe@rivosinc.com> Content-Language: en-US In-Reply-To: <99e38b66-f17a-4640-8a7f-0cc82cca50fe@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/10/24 09:39, Patrick O'Neill wrote: > > On 6/7/24 16:04, Jeff Law wrote: >> >> >> On 6/3/24 3:53 PM, Patrick O'Neill wrote: >>> Convert testsuite infrastructure to use Zalrsc and Zaamo rather than A. >>> >>> gcc/testsuite/ChangeLog: >>> >>>     * gcc.target/riscv/amo-table-a-6-amo-add-1.c: Use Zaamo rather >>> than A. >>>     * gcc.target/riscv/amo-table-a-6-amo-add-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-amo-add-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-amo-add-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-amo-add-5.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-1.c: Use >>> Zalrsc rather >>>     than A. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-5.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-6.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-compare-exchange-7.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-1.c: Use Zaamo >>> rather >>>     than A. >>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-a-6-subword-amo-add-5.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-amo-add-1.c: Add Zaamo option. >>>     * gcc.target/riscv/amo-table-ztso-amo-add-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-amo-add-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-amo-add-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-amo-add-5.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-1.c: Use >>> Zalrsc rather >>>     than A. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-5.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-6.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-compare-exchange-7.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-1.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-2.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-3.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-4.c: Ditto. >>>     * gcc.target/riscv/amo-table-ztso-subword-amo-add-5.c: Ditto. >>>     * lib/target-supports.exp: Add testsuite infrastructure support for >>>     Zaamo and Zalrsc. >> So there's a lot of whitespace changes going on in >> target-supports.exp that make it harder to find the real changes. >> >> There's always a bit of a judgement call for that kind of thing. This >> one probably goes past would generally recommend, meaning that the >> formatting stuff would be a separate patch. >> >> A reasonable starting point would be if you're not changing the >> function in question, then fixing formatting in it probably should be >> a distinct patch. [... snip ...] > I'll split the target-supports.exp trailing whitespace removal into a > separate patch after this series lands. I made the whitespace cleanup patch (trailing whitespace, leading groups of 8 spaces -> tabs) for target-supports.exp and got a diff of 584 lines. Is this still worth doing or will it be too disruptive for rebasing/other people's development? Patrick