From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id C05003858C31 for ; Thu, 23 Mar 2023 12:38:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C05003858C31 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32NB1Kd4036887; Thu, 23 Mar 2023 12:38:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=S3NBzYMCp/i23qZZC+8zf1xu8AVtCZTe4XkBpNuov3s=; b=ah3KO10BBcCe7LZxdqOF6UaT3nGMnFkOznnsv1FTSNyKiWt/LU1JNtV4meYxQnK82bbD BbYXRvdu7ttfcvINFCuxFKCcSB529FGfXM0YtEA+LIaEXMW840O1ygO1al1dR9uKYINr PkxuChjQNsLzrwtbQ7xE9W2yH/qt518ffj+RCUWYVrbC0lmgX2SaQR9YKQkv/D0kyP+m sdXUQa1sDxMO0wW+LU1Oxis/J7YBatCO2OFLbnpZWEIoywwI48Tddqhh7s/UzmlXqei4 w0VQGGLtkUsJ148pMEGg4GJ4OCvJ9cSog7SPCyH+acS2WXrH/K9sMdEjrd98BzW4Q81v cw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pggv7h75s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 12:38:44 +0000 Received: from m0127361.ppops.net (m0127361.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 32NCU4dL000856; Thu, 23 Mar 2023 12:38:44 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3pggv7h75e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 12:38:44 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32N95NLt030093; Thu, 23 Mar 2023 12:38:43 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([9.208.129.120]) by ppma02wdc.us.ibm.com (PPS) with ESMTPS id 3pd4x7dvb4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 12:38:43 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 32NCcfaB18547390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Mar 2023 12:38:42 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CB33E5805A; Thu, 23 Mar 2023 12:38:41 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 56B7358051; Thu, 23 Mar 2023 12:38:41 +0000 (GMT) Received: from [9.211.90.110] (unknown [9.211.90.110]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 23 Mar 2023 12:38:41 +0000 (GMT) Message-ID: <365cfb50-4313-d44e-6ffc-77473b20c670@linux.ibm.com> Date: Thu, 23 Mar 2023 07:38:40 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] rtl-optimization: ppc backend generates unnecessary signed extension. Content-Language: en-US To: Ajit Agarwal , gcc-patches Cc: Segher Boessenkool , Jeff Law , Richard Biener References: <4c0b6b4f-bbc1-8dd0-a91c-ffed028b4873@linux.ibm.com> From: Peter Bergner In-Reply-To: <4c0b6b4f-bbc1-8dd0-a91c-ffed028b4873@linux.ibm.com> Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kL9dzgQ2ujREZadGf7Rtvs5LrkUVvZMz X-Proofpoint-GUID: PWyP6zN9ZpsBI8oWRUxM5eGa2m59kihK Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 phishscore=0 clxscore=1015 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303230094 X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/23/23 5:38 AM, Ajit Agarwal wrote: > This patch removed unnecessary signed extension elimination in ree pass. > Bootstrapped and regtested on powerpc64-linux-gnu. > > > Thanks & Regards > Ajit > > rtl-optimization: ppc backend generates unnecessary signed extension. > > Eliminate unnecessary redundant signed extension. > > 2023-03-23 Ajit Kumar Agarwal > > gcc/ChangeLog: > > * ree.cc: Modification for AND opcode support to eliminate > unnecessary signed extension. > * testsuite/g++.target/powerpc/sext-elim.C: New tests. Not a review of the patch, but we talked offline about other bugzillas regarding unnecessary sign and zero extensions. Doing a quick scan, I see the following bugs. Please have a look at 1) whether these are still a problem with unpatched trunk, and if they are, 2) whether your patch fixes them or could fix them. Thanks. https://gcc.gnu.org/PR41742 https://gcc.gnu.org/PR65010 https://gcc.gnu.org/PR82940 https://gcc.gnu.org/PR107949 Peter