From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110274 invoked by alias); 27 Dec 2017 09:16:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 109826 invoked by uid 89); 27 Dec 2017 09:16:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=CUDA X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Dec 2017 09:16:18 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-04.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1eU7os-0002aC-96 from Tom_deVries@mentor.com for gcc-patches@gcc.gnu.org; Wed, 27 Dec 2017 01:16:14 -0800 Received: from [172.30.72.108] (137.202.0.87) by SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Wed, 27 Dec 2017 09:16:11 +0000 Subject: Re: [PATCH,PTX] Add support for CUDA 9 To: Cesar Philippidis CC: "gcc-patches@gcc.gnu.org" References: <002bf03f-baad-5809-6e9a-2fdffa0c1e2c@codesourcery.com> <19831d57-118f-1ef7-b360-0dc0ba905688@codesourcery.com> From: Tom de Vries Message-ID: <3693480e-a616-2233-2542-0403afbab7fa@mentor.com> Date: Wed, 27 Dec 2017 09:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <19831d57-118f-1ef7-b360-0dc0ba905688@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To SVR-IES-MBX-04.mgc.mentorg.com (139.181.222.4) X-SW-Source: 2017-12/txt/msg01536.txt.bz2 On 12/21/2017 06:19 PM, Cesar Philippidis wrote: > My test results are somewhat inconsistent. On MG's build servers, there > are no regressions in CUDA 8. Ack. > On my laptop, there are fewer regressions > in CUDA 9, than CUDA 8. If the patch causes regressions for either cuda 8 or cuda 9, then they need to be analyzed and fixed. Please clarify what you think it means if in one case there are less regressions than in the other. > However, I think some of those failures are due > to premature timeouts on my laptop (I'm setting dejagnu to timeout after > 90s instead of 5m locally). If you have flawed test results due to a local change you made, you need to undo the local change and rerun the test, and report the sane test results instead of reporting flawed test results. > I know your on vacation, so I'll commit this patch to og7. We can > revisit the patch for trunk and other backports later. If you don't have time to do the testing now, then please file a PR for this issue and attach the patch with the updates that address my comments. Thanks, - Tom