From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 05CD33854164 for ; Thu, 6 Oct 2022 11:09:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 05CD33854164 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-wr1-x429.google.com with SMTP id b4so2179584wrs.1 for ; Thu, 06 Oct 2022 04:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=8OMOljVj1g1DtvcNihTUKM0t2xBjOObJOzFrK8YQB2k=; b=XmKkYjMwRONm2H41+hZsnB7WDxF7NjgYyQtma7H6Xz43xbEzcpzlfEySHNa25r/vTX wVl/GMVEHCWJvR+34rZcz7NlFnawcdPSYv24LWbY8hyEYhWWAuv+45EBVUGUFM8Tqy3W YtJ0/Qox1tT8o+BdAwO+UolZcf7NQzZ5mpCEarmiWB2/a7uvscHdopWWKbwUWWEhCRkO XRNhkOHYJ4/qrf5ki+dVWVaSDOXWqCSJrmif++erzJsYnURs6L5+w7PcK8gHiZT1N5St PqaJrZPYW6UYioVSCS2g6boaX2swqdWPwe2aVjFo10A9uE6V7drFieF/v2xxySXtYIpQ jvCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=8OMOljVj1g1DtvcNihTUKM0t2xBjOObJOzFrK8YQB2k=; b=hXSbEiMsAaPgkiR5Q8RMZB2CiifstKkUq+q38ussIY54EtgONHCVN3JxBtCQgimxe3 2T9pJyoOP0S4WiKfrlJlr5k3YtveSgNNpoShh9trHg6zOnrsyEMHt8RjgxEfT2C2/i8i O9JBkC1M+lAAxrzM51nf9CwUe2+RLWEAVb5qqagNqcHLkYMbZR5nrbpDvcPRToguuIoS WvP7A/egKXYz9xpnzodDCeR8GLosHC+txJP6YjfPiXILJRf28z7EDaRUV5l5kSGNDdtF MvVgt/jL9+kIJoTOr4ptNJ7RG6vRAr+5Xud3DihxYivciup1esVzFGfbT/K5kLElo4Nu S6rA== X-Gm-Message-State: ACrzQf0chh0iduk6cE9+tYT7OpiD3iE46q2N22QXElu9Ub7Q4f7/ydZO cabFGGTu3Ghnwy8he6a0I5GgVQ== X-Google-Smtp-Source: AMsMyM6PQzcvPhYo2K3kQzhNjbeWsUJtCrjV1LLI9xc42ma1oC1fT9VtNAojOQwjpDb2UO5YXG3vqA== X-Received: by 2002:a05:6000:1447:b0:22a:ea42:29f7 with SMTP id v7-20020a056000144700b0022aea4229f7mr2938119wrx.38.1665054544852; Thu, 06 Oct 2022 04:09:04 -0700 (PDT) Received: from fomalhaut.localnet ([2a01:e0a:8d5:d990:e654:e8ff:fe8f:2ce6]) by smtp.gmail.com with ESMTPSA id z3-20020a5d6543000000b0022e7358df7bsm991699wrv.2.2022.10.06.04.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 04:09:04 -0700 (PDT) From: Eric Botcazou X-Google-Original-From: Eric Botcazou To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix wrong code generated by unroll-and-jam pass Date: Thu, 06 Oct 2022 13:09:03 +0200 Message-ID: <3695765.kQq0lBPeGt@fomalhaut> In-Reply-To: References: <4094054.1IzOArtZ34@fomalhaut> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > I'm wondering if testing DR_IS_WRITE (dra) is enough here and whether > the logic also applies to RAW and WAR. So should it be either > (DR_IS_WRITE (dra) || DR_IS_WRITE (drb)) or DR_IS_WRITE (dra) && > DR_IS_WRITE (drb) instead? It's a self-dependence, i.e. dra == drb in the block. Or do you mean for other dependence pairs in general? For them, I think that the code does the proper filtering in adjust_unroll_factor, but I may be wrong of course. -- Eric Botcazou