From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id EAB343838215 for ; Thu, 26 May 2022 19:38:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EAB343838215 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24QJIqlG014256; Thu, 26 May 2022 19:38:17 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gafkn8ah8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 19:38:17 +0000 Received: from m0098410.ppops.net (m0098410.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24QJKn91023018; Thu, 26 May 2022 19:38:17 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3gafkn8ah3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 19:38:17 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24QJWKe5009272; Thu, 26 May 2022 19:38:16 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma04dal.us.ibm.com with ESMTP id 3g93uuakvt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 26 May 2022 19:38:16 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24QJcF0F28574168 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 May 2022 19:38:15 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5F76AAC05E; Thu, 26 May 2022 19:38:15 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ED8DEAC05F; Thu, 26 May 2022 19:38:14 +0000 (GMT) Received: from lexx (unknown [9.160.34.81]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Thu, 26 May 2022 19:38:14 +0000 (GMT) Message-ID: <369c457246a053dc298af53a004e921a198eb4e2.camel@vnet.ibm.com> Subject: Re: [PATCH, rs6000] Clean up the option_mask defines (part 1) From: will schmidt To: Segher Boessenkool Cc: "Kewen.Lin" , GCC Patches , David Edelsohn Date: Thu, 26 May 2022 14:38:14 -0500 In-Reply-To: <20220526183114.GS25951@gate.crashing.org> References: <6591013b62270c39c912f0c13c4cd12ffbaf75a2.camel@vnet.ibm.com> <338badbf-d784-76fb-95f2-58f6aa7ffae7@linux.ibm.com> <20220526104701.GQ25951@gate.crashing.org> <181d8cba8c512a428a74ad63857b37ec3c96dd4d.camel@vnet.ibm.com> <20220526183114.GS25951@gate.crashing.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: rsy9HWvuqaSnvPx2Wbw0BiXrGp-nLEBv X-Proofpoint-ORIG-GUID: IrIAdFZWRwPAvUX-dWHUiE9h1FN36Os5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-26_10,2022-05-25_02,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 phishscore=0 adultscore=0 mlxscore=0 priorityscore=1501 mlxlogscore=656 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205260092 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 19:38:20 -0000 On Thu, 2022-05-26 at 13:31 -0500, Segher Boessenkool wrote: > > > > On Thu, May 26, 2022 at 09:40:18AM -0500, will schmidt wrote: > > On Thu, 2022-05-26 at 05:47 -0500, Segher Boessenkool wrote: > > > I'll dig a bit more, but would handle that in a separate > > patch. > > Can you please make a new patch series that just does everything? This > is so much easier to handle for everyone, even you yourself :-) Yes, willdo. Thanks -Will > > First some small preparatory patches; then the long *boring* patches > that are the meat of the matter, but are completely mechanical > (formatting notwithstanding), so are easy to review; and then some more > small patches to do final cleanup. > > So each patch will be easy to write, write a commit message for, write a > changelog for, and easy to review as well. Long patches are no problem > at all if they are completely boring! > > > Segher