From: Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
To: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>,
Ramana Radhakrishnan <ramana.gcc@googlemail.com>
Cc: Kyrill Tkachov <kyrylo.tkachov@arm.com>,
Richard Earnshaw <richard.earnshaw@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, GCC/ARM, gcc-5-branch] Fix PR80082: LDRD erronously used for 64bit load on ARMv7-R
Date: Tue, 11 Apr 2017 14:47:00 -0000 [thread overview]
Message-ID: <36a709a2-17ab-dc2b-93df-a4076c3c02f1@foss.arm.com> (raw)
In-Reply-To: <66eefa85-d2c0-4b74-fd01-db137502e61a@foss.arm.com>
On 10/04/17 13:12, Thomas Preudhomme wrote:
> Hi,
>
> Currently GCC is happy to use LDRD to perform a 64bit load on ARMv7-R,
> as shown by the testcase on this patch. However, LDRD is only atomic
> when LPAE extensions is available, which they are not for ARMv7-R. This
> commit solve the issue by introducing a new feature bit to distinguish
> LPAE extensions instead of deducing it from div instruction
> availability.
>
> ChangeLog entries are as follow:
>
> *** gcc/ChangeLog ***
>
> 2017-03-22 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> PR target/80082
> * config/arm/arm-protos.h (FL_LPAE): Define macro.
> (FL_FOR_ARCH7VE): Add FL_LPAE.
> (arm_arch_lpae): Declare extern.
> * config/arm/arm.c (arm_arch_lpae): Declare.
> (arm_option_override): Define arm_arch_lpae.
> * config/arm/arm.h (TARGET_HAVE_LPAE): Redefine in term of
> arm_arch_lpae.
>
> *** gcc/testsuite/ChangeLog ***
>
> 2017-03-22 Thomas Preud'homme <thomas.preudhomme@arm.com>
>
> PR target/80082
> * gcc.target/arm/atomic_loaddi_10.c: New testcase.
> * gcc.target/arm/atomic_loaddi_11.c: Likewise.
>
> Is this ok for gcc-5-branch?
OK.
Ramana
>
> Best regards,
>
> Thomas
>
> On 06/04/17 14:05, Ramana Radhakrishnan wrote:
>> On Mon, Mar 27, 2017 at 12:15 PM, Thomas Preudhomme
>> <thomas.preudhomme@foss.arm.com> wrote:
>>> Hi,
>>>
>>> Currently GCC is happy to use LDRD to perform a 64bit load on ARMv7-R,
>>> as shown by the testcase on this patch. However, LDRD is only atomic
>>> when LPAE extensions is available, which they are not for ARMv7-R. This
>>> commit solve the issue by introducing a new feature bit to distinguish
>>> LPAE extensions instead of deducing it from div instruction
>>> availability.
>>
>>
>> Ok but with the testsuite fix that I just approved, please also fix
>> in gcc-5 branch.
>>
>> Thanks,
>> Ramana
>>
>>>
>>> ChangeLog entries are as follow:
>>>
>>> *** gcc/ChangeLog ***
>>>
>>> 2017-03-22 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> PR target/80082
>>> * config/arm/arm-protos.h (FL_LPAE): Define macro.
>>> (FL_FOR_ARCH7VE): Add FL_LPAE.
>>> (arm_arch_lpae): Declare extern.
>>> * config/arm/arm.c (arm_arch_lpae): Declare.
>>> (arm_option_override): Define arm_arch_lpae.
>>> * config/arm/arm.h (TARGET_HAVE_LPAE): Redefine in term of
>>> arm_arch_lpae.
>>>
>>> *** gcc/testsuite/ChangeLog ***
>>>
>>> 2017-03-22 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>
>>> PR target/80082
>>> * gcc.target/arm/atomic_loaddi_10.c: New testcase.
>>> * gcc.target/arm/atomic_loaddi_11.c: Likewise.
>>>
>>>
>>> Testing: bootstrapped for -march=armv7ve and testsuite shows no
>>> regression.
>>>
>>> Is this ok for gcc-6-branch?
>>>
>>> Best regards,
>>>
>>> Thomas
prev parent reply other threads:[~2017-04-11 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 11:15 [PATCH, GCC/ARM, gcc-6-branch] " Thomas Preudhomme
2017-03-30 10:55 ` Thomas Preudhomme
2017-04-04 17:01 ` [PATCH, GCC/ARM, gcc-6-branch, ping2] " Thomas Preudhomme
2017-04-06 13:05 ` [PATCH, GCC/ARM, gcc-6-branch] " Ramana Radhakrishnan
2017-04-06 16:38 ` Thomas Preudhomme
2017-04-10 12:12 ` [PATCH, GCC/ARM, gcc-5-branch] " Thomas Preudhomme
2017-04-11 14:47 ` Ramana Radhakrishnan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36a709a2-17ab-dc2b-93df-a4076c3c02f1@foss.arm.com \
--to=ramana.radhakrishnan@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@arm.com \
--cc=ramana.gcc@googlemail.com \
--cc=richard.earnshaw@arm.com \
--cc=thomas.preudhomme@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).