From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id D90AC385223D for ; Thu, 17 Nov 2022 21:50:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D90AC385223D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-il1-x134.google.com with SMTP id r2so1619253ilg.8 for ; Thu, 17 Nov 2022 13:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=V7hBylmIWZXxm1F0Y7eJQDAYhXBpOOWssVHCbuIIgzU=; b=n43I39WZJZ1jAl7okOo4kWxCLiazrzrHv1G7WOmcUHn9KmOqS0Z+4pMhhDH+paVU5L +jt/qnOiUVcsAfJ4y8QOwfz9/FxR8vBNh/a/Kg0rWAFmVDyS1+WbyNYzY46NIBmhIE9s FhLWZ+tGP7xQXPc2DzWta3/tURVbsE/Ds+TvXoMuXUnZZ1QWEXVOEohZk2NZpTQ1aig4 JJmo/xQa/Y36JU4hEOYlEU+9NbN51EnG2oBPiqXNSDBZt8tyQ/dkOluaWq9PyEas3d1z fCMsedfQUwk3T3y1oo8J88tsLwsBNMZPULrBJsRmrm0UBmKBnNw2227iIAO9vy6YfQpI nAlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=V7hBylmIWZXxm1F0Y7eJQDAYhXBpOOWssVHCbuIIgzU=; b=q7qrIaSLwd/TH3UsFXnNk1Zrx0tFeL+pP0fKO40L75xZMg2bjB9G8rLTU/OS8svpOt FLfAF4sjKTyYg3emt69cFQxfgYElMbFVPPkUWtpB5S2IyJOjXVwZgzeRQWvSvQC0LpKU gilwOy0idBKvjGHh5r6JwJtRX/LKk1ViNBrAv9cTBb7QmwjjktVCLBXuOayyI9unsOCU e0IpnYt6StIkKqedXKlwXd7crDvIpx8XmbsBjEcdqR6bfE7+MqVx6oKefzmOGFyx5/Cq wHT0c/bxBHtHLON7uAHONOMGtgoxKx4e6xrhIiZdoXlvnkFOOgW+KwayQ3Q/zIp5dQGx XmTQ== X-Gm-Message-State: ANoB5pkwZ/KVcvssVqWBMeUiW47oKJKVUki0ntxbPekw2jmsDsysIfV/ KlXMBfHF5345zoQ+gZ8WUxA= X-Google-Smtp-Source: AA0mqf71wV/j4omtd/qJJLVGmQHZGLNhJdEfsDGupWQ6PPhwFQ8mYqeM1RGR9yN3ZkTJqF3wQrVn7A== X-Received: by 2002:a05:6e02:d94:b0:302:a008:83e5 with SMTP id i20-20020a056e020d9400b00302a00883e5mr1387224ilj.293.1668721802864; Thu, 17 Nov 2022 13:50:02 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id m27-20020a026d1b000000b00374f8a0ed3csm619830jac.103.2022.11.17.13.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Nov 2022 13:50:01 -0800 (PST) Content-Type: multipart/mixed; boundary="------------j9XrjvApmr25QgagXLxLKajP" Message-ID: <36c502d5-a556-ab12-5466-32c112a2242f@gmail.com> Date: Thu, 17 Nov 2022 14:50:00 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] Ver.2: Add compile option "-msmall-data-limit=0" to avoid using .srodata section for riscv. Content-Language: en-US To: Yixuan Chen , gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, andrew@sifive.com, oriachiuan@gmail.com References: <20221117095355.1928564-1-chenyixuan@iscas.ac.cn> From: Jeff Law In-Reply-To: <20221117095355.1928564-1-chenyixuan@iscas.ac.cn> X-Spam-Status: No, score=-8.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------j9XrjvApmr25QgagXLxLKajP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/17/22 02:53, Yixuan Chen wrote: > 2022-11-17 Yixuan Chen > > * gcc/testsuite/gcc.dg/pr25521.c: Add compile option "-msmall-data-limit=0" to avoid using .srodata section for riscv. > --- > gcc/testsuite/gcc.dg/pr25521.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.dg/pr25521.c b/gcc/testsuite/gcc.dg/pr25521.c > index 74fe2ae6626..628ddf1a761 100644 > --- a/gcc/testsuite/gcc.dg/pr25521.c > +++ b/gcc/testsuite/gcc.dg/pr25521.c > @@ -2,7 +2,8 @@ > sections. > > { dg-require-effective-target elf } > - { dg-do compile } */ > + { dg-do compile } > + { dg-options "-msmall-data-limit=0" { target { riscv*-*-* } } } */ > > const volatile int foo = 30; > Wouldn't this be better?  It avoids a target specific conditional by instead extending what we look for to cover [s]rodata sections. Thoughts? Jeff --------------j9XrjvApmr25QgagXLxLKajP Content-Type: text/plain; charset=UTF-8; name="P" Content-Disposition: attachment; filename="P" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMjU1MjEuYyBiL2djYy90ZXN0 c3VpdGUvZ2NjLmRnL3ByMjU1MjEuYwppbmRleCA3NGZlMmFlNjYyNi4uNjMzNjNhMDNiOWYg MTAwNjQ0Ci0tLSBhL2djYy90ZXN0c3VpdGUvZ2NjLmRnL3ByMjU1MjEuYworKysgYi9nY2Mv dGVzdHN1aXRlL2djYy5kZy9wcjI1NTIxLmMKQEAgLTcsNCArNyw0IEBACiBjb25zdCB2b2xh dGlsZSBpbnQgZm9vID0gMzA7CiAKIAotLyogeyBkZy1maW5hbCB7IHNjYW4tYXNzZW1ibGVy ICJcXC5yb2RhdGEiIH0gfSAqLworLyogeyBkZy1maW5hbCB7IHNjYW4tYXNzZW1ibGVyICJc XC5zXD9yb2RhdGEiIH0gfSAqLwo= --------------j9XrjvApmr25QgagXLxLKajP--