From: Tom de Vries <Tom_deVries@mentor.com>
To: Jakub Jelinek <jakub@redhat.com>, Joseph Myers <joseph@codesourcery.com>
Cc: Volker Reichelt <v.reichelt@netcologne.de>,
<gcc-patches@gcc.gnu.org>, Marek Polacek <polacek@redhat.com>
Subject: Re: [PATCH] Some more translation related tweaks
Date: Wed, 01 Mar 2017 10:20:00 -0000 [thread overview]
Message-ID: <36ea892d-a12e-f61e-18cd-8e7ca00c8629@mentor.com> (raw)
In-Reply-To: <20170227173324.GC1849@tucnak>
On 27/02/17 18:33, Jakub Jelinek wrote:
> On Mon, Feb 27, 2017 at 12:47:09PM +0000, Joseph Myers wrote:
>> On Mon, 27 Feb 2017, Jakub Jelinek wrote:
>>
>>> On Mon, Feb 27, 2017 at 11:04:36AM +0100, Volker Reichelt wrote:
>>>>> This is not -Wformat-security friendly, perhaps better
>>>>> pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla,
>>>>> typedef_variant_p (orig_type)
>>>>> ? "non-constant array new length must be specified "
>>>>> "directly, not by typedef"
>>>>> : "non-constant array new length must be specified "
>>>>> "without parentheses around the type-id");
>>>>> ?
>>>>
>>>> Not quite. Like this the second string doesn't end up in the gcc.pot
>>>> file for translation. I had to wrap the second string in G_(...) to make
>>>> it work. (I'll have a look for other instances of this pattern and
>>>> prepare a separate patch.)
>>>
>>> Looks like a xgettext bug or missing feature :(. Joseph, shall we just
>>> change all those to be G_() around the second string (well, some could be
>>
>> Yes, it's generally the case that G_() is used whenever there's a
>> conditional expression for the msgid argument to a diagnostic function.
>
> So, is this ok for trunk? Shall I regenerate gcc.pot or will you?
>
> 2017-02-27 Jakub Jelinek <jakub@redhat.com>
>
> * config/i386/i386.c (ix86_option_override_internal): Use
> cond ? G_("...") : G_("...") instead of just cond ? "..." : "...".
> * config/nvptx/nvptx.c (nvptx_goacc_validate_dims): Likewise.
> --- gcc/config/nvptx/nvptx.c.jj 2017-02-21 15:36:03.000000000 +0100
> +++ gcc/config/nvptx/nvptx.c 2017-02-27 15:48:20.031688240 +0100
> @@ -4542,8 +4542,8 @@ nvptx_goacc_validate_dims (tree decl, in
> if (fn_level < 0 && dims[GOMP_DIM_VECTOR] >= 0)
> warning_at (decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION, 0,
> dims[GOMP_DIM_VECTOR]
> - ? "using vector_length (%d), ignoring %d"
> - : "using vector_length (%d), ignoring runtime setting",
> + ? G_("using vector_length (%d), ignoring %d")
> + : G_("using vector_length (%d), ignoring runtime setting"),
> PTX_VECTOR_LENGTH, dims[GOMP_DIM_VECTOR]);
> dims[GOMP_DIM_VECTOR] = PTX_VECTOR_LENGTH;
> changed = true;
This breaks the nvptx build:
...
src/gcc-mainline/gcc/config/nvptx/nvptx.c: In function 'bool
nvptx_goacc_validate_dims(tree, int*, int)':
src/gcc-mainline/gcc/config/nvptx/nvptx.c:4545:51: error: 'G_' was not
declared in this scope
...
I suppose an
#include "intl.h"
will fix that.
Thanks,
- Tom
next prev parent reply other threads:[~2017-03-01 10:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 12:36 Volker Reichelt
2017-02-26 13:25 ` Jakub Jelinek
2017-02-27 10:27 ` Volker Reichelt
2017-02-27 11:15 ` Jakub Jelinek
2017-02-27 12:49 ` Joseph Myers
2017-02-27 19:23 ` Jakub Jelinek
2017-02-27 22:27 ` Joseph Myers
2017-03-01 10:20 ` Tom de Vries [this message]
2017-03-01 11:14 ` Jakub Jelinek
2017-02-27 13:33 ` Jakub Jelinek
2017-02-27 13:40 ` Volker Reichelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ea892d-a12e-f61e-18cd-8e7ca00c8629@mentor.com \
--to=tom_devries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
--cc=v.reichelt@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).