public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Sumanth Gundapaneni <Sumanth.Gundapaneni@kpitcummins.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"rth@redhat.com"	<rth@redhat.com>,
	"Jayant R. Sonar" <Jayant.Sonar@kpitcummins.com>
Subject: RE: CR16 Port addition
Date: Fri, 15 Jul 2011 07:54:00 -0000	[thread overview]
Message-ID: <371569CBCFB2E745B891DBB88B2DFDDD1EAAB93763@KCINPUNHJCMS01.kpit.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1105201613010.995@digraph.polyomino.org.uk>

PING 3: For review
Hi,
    Please review the attached patch and you can view the 
explanations for the earlier communication below.

NOTE: From now on , Jayant (Jayant.Sonar@kpitcummins.com) will be 
posting the patches related to CR16. Please feel free to contact him 
if you need any information related to the patches posted. 

Thanks in advance,
Sumanth G,
PUNE (India).

===== Begin Message ======
-----Original Message-----
From: Sumanth Gundapaneni
Sent: Monday, May 30, 2011 6:57 PM
To: 'Joseph Myers'
Cc: gcc-patches@gcc.gnu.org; rth@redhat.com; Jayant R. Sonar
Subject: RE: CR16 Port addition

Hi Joseph and Richard,

Thanks for your time in reviewing the CR16 port and once again I am grateful for your valuable suggestions.

Please find attached the patch "cr16-gcc.patch" which contains modifications as suggested by Joseph in his previous mail.

For your kind information, I am providing the recent posts regarding
CR16 patches.
Initial post : http://gcc.gnu.org/ml/gcc-patches/2010-12/msg01676.html
Second post  : http://gcc.gnu.org/ml/gcc-patches/2011-01/msg00803.html  
Third post   : http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00624.html
Fourth post  : http://gcc.gnu.org/ml/gcc-patches/2011-05/msg01441.html 

Please review the patch and let me know if there should be any modifications in it.

Joseph, please go through my explanation for your comments.

>Please remove the remaining top level configure changes from the patch.

The top level configure changes have been removed as advised.


>Now you seem to have a stray change to the generated file
>libstdc++-v3/configure. Again, you can probably just eliminate this

The configure changes in libtsdc++-v3 are removed too and you can find 
the same in the updated patch.


>and make the code in unwind-dw2-* use those macros, 
>instead of having separate copies of the files.

A new file unwind-helper.h file is created in libgcc/config/cr16 directory 
as per your suggestion and defined a few macros in this newly defined file 
which are getting called from gcc/unwind-dw2.c. Please review the same 
and do let me know for further modifications, if any. We have identified 
issues related to exception handling using prints in unwind code and 
will debug the same to a greater extent in near future with further 
development of GNU based tools.


>Since you first submitted the port, a file contrib/config-list.mk

"cr16-elf" is added to config-list.mk file.


gcc/ChangeLog:
--------------
2011-05-28	Sumanth G <sumanth.gundapaneni@kpitcummins.com>
		Jayant R Sonar <jayant.sonar@kpitcummins.com>
		
	* config.gcc: Add cr16-* support.

	* doc/extend.texi: Document cr16 extensions.
	* doc/install.texi: Document cr16 install.
	* doc/invoke.texi: Document cr16 options.
	* doc/md.texi: Document cr16 constraints.

	* config/cr16/cr16.c: New file.
	* config/cr16/cr16.h: New file.
	* config/cr16/cr16.md: New file.
	* config/cr16/cr16.opt: New file.
	* config/cr16/cr16-libgcc.s: New file.
	* config/cr16/cr16-protos.h: New file.
	
	* config/cr16/divmodhi3.c: New file.
	* config/cr16/predicates.md: New file.
	* config/cr16/constraints.md: New file.
	* config/cr16/t-cr16: New file.

libgcc/ChangeLog:
-----------------
2011-05-28  Sumanth G <sumanth.gundapaneni@kpitcummins.com>
		Jayant R Sonar <jayant.sonar@kpitcummins.com>

	* config.host: Add National Semiconductor CR16 target (cr16-*-*).
	* config/cr16/crti.S: New file.
	* config/cr16/crtlibid.S: New file.
	* config/cr16/crtn.S: New file.
	* config/cr16/t-cr16: New file.
	* config/cr16/unwind-helper.h: New file.
	
contrib/ChangeLog:
----------
2011-05-28  Sumanth G <sumanth.gundapaneni@kpitcummins.com>
		Jayant R Sonar <jayant.sonar@kpitcummins.com>

	* config-list.mk: Add National Semiconductor CR16 target.
   
Thanks in advance,
Sumanth G,
PUNE (India).

===== End Message ======


  parent reply	other threads:[~2011-07-15  6:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 13:26 Sumanth Gundapaneni
2011-04-08 14:56 ` Joseph S. Myers
2011-05-20 13:59   ` Sumanth Gundapaneni
2011-05-20 17:07     ` Joseph S. Myers
2011-05-30 15:44       ` Sumanth Gundapaneni
2011-06-09 10:15       ` Sumanth Gundapaneni
2011-06-28  8:32       ` Sumanth Gundapaneni
2011-07-15  7:54       ` Sumanth Gundapaneni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-01-13  9:06 Sumanth Gundapaneni
2011-01-14 18:54 ` Richard Henderson
2010-12-22 11:58 Sumanth Gundapaneni
2010-12-22 13:25 ` Joseph S. Myers
2010-12-29 15:32   ` Sumanth Gundapaneni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=371569CBCFB2E745B891DBB88B2DFDDD1EAAB93763@KCINPUNHJCMS01.kpit.com \
    --to=sumanth.gundapaneni@kpitcummins.com \
    --cc=Jayant.Sonar@kpitcummins.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).