From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 4FA4C3857BBF for ; Fri, 15 Jul 2022 13:47:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4FA4C3857BBF Received: by mail-pl1-x632.google.com with SMTP id 5so3273965plk.9 for ; Fri, 15 Jul 2022 06:47:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=0f05sSvcXArWJcSm2SP0ZRJUjJ6FNWb93vsEjOSB4yE=; b=dmlpE0Nn3Xs6pZ3mv+8DfnJ2S+rTa5ME1yh+SYR6Rpma3jK6qgPKrc7s/as2PEl+Az 2uVVL33Na0mtkQ+NPsvkkxO+UOLjm+SBr5wxj36YSAY0Kx9s62YoTQr4lB0/fPEuauiP hmlAdXaW73YsDjvnKebJoYqHjYS1FgBzk+AVJJEI/8zLU9j/pz3LoFXF5H9D7l6Y4+/z vIwKm2SXefgbPWHu7KdYVSrqXpRSPUe6JZzhrij8+7oM+K7b90x136MMEHzH6LI5uKsp UKUcV81bQHKo7NQ8Btzifn8hpoZPKHCtKcdPIf9Miq/cf/SyYaFFuGXrA4GLzPkGdIIQ 3hMw== X-Gm-Message-State: AJIora+UvHzRxu9qTrKEsC+sAmH9yI5BUq3V3Bb87Bh3MdZfGA5FmeWQ HsDKOXXm/tvU1ysKCdl2YbLEE827IdyuuA== X-Google-Smtp-Source: AGRyM1vUg6EnLKEskxspq2wDEX1znXw9qOmLnfQrbrCrxbv2Amh0O9+wpnTvbPeX/3CvlWpmCoNbQQ== X-Received: by 2002:a17:902:d682:b0:16c:2ba7:beed with SMTP id v2-20020a170902d68200b0016c2ba7beedmr13889074ply.110.1657892875214; Fri, 15 Jul 2022 06:47:55 -0700 (PDT) Received: from [172.16.184.67] ([103.175.111.222]) by smtp.gmail.com with ESMTPSA id g5-20020a170902d1c500b0016bd72887fcsm3487845plb.59.2022.07.15.06.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 06:47:54 -0700 (PDT) Message-ID: <371c5653-59a8-6ca5-819b-76ab74e86625@woven-planet.global> Date: Fri, 15 Jul 2022 15:47:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Add condition coverage profiling Content-Language: en-US To: Sebastian Huber , gcc-patches@gcc.gnu.org References: <20220715113938.19068-1-jorgen.kvalsvik@woven-planet.global> <612b05e8-2caf-b406-0964-03272befb650@embedded-brains.de> From: =?UTF-8?Q?J=c3=b8rgen_Kvalsvik?= In-Reply-To: <612b05e8-2caf-b406-0964-03272befb650@embedded-brains.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2022 13:47:57 -0000 On 15/07/2022 15:31, Sebastian Huber wrote: > On 15.07.22 13:47, Jørgen Kvalsvik via Gcc-patches wrote: >> 2. New vocabulary for the output - decisions for, well, the decisions. It also >> writes at most one line per condition: >> >>     decisions covered 1/4 >>     condition  0 not covered (true false) >>     condition  1 not covered (true) > > Do we really have multiple decisions? I think we have only one decision composed > of conditions and zero or more boolean operators. We have variants of condition > outcomes. > Maybe, I'm not sure - you could argue that since a fixture of boolean "dominates" the outcome (either by short circuiting subsequent terms or masking preceding terms) then that fixture is a decision which leads to one of two outcomes. The other parameters may change but they wouldn't change the decision. You have 2^N inputs but only N+1 decisions. Personally the "variants" phrasing doesn't feel right to me. That being said I'm open to making this whatever the maintainers feel is appropriate.