From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Seija Kijin <doremylover456@gmail.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] arm: unified syntax for libgcc clear_cache
Date: Fri, 13 Jan 2023 13:05:39 +0000 [thread overview]
Message-ID: <371e70fa-abc6-bf6d-6ec8-0ce94a703f7e@foss.arm.com> (raw)
In-Reply-To: <CAOfV4GeOq_fLcEcOFdA7L7g1b3Pu7iDPFX=JxrMgtkhDvd+FxA@mail.gmail.com>
I've just noticed that this was never committed. Presumably that's
because the patch did not apply cleanly. I've cleaned it up and pushed
it now.
R.
On 30/09/2022 16:30, Seija Kijin via Gcc-patches wrote:
> Yes, please!
>
> On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov <Kyrylo.Tkachov@arm.com> wrote:
>>
>> Hi Seija,
>>
>>> -----Original Message-----
>>> From: Gcc-patches <gcc-patches-
>>> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via
>>> Gcc-patches
>>> Sent: Thursday, August 11, 2022 2:36 PM
>>> To: gcc-patches@gcc.gnu.org
>>> Subject: [PATCH] arm: unified syntax for libgcc clear_cache
>>>
>>> The patch to convert all thumb1 code in libgcc to unified syntax
>>> omitted changing all swi instructions to the current name: svc.
>>>
>>> This patch fixes this case.
>>
>> This is ok, thanks.
>> Do you need someone to commit this for you?
>>
>> Kyrill
>>
>>>
>>> ---
>>> libgcc/config/arm/lib1funcs.S | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S
>>> index 8c39c9f20a2b..19fa1462ccf3 100644
>>> --- a/libgcc/config/arm/lib1funcs.S
>>> +++ b/libgcc/config/arm/lib1funcs.S
>>> @@ -1522,7 +1522,7 @@ LSYM(Lover12):
>>> add r7, r7, #2
>>> #endif
>>> mov r2, #0
>>> - swi 0
>>> + svc 0
>>> do_pop {r7}
>>> RET
>>> FUNC_END clear_cache
prev parent reply other threads:[~2023-01-13 13:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 13:35 Seija Kijin
2022-09-06 14:48 ` Kyrylo Tkachov
2022-09-30 15:30 ` Seija Kijin
2023-01-13 13:05 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=371e70fa-abc6-bf6d-6ec8-0ce94a703f7e@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=doremylover456@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).