From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id C1B963858D32 for ; Fri, 13 Jan 2023 13:05:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1B963858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8E3C4FEC; Fri, 13 Jan 2023 05:06:23 -0800 (PST) Received: from [10.2.78.76] (unknown [10.2.78.76]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CB93E3F587; Fri, 13 Jan 2023 05:05:40 -0800 (PST) Message-ID: <371e70fa-abc6-bf6d-6ec8-0ce94a703f7e@foss.arm.com> Date: Fri, 13 Jan 2023 13:05:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] arm: unified syntax for libgcc clear_cache Content-Language: en-GB To: Seija Kijin , Kyrylo Tkachov Cc: "gcc-patches@gcc.gnu.org" References: From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3495.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've just noticed that this was never committed. Presumably that's because the patch did not apply cleanly. I've cleaned it up and pushed it now. R. On 30/09/2022 16:30, Seija Kijin via Gcc-patches wrote: > Yes, please! > > On Tue, Sep 6, 2022 at 10:48 AM Kyrylo Tkachov wrote: >> >> Hi Seija, >> >>> -----Original Message----- >>> From: Gcc-patches >> bounces+kyrylo.tkachov=arm.com@gcc.gnu.org> On Behalf Of Seija Kijin via >>> Gcc-patches >>> Sent: Thursday, August 11, 2022 2:36 PM >>> To: gcc-patches@gcc.gnu.org >>> Subject: [PATCH] arm: unified syntax for libgcc clear_cache >>> >>> The patch to convert all thumb1 code in libgcc to unified syntax >>> omitted changing all swi instructions to the current name: svc. >>> >>> This patch fixes this case. >> >> This is ok, thanks. >> Do you need someone to commit this for you? >> >> Kyrill >> >>> >>> --- >>> libgcc/config/arm/lib1funcs.S | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/libgcc/config/arm/lib1funcs.S b/libgcc/config/arm/lib1funcs.S >>> index 8c39c9f20a2b..19fa1462ccf3 100644 >>> --- a/libgcc/config/arm/lib1funcs.S >>> +++ b/libgcc/config/arm/lib1funcs.S >>> @@ -1522,7 +1522,7 @@ LSYM(Lover12): >>> add r7, r7, #2 >>> #endif >>> mov r2, #0 >>> - swi 0 >>> + svc 0 >>> do_pop {r7} >>> RET >>> FUNC_END clear_cache