From: 钟居哲 <juzhe.zhong@rivai.ai>
To: rdapp.gcc <rdapp.gcc@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: rdapp.gcc <rdapp.gcc@gmail.com>,
kito.cheng <kito.cheng@gmail.com>,
kito.cheng <kito.cheng@sifive.com>,
"Jeff Law" <jeffreyalaw@gmail.com>
Subject: Re: Re: [PATCH V2] RISC-V: Support Dynamic LMUL Cost model
Date: Wed, 6 Sep 2023 05:39:51 +0800 [thread overview]
Message-ID: <37526A047B319E58+202309060539510942814@rivai.ai> (raw)
In-Reply-To: <8d4def48-33c1-2edb-2ae7-2838cf9399e2@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2814 bytes --]
- Why don't we use the normal reverse postorder (or postorder) approach of
computing live ranges? Is that because we don't really need full global
live ranges?
Yes. We don't need global live ranges.
- Why can't we use existing code i.e. tree-ssa-live? I suspect I already
know the answer but an explanation (in a comment) would still be useful.
The existing code can't help I have tried many times.
- Do we really need get_all_predecessors/get_all_successors? As they're
only used for "defined before" and "used after", at first glance it
looks like some kind of dominance info could help there but I didn't
really check in detail.
Yes. At the first time, I want to use dominance analysis but I am not sure whether
we can use df_analyze () in COST model framwork. It worth trying.
- Why don't we use bitmaps/sbitmaps like in vsetvl.cc and other related
passes? I don't mind maps but just wonder if it's on purpose, for
convenience or something else.
I don't know how to use bitmap to substitue the current approach of using map.
Besides, it might help to rename program_points_map (into program_points_per_bb
or so). At first it looked quadratic to me but we're just iterating over
the program points of a BB.
Ok.
juzhe.zhong@rivai.ai
From: Robin Dapp
Date: 2023-09-06 05:02
To: Juzhe-Zhong; gcc-patches
CC: rdapp.gcc; kito.cheng; kito.cheng; jeffreyalaw
Subject: Re: [PATCH V2] RISC-V: Support Dynamic LMUL Cost model
Hi Juzhe,
I think the general approach makes sense and it doesn't need to be perfect
from the beginning as we can always iterate on it. Before continuing with a
more detailed review (hopefully tomorrow) some high-level questions upfront.
It would help to document some of these choices so it's easier to understand
the rationale.
- Why don't we use the normal reverse postorder (or postorder) approach of
computing live ranges? Is that because we don't really need full global
live ranges?
- Why can't we use existing code i.e. tree-ssa-live? I suspect I already
know the answer but an explanation (in a comment) would still be useful.
- Do we really need get_all_predecessors/get_all_successors? As they're
only used for "defined before" and "used after", at first glance it
looks like some kind of dominance info could help there but I didn't
really check in detail.
- Why don't we use bitmaps/sbitmaps like in vsetvl.cc and other related
passes? I don't mind maps but just wonder if it's on purpose, for
convenience or something else.
Besides, it might help to rename program_points_map (into program_points_per_bb
or so). At first it looked quadratic to me but we're just iterating over
the program points of a BB.
Regards
Robin
next prev parent reply other threads:[~2023-09-05 21:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 8:56 Juzhe-Zhong
2023-09-05 21:02 ` Robin Dapp
2023-09-05 21:39 ` 钟居哲 [this message]
2023-09-05 21:53 ` Jeff Law
2023-09-06 13:22 ` Robin Dapp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37526A047B319E58+202309060539510942814@rivai.ai \
--to=juzhe.zhong@rivai.ai \
--cc=gcc-patches@gcc.gnu.org \
--cc=jeffreyalaw@gmail.com \
--cc=kito.cheng@gmail.com \
--cc=kito.cheng@sifive.com \
--cc=rdapp.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).