From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 5389C385800F for ; Wed, 31 Aug 2022 20:39:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5389C385800F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pl1-x632.google.com with SMTP id y1so13344084plb.2 for ; Wed, 31 Aug 2022 13:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6scMEh/SVRGhxVRNWd41KSC3hLM83fhBL/kVPEsQBHo=; b=SXeo4Rkb5ztOSHlWnomw/uYOqXa41JXnuAvIuu9niwCe0sm0ejVuJCpbPLkGKaXpfU 4ypi1LN2x7Z65UIKtDMmXjMHS4c8SmCxARZcdsJmwxst4XIV8AvzhR25TmQ0LmujfOP5 FRvDN3dsTac5oiDTvbU041F76dvdQ6LeITmSrJt8PeD6qlWalVFTg6Bg6roLFtW/aq+x cfObBa9KkkuSoQ5YhHgtN7c5pu1GlqYQQqAbkmYEdAbAGPuYG5pjxno+GfMTHSARIKAi 6iybJPHCREQPiAQvtcUzoHYguakKpEuswnHbSG6mjOCpUC5zSWgZqPDYzmKCV5Uudcrz O/Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6scMEh/SVRGhxVRNWd41KSC3hLM83fhBL/kVPEsQBHo=; b=SatEWebAtA/m3OS6A86zjqEq68K5N6uAn2vFWkrY1C332JEC8TIiGgZbYzk5sNLBTS WJF2rP5/YsX3qo823+MZMH4KV92mLREpcoqlwxvz8COsj1tDDOtfyl+WPSzSYX/2x2IY kbkGIf+hFXFHIQ2X4O/tWIlURXRJMbdim2gnCBWQk5UodwjSpPJpjPOe7EG9AjMatp6F 9QD5cVzScJpfjZFuN31+37mYMFASDgMUCpLJTUM5iybA1cbzus3A5Mb5MDlPNlfF2zWw l8rBAAFbxSVdh/BwUntqUlInvmeCK9ouA+UNzdFsk23EwlaKewd2RLZhdUIAedeeHgBW c71A== X-Gm-Message-State: ACgBeo0lSxZWJ1378P0OuN3UUNCLvvhfuUMwS4MVsK0ix221TsXkmJ+x ClJgFzojM/Vks/DWp0xpMCySuQ== X-Google-Smtp-Source: AA6agR5pjzqUZCfqJtiFs43H9pRYoYQ/KZSnCK+x6vWEa+9wQPtep23iA0BcLE2UQVtRG4Lr2tOc2Q== X-Received: by 2002:a17:902:8503:b0:173:368b:dce3 with SMTP id bj3-20020a170902850300b00173368bdce3mr27556252plb.104.1661978388373; Wed, 31 Aug 2022 13:39:48 -0700 (PDT) Received: from [192.168.50.116] (c-24-4-73-83.hsd1.ca.comcast.net. [24.4.73.83]) by smtp.gmail.com with ESMTPSA id g15-20020aa796af000000b0052d9d95bb2bsm5635389pfk.180.2022.08.31.13.39.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 13:39:46 -0700 (PDT) Message-ID: <376353ac-6bfc-05c9-cb32-85e87eec177d@rivosinc.com> Date: Wed, 31 Aug 2022 13:39:45 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] RISC-V: remove CM_PIC as it doesn't do much Content-Language: en-US To: Palmer Dabbelt Cc: gcc-patches@gcc.gnu.org, Kito Cheng , Jim Wilson , philipp.tomsich@vrull.eu, christoph.muellner@vrull.eu, collison@rivosinc.com, gnu-toolchain@rivosinc.com References: From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/31/22 07:57, Palmer Dabbelt wrote: >>    if (flag_pic) >> -    riscv_cmodel = CM_PIC; >> +    riscv_cmodel = CM_MEDANY; >> >>    /* We get better code with explicit relocs for CM_MEDLOW, but >>       worse code for the others (for now).  Pick the best default.  */ > > I'm fine either way on this one: having CM_PIC gone makes it a bit > more likely to confuse CM_MEDANY with PIC, but flag_pic is overriding > riscv_cmodel anyway so this isn't really used and deleting code is > always a plus. Indeed this was the most contentious part of removing CM_PIC, but it seems this is the way fwd. I'll add Kito's comment from [1] in code to make it more explicit. [1]https://github.com/riscv-non-isa/riscv-c-api-doc/pull/11#issuecomment-686385585 Thx, -Vineett