From: Jonathan Yong <10walls@gmail.com>
To: Jonathan Yong via Gcc-patches <gcc-patches@gcc.gnu.org>,
Hans-Peter Nilsson <hp@bitrange.com>,
richard.sandiford@arm.com
Subject: Re: [Patch] gcc.dg/overflow-warn-9.c: exclude from LLP64
Date: Thu, 2 Mar 2023 13:42:34 +0000 [thread overview]
Message-ID: <378f4818-1ce3-63c6-4852-ee71633be382@gmail.com> (raw)
In-Reply-To: <mptmt4vjuup.fsf@arm.com>
On 3/2/23 10:44, Richard Sandiford wrote:
>> diff --git a/gcc/testsuite/gcc.dg/overflow-warn-9.c b/gcc/testsuite/gcc.dg/overflow-warn-9.c
>> index 57c0f17bc91..ae588bd8491 100644
>> --- a/gcc/testsuite/gcc.dg/overflow-warn-9.c
>> +++ b/gcc/testsuite/gcc.dg/overflow-warn-9.c
>> @@ -59,7 +59,8 @@ const struct Types t1 = {
>> .ui = UINT_MAX + 1L, /* { dg-warning "signed conversion from .long int. to .unsigned int. changes value from .4294967296. to .0." "lp64" { target lp64 } } */
>> .ui = UINT_MAX + 1LU, /* { dg-warning "conversion from .long unsigned int. to .unsigned int. changes value from .4294967296. to .0." "lp64" { target lp64 } } */
>>
>> - .sl = LONG_MAX + 1LU, /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value from .9223372036854775808. to .-9223372036854775808." "not-ilp32" { target { ! ilp32 } } } */
>> + .sl = LONG_MAX + 1LU, /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value from .9223372036854775808. to .-9223372036854775808." "lp64" { target lp64 } } */
>> /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value from .2147483648. to .-2147483648." "ilp32" { target ilp32 } .-1 } */
>> + /* { dg-warning "signed conversion from .long unsigned int. to .long int. changes value from .2147483648. to .-2147483648." "llp64" { target llp64 } .-2 } */
>> .ul = ULONG_MAX + 1LU /* there should be some warning here */
>> };
>
> OK, although in general I think would be good to use
> { target { ilp32 || llp64 } } for this kind of thing.
>
> No need to change this patch though, just saying for the future.
>
Thanks for reviewing, how does the "ilp32" or "llp64" before the curly
target brackets work?
Pushed existing patch to master branch.
next prev parent reply other threads:[~2023-03-02 13:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 9:52 Jonathan Yong
2023-02-27 16:51 ` Richard Sandiford
2023-02-28 3:06 ` Hans-Peter Nilsson
2023-02-28 10:30 ` Jonathan Yong
2023-03-01 0:15 ` Hans-Peter Nilsson
2023-03-02 10:44 ` Richard Sandiford
2023-03-02 13:42 ` Jonathan Yong [this message]
2023-03-02 13:55 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=378f4818-1ce3-63c6-4852-ee71633be382@gmail.com \
--to=10walls@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).