From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by sourceware.org (Postfix) with ESMTPS id C1E793858D35 for ; Mon, 6 May 2024 21:40:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C1E793858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C1E793858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::22d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715031643; cv=none; b=quvlinnj47cmp2LbpuyZjmRr8UNIjyCHvJD35kYMU/s3HTOX3aa2tQiUcWvQaG7z9O7szYrmHHBds4M4DPtB88rxXiES9jA8NqjGhgv4nJwpbgDaqcwtxG9JBNGvwljnhx6AbsOCTpFCYkLlN7gZAADTpYY5X4YTVRFz+RSK8UY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715031643; c=relaxed/simple; bh=7A9tm3MwoUfufQvO8cSIOw9PA8y0q3k+S+zXR5X5u5U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Kh8Wiqt5Pjy52muISStKZXNMDG0PdWl3Dldh+vct8qqE0/f4Nfa6q5gDEd5he6SzmfM0UgJHeJs0Vm6SF5vJ5ty6OkrSvkp1C78RjKIlFKoDcqC1rVZzs24LLkNZFR7IxSLmRkVAMJAuxVngN8TPD7ygIV1jeBK1UbkYUXGifdI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x22d.google.com with SMTP id 5614622812f47-3c96d8bff27so598225b6e.0 for ; Mon, 06 May 2024 14:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715031641; x=1715636441; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bmfxVhF5uxI4s6S7YbpHg+FGRVxKa/GaUrhV0IFCJSA=; b=Bvq9PyQANwyCA0hxiU82qeE5HVioRqzhTkSJ+o6C+S0//VTS6Ev/cOXOmTLJMA3G6q HBjkU8EgYPkGnkaWb1zJJSL/L507VwnmvPhXOKu2N8bdPY4Fx2Nlff71AgA8mZY808Jo BGVj34H+Q5o4xDXbdobbsIV9BqHHax4hbOUwYElzguBc5vAsLoWTOSz7mMIwDSMSzD/o 2scl0U+yXY7CZbIfxLF+rEKjiyWoZmnwhJeHM34CKTILNubFv2AIzFBybkwTy64h9+1n z7OLABQ1hN+wJXlpTu9MHhrYPX7b+P42NFKypl2tqnsRImEmbcvwml6F6qm3lAG9/6pq 27NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715031641; x=1715636441; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bmfxVhF5uxI4s6S7YbpHg+FGRVxKa/GaUrhV0IFCJSA=; b=wXpPjOJLJqj/Ktc7TicS75qEBmoU3pjRWmUWz9LFfrHM04phUSdYDwVrpP3KKQ2bHj 9jYTBjEbhNwql4B67T74JyIl8I54XrQtTctgaL4s9pIJiZZUrg/hvRAsu1EbdpcZzYdD dn15beeJhH0EnybCb1cm+/8ftStAQriFdrjcNaDSIelQfQ77MJSvp8ub/trYJBZ5UqAc 88rxXeG7NrCz0KeYyzx08LCVpRxKWzeCurtyXj4fUBASIhKC7nHGGeZmzXof7vhSmH2I 6JHk3t2dvJy8+0LAXF2dJ91SRsOUxJDiJYqpPpIZ6K1HMIXi7OO8tYHi6X1JMSzbOPaT dkyw== X-Forwarded-Encrypted: i=1; AJvYcCUBhJassdH8S80G1MTLD8L/XUNkddWaD+KeZJGPwMZ0rkMDYjNwK+Wlg8TbzUENlu7eE1fohVcLtz+R0C11WluNqoJZBBQmgQ== X-Gm-Message-State: AOJu0YzLAk9zLiKOvH2yg5x0Z5G4sj3k0D/3dt5LdaASlQHnrxjGZZA0 lun2t5MuBT+UDeYO6y0w8HmNdWiEuCFsVACahYaycUrKqJR98r1H X-Google-Smtp-Source: AGHT+IGn1T+yMeuQ4JcI9qQTfQphdVOFh1rY5iuCptAm2vxuV0DINFYbjUMIEi1GyJjUDyDT0qkNoQ== X-Received: by 2002:a05:6808:210e:b0:3c9:5d5d:3dc3 with SMTP id r14-20020a056808210e00b003c95d5d3dc3mr391572oiw.13.1715031640763; Mon, 06 May 2024 14:40:40 -0700 (PDT) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id bk41-20020a0568081a2900b003c74454329esm1592462oib.12.2024.05.06.14.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 May 2024 14:40:40 -0700 (PDT) Message-ID: <379b6dfc-5979-4a63-8e74-ecbc670f14cc@gmail.com> Date: Mon, 6 May 2024 15:40:39 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [NOT CODE REVIEW] [PATCH v3 1/1] [RISC-V] Add support for _Bfloat16 Content-Language: en-US To: Xiao Zeng , gcc-patches@gcc.gnu.org References: <20240506003845.70280-1-zengxiao@eswincomputing.com> <20240506003845.70280-2-zengxiao@eswincomputing.com> From: Jeff Law In-Reply-To: <20240506003845.70280-2-zengxiao@eswincomputing.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/5/24 6:38 PM, Xiao Zeng wrote: > 1 At point , > BF16 has already been completed "post public review". > > 2 LLVM has also added support for RISCV BF16 in > and > . > > 3 According to the discussion , > this use __bf16 and use DF16b in riscv_mangle_type like x86. > > Below test are passed for this patch > * The riscv fully regression test. > > gcc/ChangeLog: > > * config/riscv/iterators.md: New mode iterator HFBF. > * config/riscv/riscv-builtins.cc (riscv_init_builtin_types): > Initialize data type _Bfloat16. > * config/riscv/riscv-modes.def (FLOAT_MODE): New. > (ADJUST_FLOAT_FORMAT): New. > * config/riscv/riscv.cc (riscv_mangle_type): Support for BFmode. > (riscv_scalar_mode_supported_p): Ditto. > (riscv_libgcc_floating_mode_supported_p): Ditto. > (riscv_init_libfuncs): Set the conversion method for BFmode and > HFmode. > (riscv_block_arith_comp_libfuncs_for_mode): Set the arithmetic > and comparison libfuncs for the mode. > * config/riscv/riscv.md (mode" ): Add BF. > (movhf): Support for BFmode. > (mov): Ditto. > (*movhf_softfloat): Ditto. > (*mov_softfloat): Ditto. > > libgcc/ChangeLog: > > * config/riscv/sfp-machine.h (_FP_NANFRAC_B): New. > (_FP_NANSIGN_B): Ditto. > * config/riscv/t-softfp32: Add support for BF16 libfuncs. > * config/riscv/t-softfp64: Ditto. > * soft-fp/floatsibf.c: For si -> bf16. > * soft-fp/floatunsibf.c: For unsi -> bf16. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/bf16_arithmetic.c: New test. > * gcc.target/riscv/bf16_call.c: New test. > * gcc.target/riscv/bf16_comparison.c: New test. > * gcc.target/riscv/bf16_float_libcall_convert.c: New test. > * gcc.target/riscv/bf16_integer_libcall_convert.c: New test. Given we were only looking to have the CI system check the formatting nit and that has passed. I've pushed this to the trunk. jeff