From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7ABA1384C004 for ; Tue, 22 Jun 2021 06:50:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7ABA1384C004 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 52CC91FD5B; Tue, 22 Jun 2021 06:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1624344603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6PZ76qsqNGJKxoEKFL32sapPGjoNZ42aLKlRs7gehy4=; b=gpA9j6uZJJ4HppZGuPJVkaUbFov+d7kycLMMZNi2Ww7QhnrRpNRFszXVxi7fq+G/2XyCXr 1P/2q4hgbcb68XTvrDOr5kLdeWAf7U6TazSSzEW8n9HSzbl8QSdO0B1vgJaUi5R8WzgicX zgfkFj1JmdlwjkpF14Ka8T1GppCq4oo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1624344603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6PZ76qsqNGJKxoEKFL32sapPGjoNZ42aLKlRs7gehy4=; b=+mkWpAUBl5qVDvN7cbenz4Zzpw2uZT5GFvSDWnLtJZ0DldVt64i1yslhGSalUdoKfYL5xQ 0ixAd0uxEmS6mPBg== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 32B4B118DD; Tue, 22 Jun 2021 06:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1624344603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6PZ76qsqNGJKxoEKFL32sapPGjoNZ42aLKlRs7gehy4=; b=gpA9j6uZJJ4HppZGuPJVkaUbFov+d7kycLMMZNi2Ww7QhnrRpNRFszXVxi7fq+G/2XyCXr 1P/2q4hgbcb68XTvrDOr5kLdeWAf7U6TazSSzEW8n9HSzbl8QSdO0B1vgJaUi5R8WzgicX zgfkFj1JmdlwjkpF14Ka8T1GppCq4oo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1624344603; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6PZ76qsqNGJKxoEKFL32sapPGjoNZ42aLKlRs7gehy4=; b=+mkWpAUBl5qVDvN7cbenz4Zzpw2uZT5GFvSDWnLtJZ0DldVt64i1yslhGSalUdoKfYL5xQ 0ixAd0uxEmS6mPBg== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id jbULCxuI0WAaWAAALh3uQQ (envelope-from ); Tue, 22 Jun 2021 06:50:03 +0000 Subject: Re: [PATCH][pushed] gcov: update documentation entry about string format To: Eugene Rozenfeld , "gcc-patches@gcc.gnu.org" References: From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <37dc5e94-7b49-d694-0b94-91ae5a8206aa@suse.cz> Date: Tue, 22 Jun 2021 08:50:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 06:50:06 -0000 On 6/21/21 9:27 PM, Eugene Rozenfeld wrote: > Thank you for updating the documentation Martin. I thank you. > > The following line can now be removed: > > padding: | char:0 | char:0 char:0 | char:0 char:0 char:0 Sure, I've just done that. Martin > > Eugene > > -----Original Message----- > From: Gcc-patches On Behalf Of Martin Liška > Sent: Thursday, June 17, 2021 2:40 AM > To: gcc-patches@gcc.gnu.org > Subject: [EXTERNAL] [PATCH][pushed] gcov: update documentation entry about string format > > gcc/ChangeLog: > > * gcov-io.h: Update documentation entry about string format. > --- > gcc/gcov-io.h | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/gcc/gcov-io.h b/gcc/gcov-io.h index f7584eb9679..ff92afe63df 100644 > --- a/gcc/gcov-io.h > +++ b/gcc/gcov-io.h > @@ -42,15 +42,14 @@ see the files COPYING3 and COPYING.RUNTIME respectively. If not, see > > Numbers are recorded in the 32 bit unsigned binary form of the > endianness of the machine generating the file. 64 bit numbers are > - stored as two 32 bit numbers, the low part first. Strings are > - padded with 1 to 4 NUL bytes, to bring the length up to a multiple > - of 4. The number of 4 bytes is stored, followed by the padded > + stored as two 32 bit numbers, the low part first. > + The number of bytes is stored, followed by the > string. Zero length and NULL strings are simply stored as a length > of zero (they have no trailing NUL or padding). > > int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 > int64: int32:low int32:high > - string: int32:0 | int32:length char* char:0 padding > + string: int32:0 | int32:length char* char:0 > padding: | char:0 | char:0 char:0 | char:0 char:0 char:0 > item: int32 | int64 | string > > -- > 2.32.0 >