Hi. This patch improves aarch64 feature modifier hints. May I please ask ARM folks to test the patch? Thanks, Martin gcc/ChangeLog: 2018-07-18 Martin Liska PR driver/83193 * common/config/aarch64/aarch64-common.c (aarch64_parse_extension): Set invalid_extension when there's any. (aarch64_get_all_extension_candidates): New function. (aarch64_rewrite_selected_cpu): Pass NULL as new argument. * config/aarch64/aarch64-protos.h (aarch64_get_all_extension_candidates): Declare new function. * config/aarch64/aarch64.c (aarch64_parse_arch): Record invalid_feature. (aarch64_parse_cpu): Likewise. (aarch64_print_hint_for_feature_modifier): New. (aarch64_validate_mcpu): Record invalid feature modifier and print hint for it. (aarch64_validate_march): Likewise. (aarch64_handle_attr_arch): Likewise. (aarch64_handle_attr_cpu): Likewise. (aarch64_handle_attr_isa_flags): Likewise. gcc/testsuite/ChangeLog: 2018-07-18 Martin Liska PR driver/83193 * gcc.target/aarch64/spellcheck_7.c: New test. * gcc.target/aarch64/spellcheck_8.c: New test. --- gcc/common/config/aarch64/aarch64-common.c | 20 +++++- gcc/config/aarch64/aarch64-protos.h | 4 +- gcc/config/aarch64/aarch64.c | 67 +++++++++++++++---- .../gcc.target/aarch64/spellcheck_7.c | 11 +++ .../gcc.target/aarch64/spellcheck_8.c | 12 ++++ 5 files changed, 97 insertions(+), 17 deletions(-) create mode 100644 gcc/testsuite/gcc.target/aarch64/spellcheck_7.c create mode 100644 gcc/testsuite/gcc.target/aarch64/spellcheck_8.c