[arm-embedded] [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names

[Thomas Preudhomme <thomas.preudhomme@foss.arm.com>]

[-- Attachment #1: Type: text/plain, Size: 544 bytes --]

Hi,

We have decided to apply the following patch to the embedded-6-branch to fix 
naming of an ARM intrinsic.

ChangeLog entry is as follows:

2017-06-20  Thomas Preud'homme  <thomas.preudhomme@arm.com>

	Backport from mainline
	2017-05-04  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>

	gcc/
	* gcc/config/arm/arm-builtins.c (arm_init_builtins): Rename
	__builtin_arm_ldfscr to __builtin_arm_get_fpscr, and rename
	__builtin_arm_stfscr to __builtin_arm_set_fpscr.

	gcc/testsuite/
	* gcc.target/arm/fpscr.c: New file.


Best regards,

Thomas

[-- Attachment #2: Re: [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names.eml --]
[-- Type: message/rfc822, Size: 5059 bytes --]

From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Prakhar Bahuguna <prakhar.bahuguna@arm.com>, gcc-patches@gcc.gnu.org
Cc: nd@arm.com, Richard.Earnshaw@arm.com, Ramana.Radhakrishnan@arm.com
Subject: Re: [PATCH, GCC/ARM, Stage 1] Rename FPSCR builtins to correct names
Date: Mon, 10 Apr 2017 15:01:39 +0100
Message-ID: <58EB9043.8060104@foss.arm.com>

Hi Prakhar,
Sorry for the delay,

On 22/03/17 10:46, Prakhar Bahuguna wrote:
> The GCC documentation in section 6.60.8 ARM Floating Point Status and Control
> Intrinsics states that the FPSCR register can be read and written to using the
> intrinsics __builtin_arm_get_fpscr and __builtin_arm_set_fpscr. However, these
> are misnamed within GCC itself and these intrinsic names are not recognised.
> This patch corrects the intrinsic names to match the documentation, and adds
> tests to verify these intrinsics generate the correct instructions.
>
> Testing done: Ran regression tests on arm-none-eabi for Cortex-M4.
>
> 2017-03-09  Prakhar Bahuguna  <prakhar.bahuguna@arm.com>
>
> gcc/ChangeLog:
>
> 	* gcc/config/arm/arm-builtins.c (arm_init_builtins): Rename
> 	  __builtin_arm_ldfscr to __builtin_arm_get_fpscr, and rename
> 	  __builtin_arm_stfscr to __builtin_arm_set_fpscr.
> 	* gcc/testsuite/gcc.target/arm/fpscr.c: New file.
>
> Okay for stage 1?

I see that the mistake was in not addressing one of the review comments in:
https://gcc.gnu.org/ml/gcc-patches/2014-04/msg01832.html
properly in the patch that added these functions :(

This is ok for stage 1 if a bootstrap and test on arm-none-linux-gnueabihf works fine
I don't think we want to maintain the __builtin_arm_[ld,st]fscr names for backwards compatibility
as they were not documented and are __builtin_arm* functions that we don't guarantee to maintain.

Thanks,
Kyrill

> --
>
> Prakhar Bahuguna