From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id E1ABC3858C2D for ; Mon, 5 Feb 2024 21:04:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1ABC3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1ABC3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::332 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707167074; cv=none; b=P8/hYDptF8ESNbQRE7aISXQRfP4NUuiwcCBUKrf2cT/f0QzZ7GbrGQzPzUe3wmJJkMyaI7fsJYbDLDSobOG0oyBfnOrpAXxOhnoIQ72T7Sukw+q6LFA5uYdhf2PGuOS1FYFXdF4vcjLyQqMY7OxlufhX4grBvAs1b+QwG3S3iKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707167074; c=relaxed/simple; bh=uWTm8BxUaOAW8ZOF3rLqZr3drMSmaNKO5ouZD8+4guE=; h=DKIM-Signature:From:Mime-Version:Subject:Date:To:Message-Id; b=CtfymgNnFl73+hNhXCJkpfYpldMmZa0UCuYI0/nck1vMXcvvp5rxIN0U0i9PYoqDGDHj1V8OyqBRX4d1bkM4QtLDnGUXambMNxwYY04Jije+FW9tZWGflGYqFhMPm39xxrjSbTLaG95sb1ucwHJcsQYhKDgZvm61tfusLM/ir9A= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-40fb804e330so1427835e9.0 for ; Mon, 05 Feb 2024 13:04:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707167071; x=1707771871; darn=gcc.gnu.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=BzfM0ecnK6xY/abNFZHR+c3XRitoQSFBMDST9zE5qWs=; b=IlyV+x7PKgCWUTF2/Ir8vtjz7+sc2xgBzuZ59v+s8PUeJTDnQxQ6NmuJdAQaBlauyr 5qyLdf+m/4KDklWcarXeNDsYWnbQ7g9VfcoTvovuAUXkPoXQq1fQNgcfrm72bsbGcaci /o9IcG+FRb1GGUWcdrb/i3q1sPCXuTyQs/3+1Dy/6kozjaVSn0rBjCgzhIMrKkOqv5wl tZa8T73j5jjS2cMbwIETDFTjnf5rLphvDSA9LcQ3RNnOxSwADDKqp/0xcl0FtZy+KII0 m6+9ezTFmhYW7zTe0FMdp2/m4qEtRxdCjhvE5NvO+TeeKcAQjnN9iMELzLffREBmWh2W jdtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707167071; x=1707771871; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BzfM0ecnK6xY/abNFZHR+c3XRitoQSFBMDST9zE5qWs=; b=aQi+0/LpNyEmd/Pqi8oOUlyIvB3JWu+aTbTkq+Y09zOn4zCQ86Rz6yJpyf3OusoaEO G8il/8jwccZqhZODSlxiJ5BB8sXsOq9ZPKyzDvZYBBnZhUHpf7rXOM57xo9lMSHy9pue R7OerrARfeJTq2JIxDFQRbXbcv+05edM36ucLTWJdAUHB79rJ6G91JRiOKHi2GwA1rSS 1fL4Iwqi2zMFaaP0WZ2hPXQ+El2TkDsBOYTqILwJ7c/cixYqPcidpLrSw25HrYTwLqAi OIUPajnQdBfZ9ea3ao0P+pzk+MD2p4+L36IHQpMXxdMqfMIh5Jcw6we9frMcy2UHpgWF 6nwg== X-Gm-Message-State: AOJu0YwiMZ64T8Vbhey2dpdmIPqRlXJJA3S73qZY5drgxDobPkDevEcr lxyq0i5/E7oKsicgwAU6EOY2tbm8ixU18gm2IKctB7Erbv9HdwOtKDF9UyrV X-Google-Smtp-Source: AGHT+IEUgQFPpLYPBgHpwfvsidTxzAAHOq5tg4Lxv2QR8yjdGt8Nd+T7TskE4X1LVRkMBPzwxyHDvA== X-Received: by 2002:a05:600c:1390:b0:40e:a569:3555 with SMTP id u16-20020a05600c139000b0040ea5693555mr687178wmf.35.1707167070539; Mon, 05 Feb 2024 13:04:30 -0800 (PST) Received: from smtpclient.apple (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id g15-20020a05600c4ecf00b0040fc5460109sm959812wmq.35.2024.02.05.13.04.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2024 13:04:30 -0800 (PST) From: Iain Sandoe Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH] aarch64, acle header: Cast uint64_t pointers to DIMode. Date: Mon, 5 Feb 2024 21:04:29 +0000 References: <20240205145606.93835-1-iain@sandoe.co.uk> To: GCC Patches In-Reply-To: <20240205145606.93835-1-iain@sandoe.co.uk> Message-Id: <380B64B0-9824-4121-81B8-F61EB4813B0D@gmail.com> X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 5 Feb 2024, at 14:56, Iain Sandoe wrote: >=20 > Tested on aarch64-linux,darwin and a cross from aarch64-darwin to = linux, > OK for trunk, or some alternative is needed? Hmm.. apparently, this fails the linaro pre-commit CI for g++ with: error: invalid conversion from 'long int*' to 'long unsigned int*' = [-fpermissive] So, I guess some alternative is needed, advice welcome, Iain > thanks > Iain >=20 > --- 8< --- >=20 > Currently, most of the acle tests fail on the Darwin port because > DI mode is "long" and uint64 is "long long". The fix for this used > in other headers is to cast the pointers using = __builtin_aarch64_simd_di > and that is what this patch does. >=20 > gcc/ChangeLog: >=20 > * config/aarch64/arm_acle.h (__rndr): Cast uint64 pointer to DI > mode to avoid typedef mismatches. > (__rndrrs): Likewise. > --- > gcc/config/aarch64/arm_acle.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/gcc/config/aarch64/arm_acle.h = b/gcc/config/aarch64/arm_acle.h > index 2aa681090fa..823f87187b1 100644 > --- a/gcc/config/aarch64/arm_acle.h > +++ b/gcc/config/aarch64/arm_acle.h > @@ -309,14 +309,14 @@ __extension__ extern __inline int > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __rndr (uint64_t *__res) > { > - return __builtin_aarch64_rndr (__res); > + return __builtin_aarch64_rndr ((__builtin_aarch64_simd_di *) = __res); > } >=20 > __extension__ extern __inline int > __attribute__ ((__always_inline__, __gnu_inline__, __artificial__)) > __rndrrs (uint64_t *__res) > { > - return __builtin_aarch64_rndrrs (__res); > + return __builtin_aarch64_rndrrs ((__builtin_aarch64_simd_di *) = __res); > } >=20 > #pragma GCC pop_options > --=20 > 2.39.2 (Apple Git-143) >=20