From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53266 invoked by alias); 18 May 2017 15:33:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 53244 invoked by uid 89); 18 May 2017 15:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2800 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 May 2017 15:33:23 +0000 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 18FBAAC03; Thu, 18 May 2017 15:33:24 +0000 (UTC) Date: Thu, 18 May 2017 15:36:00 -0000 User-Agent: K-9 Mail for Android In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] Try to fix recently introduced crashes in ggc_collect To: Bernd Edlinger ,"gcc-patches@gcc.gnu.org" CC: Jakub Jelinek ,Jeff Law From: Richard Biener Message-ID: <381BC021-5087-40F5-B517-8EB0239900B2@suse.de> X-SW-Source: 2017-05/txt/msg01473.txt.bz2 On May 18, 2017 5:15:43 PM GMT+02:00, Bernd Edlinger wrote: >Hi, > > >this attempts to fix occasional segmentation faults that are present in >the current snapshot, while previous snapshot was stable. > >I observed numerous crashes but all were non-reproducible, >like the following example: > >In file included from=20 >/home/ed/gnu/gcc-build-1/x86_64-pc-linux-gnu/libstdc++-v3/include/string:5= 2:0, > from=20 >/home/ed/gnu/gcc-8-20170514-1/gcc/testsuite/g++.dg/asan/asan_test_config.h= :19, > from=20 >/home/ed/gnu/gcc-8-20170514-1/gcc/testsuite/g++.dg/asan/asan_test_utils.h:= 17, > from=20 >/home/ed/gnu/gcc-8-20170514-1/gcc/testsuite/g++.dg/asan/asan_globals_test.= cc:12, > from=20 >/home/ed/gnu/gcc-8-20170514-1/gcc/testsuite/g++.dg/asan/asan_globals_test-= wrapper.cc:2: >/home/ed/gnu/gcc-build-1/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/bas= ic_string.h:6277:22: > >internal compiler error: Segmentation fault >0xd7e17f crash_signal > ../../gcc-8-20170514-1/gcc/toplev.c:337 >0x8f23fe ggc_set_mark(void const*) > ../../gcc-8-20170514-1/gcc/ggc-page.c:1546 >0x7e6a5f gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:133 >0x7e8c7a gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:235 >0x7e8882 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:365 >0x81b26d gt_ggc_mx_cp_binding_level(void*) > ./gt-cp-name-lookup.h:72 >0x7e6d85 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:648 >0x7e8ad2 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:221 >0x7e8eeb gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:337 >0x7e8a3c gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:441 >0x7e7304 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:606 >0x81b352 gt_ggc_mx_cxx_binding(void*) > ./gt-cp-name-lookup.h:60 >0x7e6d85 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:648 >0x7e8ef5 gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:336 >0x7e8a3c gt_ggc_mx_lang_tree_node(void*) > ./gt-cp-tree.h:441 >0xb2edbe void gt_ggc_mx(vec*) > ../../gcc-8-20170514-1/gcc/vec.h:1110 >0xb2edbe gt_ggc_mx_vec_tree_va_gc_(void*) > /home/ed/gnu/gcc-build-1/gcc/gtype-desc.c:1737 >0xac59f5 ggc_mark_root_tab > ../../gcc-8-20170514-1/gcc/ggc-common.c:77 >0xac5c50 ggc_mark_roots() > ../../gcc-8-20170514-1/gcc/ggc-common.c:94 >0x8f2de7 ggc_collect() > ../../gcc-8-20170514-1/gcc/ggc-page.c:2206 >Please submit a full bug report, >with preprocessed source if appropriate. >Please include the complete backtrace with any bug report. > > >The following patch fixes one rather suspicious static tree >object that did not have the GTY attribute, and was therefore >apparently not in the GC root set. > > >Bootstrapped and reg-tested on x86_64-pc-linux-gnu. >Is it OK for trunk? OK. Richard. > >Thanks >Bernd.