From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128759 invoked by alias); 26 Oct 2016 14:12:45 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128748 invoked by uid 89); 26 Oct 2016 14:12:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Oct 2016 14:12:43 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3384D3F20D for ; Wed, 26 Oct 2016 14:12:42 +0000 (UTC) Received: from localhost.localdomain (vpn1-7-122.ams2.redhat.com [10.36.7.122]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9QECePe007290; Wed, 26 Oct 2016 10:12:41 -0400 Subject: Re: [PATCH] Introduce class rtx_writer To: David Malcolm , gcc-patches@gcc.gnu.org References: <547b2e53-c9d4-2f9c-08f8-1c4f2b48fdd0@redhat.com> <1477491043-4964-1-git-send-email-dmalcolm@redhat.com> From: Bernd Schmidt Message-ID: <381b866e-4842-c15b-fa20-233fc9de711c@redhat.com> Date: Wed, 26 Oct 2016 14:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477491043-4964-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-10/txt/msg02126.txt.bz2 On 10/26/2016 04:10 PM, David Malcolm wrote: > The following patch moves various global state in print-rtl.c into > a new "rtx_writer" class, giving us a place to stash additional state > relating to dumping (and the possibility of putting extra > setup/cleanup in ctor/dtor). > > I didn't bother renaming the variables (e.g. converting "indent" to > "m_indent"), to minimize churn, but I could do that also if you > prefer. I do like avoiding churn, but at the same time - our guidelines suggest that we name members with m_. So the patch is OK if you do the conversion. Bernd