* [PATCH v1] LoongArch: Fix insn output of vec_concat templates for LASX.
@ 2023-12-22 8:22 Chenghui Pan
2023-12-27 6:57 ` [pushed ][PATCH " chenglulu
0 siblings, 1 reply; 2+ messages in thread
From: Chenghui Pan @ 2023-12-22 8:22 UTC (permalink / raw)
To: gcc-patches; +Cc: xry111, i, chenglulu, xuchenghua, Chenghui Pan
When investigaing failure of gcc.dg/vect/slp-reduc-sad.c, following
instruction block are being generated by vec_concatv32qi (which is
generated by vec_initv32qiv16qi) at entrance of foo() function:
vldx $vr3,$r5,$r6
vld $vr2,$r5,0
xvpermi.q $xr2,$xr3,0x20
causes the reversion of vec_initv32qiv16qi operation's high and
low 128-bit part.
According to other target's similar impl and LSX impl for following
RTL representation, current definition in lasx.md of "vec_concat<mode>"
are wrong:
(set (op0) (vec_concat (op1) (op2)))
For correct behavior, the last argument of xvpermi.q should be 0x02
instead of 0x20. This patch fixes this issue and cleanup the vec_concat
template impl.
gcc/ChangeLog:
* config/loongarch/lasx.md (vec_concatv4di): Delete.
(vec_concatv8si): Delete.
(vec_concatv16hi): Delete.
(vec_concatv32qi): Delete.
(vec_concatv4df): Delete.
(vec_concatv8sf): Delete.
(vec_concat<mode>): New template with insn output fixed.
---
gcc/config/loongarch/lasx.md | 74 ++++--------------------------------
1 file changed, 7 insertions(+), 67 deletions(-)
diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md
index eeac8cd984b..a9d948bb606 100644
--- a/gcc/config/loongarch/lasx.md
+++ b/gcc/config/loongarch/lasx.md
@@ -590,77 +590,17 @@ (define_insn "lasx_xvinsgr2vr_<lasxfmt_f_wd>"
[(set_attr "type" "simd_insert")
(set_attr "mode" "<MODE>")])
-(define_insn "vec_concatv4di"
- [(set (match_operand:V4DI 0 "register_operand" "=f")
- (vec_concat:V4DI
- (match_operand:V2DI 1 "register_operand" "0")
- (match_operand:V2DI 2 "register_operand" "f")))]
- "ISA_HAS_LASX"
-{
- return "xvpermi.q\t%u0,%u2,0x20";
-}
- [(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DI")])
-
-(define_insn "vec_concatv8si"
- [(set (match_operand:V8SI 0 "register_operand" "=f")
- (vec_concat:V8SI
- (match_operand:V4SI 1 "register_operand" "0")
- (match_operand:V4SI 2 "register_operand" "f")))]
- "ISA_HAS_LASX"
-{
- return "xvpermi.q\t%u0,%u2,0x20";
-}
- [(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DI")])
-
-(define_insn "vec_concatv16hi"
- [(set (match_operand:V16HI 0 "register_operand" "=f")
- (vec_concat:V16HI
- (match_operand:V8HI 1 "register_operand" "0")
- (match_operand:V8HI 2 "register_operand" "f")))]
- "ISA_HAS_LASX"
-{
- return "xvpermi.q\t%u0,%u2,0x20";
-}
- [(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DI")])
-
-(define_insn "vec_concatv32qi"
- [(set (match_operand:V32QI 0 "register_operand" "=f")
- (vec_concat:V32QI
- (match_operand:V16QI 1 "register_operand" "0")
- (match_operand:V16QI 2 "register_operand" "f")))]
- "ISA_HAS_LASX"
-{
- return "xvpermi.q\t%u0,%u2,0x20";
-}
- [(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DI")])
-
-(define_insn "vec_concatv4df"
- [(set (match_operand:V4DF 0 "register_operand" "=f")
- (vec_concat:V4DF
- (match_operand:V2DF 1 "register_operand" "0")
- (match_operand:V2DF 2 "register_operand" "f")))]
- "ISA_HAS_LASX"
-{
- return "xvpermi.q\t%u0,%u2,0x20";
-}
- [(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DF")])
-
-(define_insn "vec_concatv8sf"
- [(set (match_operand:V8SF 0 "register_operand" "=f")
- (vec_concat:V8SF
- (match_operand:V4SF 1 "register_operand" "0")
- (match_operand:V4SF 2 "register_operand" "f")))]
+(define_insn "vec_concat<mode>"
+ [(set (match_operand:LASX 0 "register_operand" "=f")
+ (vec_concat:LASX
+ (match_operand:<VHMODE256_ALL> 1 "register_operand" "0")
+ (match_operand:<VHMODE256_ALL> 2 "register_operand" "f")))]
"ISA_HAS_LASX"
{
- return "xvpermi.q\t%u0,%u2,0x20";
+ return "xvpermi.q\t%u0,%u2,0x02";
}
[(set_attr "type" "simd_splat")
- (set_attr "mode" "V4DI")])
+ (set_attr "mode" "<MODE>")])
;; xshuf.w
(define_insn "lasx_xvperm_<lasxfmt_f_wd>"
--
2.39.3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pushed ][PATCH v1] LoongArch: Fix insn output of vec_concat templates for LASX.
2023-12-22 8:22 [PATCH v1] LoongArch: Fix insn output of vec_concat templates for LASX Chenghui Pan
@ 2023-12-27 6:57 ` chenglulu
0 siblings, 0 replies; 2+ messages in thread
From: chenglulu @ 2023-12-27 6:57 UTC (permalink / raw)
To: Chenghui Pan, gcc-patches; +Cc: xry111, i, xuchenghua
Pused to r14-6848.
在 2023/12/22 下午4:22, Chenghui Pan 写道:
> When investigaing failure of gcc.dg/vect/slp-reduc-sad.c, following
> instruction block are being generated by vec_concatv32qi (which is
> generated by vec_initv32qiv16qi) at entrance of foo() function:
>
> vldx $vr3,$r5,$r6
> vld $vr2,$r5,0
> xvpermi.q $xr2,$xr3,0x20
>
> causes the reversion of vec_initv32qiv16qi operation's high and
> low 128-bit part.
>
> According to other target's similar impl and LSX impl for following
> RTL representation, current definition in lasx.md of "vec_concat<mode>"
> are wrong:
>
> (set (op0) (vec_concat (op1) (op2)))
>
> For correct behavior, the last argument of xvpermi.q should be 0x02
> instead of 0x20. This patch fixes this issue and cleanup the vec_concat
> template impl.
>
> gcc/ChangeLog:
>
> * config/loongarch/lasx.md (vec_concatv4di): Delete.
> (vec_concatv8si): Delete.
> (vec_concatv16hi): Delete.
> (vec_concatv32qi): Delete.
> (vec_concatv4df): Delete.
> (vec_concatv8sf): Delete.
> (vec_concat<mode>): New template with insn output fixed.
> ---
> gcc/config/loongarch/lasx.md | 74 ++++--------------------------------
> 1 file changed, 7 insertions(+), 67 deletions(-)
>
> diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md
> index eeac8cd984b..a9d948bb606 100644
> --- a/gcc/config/loongarch/lasx.md
> +++ b/gcc/config/loongarch/lasx.md
> @@ -590,77 +590,17 @@ (define_insn "lasx_xvinsgr2vr_<lasxfmt_f_wd>"
> [(set_attr "type" "simd_insert")
> (set_attr "mode" "<MODE>")])
>
> -(define_insn "vec_concatv4di"
> - [(set (match_operand:V4DI 0 "register_operand" "=f")
> - (vec_concat:V4DI
> - (match_operand:V2DI 1 "register_operand" "0")
> - (match_operand:V2DI 2 "register_operand" "f")))]
> - "ISA_HAS_LASX"
> -{
> - return "xvpermi.q\t%u0,%u2,0x20";
> -}
> - [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DI")])
> -
> -(define_insn "vec_concatv8si"
> - [(set (match_operand:V8SI 0 "register_operand" "=f")
> - (vec_concat:V8SI
> - (match_operand:V4SI 1 "register_operand" "0")
> - (match_operand:V4SI 2 "register_operand" "f")))]
> - "ISA_HAS_LASX"
> -{
> - return "xvpermi.q\t%u0,%u2,0x20";
> -}
> - [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DI")])
> -
> -(define_insn "vec_concatv16hi"
> - [(set (match_operand:V16HI 0 "register_operand" "=f")
> - (vec_concat:V16HI
> - (match_operand:V8HI 1 "register_operand" "0")
> - (match_operand:V8HI 2 "register_operand" "f")))]
> - "ISA_HAS_LASX"
> -{
> - return "xvpermi.q\t%u0,%u2,0x20";
> -}
> - [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DI")])
> -
> -(define_insn "vec_concatv32qi"
> - [(set (match_operand:V32QI 0 "register_operand" "=f")
> - (vec_concat:V32QI
> - (match_operand:V16QI 1 "register_operand" "0")
> - (match_operand:V16QI 2 "register_operand" "f")))]
> - "ISA_HAS_LASX"
> -{
> - return "xvpermi.q\t%u0,%u2,0x20";
> -}
> - [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DI")])
> -
> -(define_insn "vec_concatv4df"
> - [(set (match_operand:V4DF 0 "register_operand" "=f")
> - (vec_concat:V4DF
> - (match_operand:V2DF 1 "register_operand" "0")
> - (match_operand:V2DF 2 "register_operand" "f")))]
> - "ISA_HAS_LASX"
> -{
> - return "xvpermi.q\t%u0,%u2,0x20";
> -}
> - [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DF")])
> -
> -(define_insn "vec_concatv8sf"
> - [(set (match_operand:V8SF 0 "register_operand" "=f")
> - (vec_concat:V8SF
> - (match_operand:V4SF 1 "register_operand" "0")
> - (match_operand:V4SF 2 "register_operand" "f")))]
> +(define_insn "vec_concat<mode>"
> + [(set (match_operand:LASX 0 "register_operand" "=f")
> + (vec_concat:LASX
> + (match_operand:<VHMODE256_ALL> 1 "register_operand" "0")
> + (match_operand:<VHMODE256_ALL> 2 "register_operand" "f")))]
> "ISA_HAS_LASX"
> {
> - return "xvpermi.q\t%u0,%u2,0x20";
> + return "xvpermi.q\t%u0,%u2,0x02";
> }
> [(set_attr "type" "simd_splat")
> - (set_attr "mode" "V4DI")])
> + (set_attr "mode" "<MODE>")])
>
> ;; xshuf.w
> (define_insn "lasx_xvperm_<lasxfmt_f_wd>"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-27 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-22 8:22 [PATCH v1] LoongArch: Fix insn output of vec_concat templates for LASX Chenghui Pan
2023-12-27 6:57 ` [pushed ][PATCH " chenglulu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).