From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 078603858286 for ; Wed, 27 Dec 2023 06:57:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 078603858286 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=loongson.cn ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 078603858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703660242; cv=none; b=x8Kq9K2kOqXlO5qrRpxn31NoCQZWKc+yi5OqnB4PW2Xbsjv2MXfg27hy4uIywaNNsHllc+JGn8ro8UnWW36oko3QI+zOtiR9DHkQs28gG8lFUimh9Mi2v5jvC30sSHLIwnzwysv91Pde3vW77g1RvMY5y9pxn1189B8Ys8S9c1A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703660242; c=relaxed/simple; bh=BbH8wHNIOWDSClrH8OsjE5XPPUEMSnSIy2YBeOs4VSo=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=okE88Ko7M81kSSQu7p5Js68cZ4N5VfxCiM4gd17QKElCsyf6fDUzOloxLQqcMogmetd73tYG5kM8WuNol7Q0WLS0VlWCn1AtG+z/OyZdeKJKjFc0hMK3Ifdmrlpnt+sUOYG5ieERLa/xMo2YkjvBazI37RmAXr0o4wdhGP560kg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.loongson.cn ([114.242.206.163]) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rINqt-000209-K2 for gcc-patches@gcc.gnu.org; Wed, 27 Dec 2023 01:57:17 -0500 Received: from loongson.cn (unknown [10.20.4.107]) by gateway (Coremail) with SMTP id _____8DxGOjHyotlH_MEAA--.956S3; Wed, 27 Dec 2023 14:57:11 +0800 (CST) Received: from [10.20.4.107] (unknown [10.20.4.107]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Bxib3HyotldXMMAA--.16093S3; Wed, 27 Dec 2023 14:57:11 +0800 (CST) Subject: Re: [pushed ][PATCH v1] LoongArch: Fix insn output of vec_concat templates for LASX. To: Chenghui Pan , gcc-patches@gcc.gnu.org Cc: xry111@xry111.site, i@xen0n.name, xuchenghua@loongson.cn References: <20231222082203.888077-1-panchenghui@loongson.cn> From: chenglulu Message-ID: <38626c2e-a417-36fe-6639-2a79914e4db7@loongson.cn> Date: Wed, 27 Dec 2023 14:57:11 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20231222082203.888077-1-panchenghui@loongson.cn> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Bxib3HyotldXMMAA--.16093S3 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBj93XoWxGF1rXw15XFyrtrWxJw1DArc_yoWrAw1Dpr Z3u3W3ury5XF4qgayDCayUXw43AFy7CFW2vF1rtr9ayrZrW34kG340kFySqFyqyw4ruw47 Xa1xt3yruayUGrcCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUvIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVW8Jr0_Cr1UM2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx 1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r126r1DMcIj6I8E87Iv 67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lc7I2V7IY0VAS07 AlzVAYIcxG8wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02 F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw 1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8JwCI42IY6xIIjxv20xvEc7Cj xVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r 4j6F4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jY 38nUUUUU= Received-SPF: pass client-ip=114.242.206.163; envelope-from=chenglulu@loongson.cn; helo=mail.loongson.cn X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9,MIME_CHARSET_FARAWAY=2.45,NICE_REPLY_A=-1.197,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,MIME_CHARSET_FARAWAY,NICE_REPLY_A,SPF_FAIL,SPF_HELO_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pused to r14-6848. ÔÚ 2023/12/22 ÏÂÎç4:22, Chenghui Pan дµÀ: > When investigaing failure of gcc.dg/vect/slp-reduc-sad.c, following > instruction block are being generated by vec_concatv32qi (which is > generated by vec_initv32qiv16qi) at entrance of foo() function: > > vldx $vr3,$r5,$r6 > vld $vr2,$r5,0 > xvpermi.q $xr2,$xr3,0x20 > > causes the reversion of vec_initv32qiv16qi operation's high and > low 128-bit part. > > According to other target's similar impl and LSX impl for following > RTL representation, current definition in lasx.md of "vec_concat" > are wrong: > > (set (op0) (vec_concat (op1) (op2))) > > For correct behavior, the last argument of xvpermi.q should be 0x02 > instead of 0x20. This patch fixes this issue and cleanup the vec_concat > template impl. > > gcc/ChangeLog: > > * config/loongarch/lasx.md (vec_concatv4di): Delete. > (vec_concatv8si): Delete. > (vec_concatv16hi): Delete. > (vec_concatv32qi): Delete. > (vec_concatv4df): Delete. > (vec_concatv8sf): Delete. > (vec_concat): New template with insn output fixed. > --- > gcc/config/loongarch/lasx.md | 74 ++++-------------------------------- > 1 file changed, 7 insertions(+), 67 deletions(-) > > diff --git a/gcc/config/loongarch/lasx.md b/gcc/config/loongarch/lasx.md > index eeac8cd984b..a9d948bb606 100644 > --- a/gcc/config/loongarch/lasx.md > +++ b/gcc/config/loongarch/lasx.md > @@ -590,77 +590,17 @@ (define_insn "lasx_xvinsgr2vr_" > [(set_attr "type" "simd_insert") > (set_attr "mode" "")]) > > -(define_insn "vec_concatv4di" > - [(set (match_operand:V4DI 0 "register_operand" "=f") > - (vec_concat:V4DI > - (match_operand:V2DI 1 "register_operand" "0") > - (match_operand:V2DI 2 "register_operand" "f")))] > - "ISA_HAS_LASX" > -{ > - return "xvpermi.q\t%u0,%u2,0x20"; > -} > - [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DI")]) > - > -(define_insn "vec_concatv8si" > - [(set (match_operand:V8SI 0 "register_operand" "=f") > - (vec_concat:V8SI > - (match_operand:V4SI 1 "register_operand" "0") > - (match_operand:V4SI 2 "register_operand" "f")))] > - "ISA_HAS_LASX" > -{ > - return "xvpermi.q\t%u0,%u2,0x20"; > -} > - [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DI")]) > - > -(define_insn "vec_concatv16hi" > - [(set (match_operand:V16HI 0 "register_operand" "=f") > - (vec_concat:V16HI > - (match_operand:V8HI 1 "register_operand" "0") > - (match_operand:V8HI 2 "register_operand" "f")))] > - "ISA_HAS_LASX" > -{ > - return "xvpermi.q\t%u0,%u2,0x20"; > -} > - [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DI")]) > - > -(define_insn "vec_concatv32qi" > - [(set (match_operand:V32QI 0 "register_operand" "=f") > - (vec_concat:V32QI > - (match_operand:V16QI 1 "register_operand" "0") > - (match_operand:V16QI 2 "register_operand" "f")))] > - "ISA_HAS_LASX" > -{ > - return "xvpermi.q\t%u0,%u2,0x20"; > -} > - [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DI")]) > - > -(define_insn "vec_concatv4df" > - [(set (match_operand:V4DF 0 "register_operand" "=f") > - (vec_concat:V4DF > - (match_operand:V2DF 1 "register_operand" "0") > - (match_operand:V2DF 2 "register_operand" "f")))] > - "ISA_HAS_LASX" > -{ > - return "xvpermi.q\t%u0,%u2,0x20"; > -} > - [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DF")]) > - > -(define_insn "vec_concatv8sf" > - [(set (match_operand:V8SF 0 "register_operand" "=f") > - (vec_concat:V8SF > - (match_operand:V4SF 1 "register_operand" "0") > - (match_operand:V4SF 2 "register_operand" "f")))] > +(define_insn "vec_concat" > + [(set (match_operand:LASX 0 "register_operand" "=f") > + (vec_concat:LASX > + (match_operand: 1 "register_operand" "0") > + (match_operand: 2 "register_operand" "f")))] > "ISA_HAS_LASX" > { > - return "xvpermi.q\t%u0,%u2,0x20"; > + return "xvpermi.q\t%u0,%u2,0x02"; > } > [(set_attr "type" "simd_splat") > - (set_attr "mode" "V4DI")]) > + (set_attr "mode" "")]) > > ;; xshuf.w > (define_insn "lasx_xvperm_"