From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by sourceware.org (Postfix) with ESMTPS id 5EA9D385C406; Fri, 23 Jul 2021 16:33:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EA9D385C406 Received: by mail-pj1-x102d.google.com with SMTP id k4-20020a17090a5144b02901731c776526so9638725pjm.4; Fri, 23 Jul 2021 09:33:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5sMi+HnB8Tsc1KE9KAVpjbziVGIiS2ER36Yfg2i9fxo=; b=VqUhmMTnjW4rlmhGXtBR4gsxC+TRYa8mRlUjcFhsf7hfZcdQB8CisRxdNpute1RGnw 439bUcRI0izqAFs79A+m2FGyXR8MSDcLcbBWiS7TC4Cr5SJNsSY4rUoAAOWSXd8PboSZ vgpQ5phuElgJ4zXjWkf+9n0VwUXFwsWRPhEvFFdg2835eo/NI84OxwhDxAdagq6dIpIT K4+FpTAoUOLCO7Ne73QxHai7HR6MzKlpJMsZSX7PrccJ883UAWiBf/P/l4BbqBdB9Clu D5vtmCJvDunyz6us0owd6hrpBwpTo8FrhjZbp1pK2eNRp4d7fK8c6WU7+JZi0mVA+xS5 HhsQ== X-Gm-Message-State: AOAM531+kOo5p0zqE7iCcrk3Z7UM2FiBA8tf1rt8poD0Ks/q777756Xh AQioRcv5wV5mSUUmhKatiGEogcHL+8/U5w== X-Google-Smtp-Source: ABdhPJxdtQBtlx6WAKZRKDnJnl3mvYN1dtWbdw/WIGl5Hh8JC6uGS1wirVji1V83MShELiQ98eWOKw== X-Received: by 2002:a63:e118:: with SMTP id z24mr5645758pgh.212.1627057992864; Fri, 23 Jul 2021 09:33:12 -0700 (PDT) Received: from [192.168.1.17] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id w145sm23911175pfc.39.2021.07.23.09.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 09:33:12 -0700 (PDT) Subject: Re: [PATCH] c++: suppress all warnings on memper pointers to work around dICE [PR101219] To: Sergei Trofimovich , gcc-patches@gcc.gnu.org Cc: Sergei Trofimovich , Martin Sebor References: <20210722231524.2045951-1-slyfox@gentoo.org> From: Jeff Law Message-ID: <387e2a61-a895-733d-5418-7c8c38d6f998@gmail.com> Date: Fri, 23 Jul 2021 10:33:09 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210722231524.2045951-1-slyfox@gentoo.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 16:33:16 -0000 On 7/22/2021 5:15 PM, Sergei Trofimovich via Gcc-patches wrote: > From: Sergei Trofimovich > > r12-1804 ("cp: add support for per-location warning groups.") among other > things removed warning suppression from a few places including ptrmemfuncs. > > Currently ptrmemfuncs don't have valid BINFO attached which causes ICEs > in access checks: > > crash_signal > gcc/toplev.c:328 > perform_or_defer_access_check(tree_node*, tree_node*, tree_node*, int, access_failure_info*) > gcc/cp/semantics.c:490 > finish_non_static_data_member(tree_node*, tree_node*, tree_node*) > gcc/cp/semantics.c:2208 > ... > > The change suppresses warnings again until we provide BINFOs for ptrmemfuncs. > > PR c++/101219 > > gcc/cp/ChangeLog: > > * typeck.c (build_ptrmemfunc_access_expr): Suppress all warnings > to avoid ICE. > > gcc/testsuite/ChangeLog: > > * g++.dg/torture/pr101219.C: New test. The C++ maintainers have the final say here, but ISTM that warning suppression shouldn't be used to avoid an ICE, even an ICE within the warning or diagnostic code itself. jeff