From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by sourceware.org (Postfix) with ESMTPS id E50D63858D35 for ; Thu, 29 Jun 2023 23:43:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E50D63858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oi1-x22f.google.com with SMTP id 5614622812f47-3a1a47b33d8so918451b6e.2 for ; Thu, 29 Jun 2023 16:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688082203; x=1690674203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wkgdxpGJWQYbtRS7b5ixki+qYGeMTyCwRIoBLrFy3g0=; b=H6PeTQCFQCNe9vbKyvfEknS9hUPKnHZiqwKcfxXevLp7vpdFeCt7/NSN0QIPqrIR+a fRijtXhDt5xHO0U6KDyFqXrDxgcG4ukJoUZBIjZ/6OZsrZ0WBNM20ufykONyc+E00+Ff q8OYLOp/40a93mRFU9zfSxlkEgSupyE/y4uivYbDrDA+x9+R1KkuMVwGxXhyeI1Ukg3g vGfF5VJc3oA5Yr6KYblT/jQS5lRGqMMFP7+VhKdDI9Doe98AL8l0Cd6rLQUCCq71itoU m0XII8LzrtZk28cTVD+YME2n53TaIP/IAonVsYs4rQezOWVXpU9OqC1vkJ6WMOEXDnXJ E/xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688082203; x=1690674203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wkgdxpGJWQYbtRS7b5ixki+qYGeMTyCwRIoBLrFy3g0=; b=dDiTKzZImnTBL3/Tg+Laa7lovWnJ4BObqykcMKJ/OowtZlkE+ySfbxNThP7WtRrPfp OHPE5ANh61iO8ZEebd57QC6VZjVLhnjlW+KcDwGuYtkm5dwVnxzu+HmOTT3d22PqRwb0 dOZirHvTZpX4KUrTNDZBVeVYIwDFL/eu03pJ4elX62HjrwN+aFZp5jevV115QUDmqxr1 NR6pMgVsdNe0U1i6RaIMgnndAqfqeTTcxYYAb0sy4ngvROtyI604Pb4q9DgFSPn4hOqi HCArdlaobP10gAa8JpkENdusO6QFvIOt8cN9fV+XFz3iK5PFCQnfn6AUPIQXBX6xUQdU AI9A== X-Gm-Message-State: AC+VfDwQS/eaxLJxtCnrBfQKUzS/OxwhAf16/9dY3sRRFe5tyhbJYHCE Q4lp4ktMX0N4B6rROWCVbQU= X-Google-Smtp-Source: ACHHUZ5Vcn+lvoD43i7N1C8k0LKwZLJGrjm5BJbHEEDKCmfjqDO4QO2LfA8WIbSX7r7vd86hFUo+Kg== X-Received: by 2002:a05:6808:de0:b0:3a1:e219:8cdb with SMTP id g32-20020a0568080de000b003a1e2198cdbmr777936oic.40.1688082203060; Thu, 29 Jun 2023 16:43:23 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id h21-20020aa786d5000000b00678cb336f3csm6579572pfo.142.2023.06.29.16.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 16:43:22 -0700 (PDT) Message-ID: <38937362-3401-b92e-cb9c-268e52451af7@gmail.com> Date: Thu, 29 Jun 2023 17:43:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] RISC-V: Support vfwnmacc/vfwmsac/vfwnmsac combine lowering Content-Language: en-US To: =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches Cc: "kito.cheng" , "kito.cheng" , palmer , palmer , "rdapp.gcc" References: <20230628115559.116166-1-juzhe.zhong@rivai.ai> <2abb91f5-36e0-5024-9b15-a45f8c40b4fe@gmail.com> <7A18980BD9E65F8A+202306290610400062820@rivai.ai> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/28/23 16:56, 钟居哲 wrote: > > > ------------------------------------------------------------------------ > juzhe.zhong@rivai.ai > > *From:* Jeff Law > *Date:* 2023-06-29 06:43 > *To:* 钟居哲 ; gcc-patches > > *CC:* kito.cheng ; kito.cheng > ; palmer ; > palmer ; rdapp.gcc > > *Subject:* Re: [PATCH] RISC-V: Support vfwnmacc/vfwmsac/vfwnmsac > combine lowering > On 6/28/23 16:10, 钟居哲 wrot > > Sure. > > > > https://godbolt.org/z/8857KzTno > > > > Failed to match this instruction: > > (set (reg:VNx2DF 134 [ vect__31.47 ]) > >      (fma:VNx2DF (neg:VNx2DF (float_extend:VNx2DF (reg:VNx2SF 136 [ > > vect__28.44 ]))) > >          (reg:VNx2DF 150 [ vect__8.12 ]) > >          (reg:VNx2DF 171 [ vect__29.45 ]))) > Please attach the full dump.  I would expect to see additional attempts > with more operands replaced. THanks for the dump. I think this fundamentally the same issue as the widening problem. Drop those intermediate patterns. They're not needed/helpful. You may need a dependency height reduction pattern to get the code you want, but I see no evidence those extra patterns will solve anything. jeff