From: Eric Botcazou <ebotcazou@adacore.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Uros Bizjak <ubizjak@gmail.com>
Subject: Re: [PATCH] Avoid extending lifetime of likely spilled hard regs in ifcvt before reload (PR rtl-optimization/56484)
Date: Tue, 05 Mar 2013 17:28:00 -0000 [thread overview]
Message-ID: <3897593.89GmqB5X3k@polaris> (raw)
In-Reply-To: <20130305162646.GJ12913@tucnak.redhat.com>
> Without this patch, ifcvt extends lifetime of %eax hard register,
> which causes reload/LRA ICE later on. Combiner and other passes try hard
> not to do that, even ifcvt has code for it if x is a hard register a few
> lines below it, but in this case the hard register is SET_SRC (set_b).
>
> With this patch we just use the pseudo (x) which has been initialized
> from the hard register before the conditional.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2013-03-05 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/56484
> * ifcvt.c (noce_process_if_block): Before reload if else_bb
> is NULL, avoid extending lifetimes of hard registers in
> likely to spilled or small register classes.
ifcvt.c tests only small_register_classes_for_mode_p in the other places, so
do you really need class_likely_spilled_p here?
--
Eric Botcazou
next prev parent reply other threads:[~2013-03-05 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-05 16:27 Jakub Jelinek
2013-03-05 17:24 ` Jeff Law
2013-03-05 17:28 ` Eric Botcazou [this message]
2013-03-05 22:03 ` Jakub Jelinek
2013-03-05 22:33 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3897593.89GmqB5X3k@polaris \
--to=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).