From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8049 invoked by alias); 9 Oct 2008 13:53:39 -0000 Received: (qmail 8040 invoked by uid 22791); 9 Oct 2008 13:53:39 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out3.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 09 Oct 2008 13:53:03 +0000 Received: from spaceape23.eur.corp.google.com (spaceape23.eur.corp.google.com [172.28.16.75]) by smtp-out.google.com with ESMTP id m99DqvxW032431 for ; Thu, 9 Oct 2008 14:52:57 +0100 Received: from rv-out-0506.google.com (rvbk40.prod.google.com [10.140.87.40]) by spaceape23.eur.corp.google.com with ESMTP id m99DqhPm009435 for ; Thu, 9 Oct 2008 06:52:56 -0700 Received: by rv-out-0506.google.com with SMTP id k40so31634rvb.13 for ; Thu, 09 Oct 2008 06:52:55 -0700 (PDT) Received: by 10.141.123.4 with SMTP id a4mr80741rvn.294.1223560375765; Thu, 09 Oct 2008 06:52:55 -0700 (PDT) Received: by 10.140.162.8 with HTTP; Thu, 9 Oct 2008 06:52:55 -0700 (PDT) Message-ID: <38a0d8450810090652g5cf7f686hb293c063d1a7cd9f@mail.gmail.com> Date: Thu, 09 Oct 2008 14:08:00 -0000 From: "Rafael Espindola" To: "Diego Novillo" Subject: Re: [lto][patch] Remove nodes for extern inline function before writing to disk Cc: gcc-patches In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <38a0d8450810090623j63452261mf64f64601c112efd@mail.gmail.com> X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-10/txt/msg00394.txt.bz2 > No need to create another pass for this. Just call > cgraph_remove_unreachable_nodes from pass_ipa_free_lang_specifics. OK > with that change. pass_ipa_free_lang_specifics runs too early. If we remove the bodies there, programs that have extern inline functions and assume they are inlined will fail. We actually test for that on the testsuite (forgot the test number). > Diego. > Cheers, -- Rafael Avila de Espindola Google | Gordon House | Barrow Street | Dublin 4 | Ireland Registered in Dublin, Ireland | Registration Number: 368047