public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Rafael Espindola <espindola@google.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Jan Hubicka <jh@suse.cz>, Jan Hubicka <hubicka@ucw.cz>,
	        gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [lto][patch] Move the call to execute_all_ipa_transforms to  	cgraphunit.c
Date: Wed, 12 Nov 2008 10:01:00 -0000	[thread overview]
Message-ID: <38a0d8450811120036h59cc4feaw9a92722ce4ca020d@mail.gmail.com> (raw)
In-Reply-To: <b798aad50811111603h2d8450et45b2d065cb664bbd@mail.gmail.com>

> OK, do you think you could implement this solution to extern inlines?
> For now, running the inliner early will get rid of the immediate
> problem we are having.  If you don't have a lot of time, could you
> send an outline of what needs to be done?

I think I still prefer to run the inliner and drop the extern inline
functions. The option of fully transferring then to wpa would be
harder, since now the compiler would see more function bodies then the
linker and would need decide what to do with them. I am afraid that
converting extern inline into static functions would break some code
that has unreasonable expectations about a function defined in another
file being called.

Doing an early inline (and possibly other optimizations) also has the
benefit of reducing the size of the IL that is written to disk.

> Thanks.  Diego.
>

Cheers,
-- 
Rafael Avila de Espindola

Google | Gordon House | Barrow Street | Dublin 4 | Ireland
Registered in Dublin, Ireland | Registration Number: 368047

  reply	other threads:[~2008-11-12  8:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-11 17:31 Rafael Espindola
2008-11-11 20:23 ` Jan Hubicka
2008-11-11 22:49   ` Rafael Espindola
2008-11-11 22:53     ` Jan Hubicka
2008-11-11 23:11   ` Diego Novillo
2008-11-11 23:18     ` Jan Hubicka
2008-11-11 23:41       ` Rafael Espindola
2008-11-11 23:59         ` Jan Hubicka
2008-11-12  0:01           ` Diego Novillo
2008-11-12  0:04             ` Jan Hubicka
2008-11-12  0:57               ` Jan Hubicka
2008-11-12  2:02                 ` Diego Novillo
2008-11-12 10:01                   ` Rafael Espindola [this message]
2008-11-12 16:02                     ` Jan Hubicka
2008-11-12 16:35                   ` Jan Hubicka
2008-11-11 23:53       ` Diego Novillo
2008-11-11 22:54 ` Diego Novillo
2008-11-11 23:14   ` Jan Hubicka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38a0d8450811120036h59cc4feaw9a92722ce4ca020d@mail.gmail.com \
    --to=espindola@google.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=hubicka@ucw.cz \
    --cc=jh@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).