From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17596 invoked by alias); 12 Nov 2008 08:37:29 -0000 Received: (qmail 17578 invoked by uid 22791); 12 Nov 2008 08:37:28 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 12 Nov 2008 08:36:43 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id mAC8aabL004695 for ; Wed, 12 Nov 2008 08:36:37 GMT Received: from rv-out-0506.google.com (rvfb25.prod.google.com [10.140.179.25]) by zps77.corp.google.com with ESMTP id mAC8aC0M030390 for ; Wed, 12 Nov 2008 00:36:35 -0800 Received: by rv-out-0506.google.com with SMTP id b25so306128rvf.41 for ; Wed, 12 Nov 2008 00:36:35 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.97.5 with SMTP id z5mr4763719rvl.104.1226478995256; Wed, 12 Nov 2008 00:36:35 -0800 (PST) In-Reply-To: References: <38a0d8450811110921t4c619461u2f934ddcdc3df5e@mail.gmail.com> <20081111193733.GD27401@atrey.karlin.mff.cuni.cz> <20081111231240.GH27401@atrey.karlin.mff.cuni.cz> <38a0d8450811111531u6e2731c0y7b7d6d75b758ef79@mail.gmail.com> <20081111235225.GI27401@atrey.karlin.mff.cuni.cz> <20081111235839.GJ27401@atrey.karlin.mff.cuni.cz> <20081112000041.GZ13677@kam.mff.cuni.cz> Date: Wed, 12 Nov 2008 10:01:00 -0000 Message-ID: <38a0d8450811120036h59cc4feaw9a92722ce4ca020d@mail.gmail.com> Subject: Re: [lto][patch] Move the call to execute_all_ipa_transforms to cgraphunit.c From: Rafael Espindola To: Diego Novillo Cc: Jan Hubicka , Jan Hubicka , gcc-patches Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-11/txt/msg00510.txt.bz2 > OK, do you think you could implement this solution to extern inlines? > For now, running the inliner early will get rid of the immediate > problem we are having. If you don't have a lot of time, could you > send an outline of what needs to be done? I think I still prefer to run the inliner and drop the extern inline functions. The option of fully transferring then to wpa would be harder, since now the compiler would see more function bodies then the linker and would need decide what to do with them. I am afraid that converting extern inline into static functions would break some code that has unreasonable expectations about a function defined in another file being called. Doing an early inline (and possibly other optimizations) also has the benefit of reducing the size of the IL that is written to disk. > Thanks. Diego. > Cheers, -- Rafael Avila de Espindola Google | Gordon House | Barrow Street | Dublin 4 | Ireland Registered in Dublin, Ireland | Registration Number: 368047