From: Rafael Espindola <espindola@google.com>
To: Basile STARYNKEVITCH <basile@starynkevitch.net>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
Diego Novillo <dnovillo@google.com>
Subject: Re: gengtype & plugins [#define emitted in wrong order]
Date: Thu, 01 Oct 2009 19:52:00 -0000 [thread overview]
Message-ID: <38a0d8450910011251n36c7e499hf81cacd828c144b8@mail.gmail.com> (raw)
In-Reply-To: <4AC44702.7050508@starynkevitch.net>
> Correcting the problem is actually simple, as the attached patch (against
> trunk r152356) demonstrates. I just moved the write_func_for_structure calls
> inside write_types into their own loops.
>
> I am also attaching the gcc/ChangeLog entry
>
> Ok for trunk if it bootstraps?
The patch looks reasonable, what I don't understand is why this is a
problem only for plugins. Do you know what makes the old order work
for the non-plugin case?
Some comments:
* The } on line 2773 in unaligned.
* There is a trailing space on the "emit the functions" comment on line 2793.
* There is a dummy ; on line 2818
>
> Regards
>
> PS: I really hope this small kind of bugfix fits in stage 3. Should I make a
> bug report decribing http://gcc.gnu.org/ml/gcc-patches/2009-09/msg02274.html
> in bugzilla?
>
Cheers,
--
Rafael Ávila de Espíndola
next prev parent reply other threads:[~2009-10-01 19:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 21:39 Basile STARYNKEVITCH
2009-10-01 6:06 ` Basile STARYNKEVITCH
2009-10-01 6:34 ` Basile STARYNKEVITCH
2009-10-01 19:52 ` Rafael Espindola [this message]
2009-10-01 20:33 ` Basile STARYNKEVITCH
2009-10-01 21:02 ` Rafael Espindola
2009-10-02 21:02 ` Gerald Pfeifer
2009-10-03 5:54 ` Basile STARYNKEVITCH
2009-10-05 15:11 ` Diego Novillo
2009-10-05 16:12 ` Basile STARYNKEVITCH
2009-10-05 18:33 ` Rafael Espindola
2009-10-05 19:52 ` Joseph S. Myers
2009-10-06 8:32 ` Basile STARYNKEVITCH
2009-10-06 13:24 ` Joseph S. Myers
2009-10-06 13:52 ` Basile STARYNKEVITCH
2009-10-06 14:36 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38a0d8450910011251n36c7e499hf81cacd828c144b8@mail.gmail.com \
--to=espindola@google.com \
--cc=basile@starynkevitch.net \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).