Re: [patch] Fix PR41764

[Rafael Espindola <espindola@google.com>]

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

> Looks like this breaks debug generation for fortran:

The attached patch reduces the problems to:

gfortran.dg/debug/pr35154-stabs.f scan-assembler .stabs.*"__BLNK__",226
gfortran.dg/debug/pr35154-stabs.f scan-assembler .stabs.*"__BLNK__",228
gfortran.dg/debug/pr35154-stabs.f scan-assembler .stabs.*"label_",226
gfortran.dg/debug/pr35154-stabs.f scan-assembler .stabs.*"label_",228

Debugging...

Cheers,
-- 
Rafael Ávila de Espíndola

[-- Attachment #2: fake.patch --]
[-- Type: text/x-diff, Size: 1823 bytes --]

diff --git a/gcc/dwarf2out.c b/gcc/dwarf2out.c
index ba59251..cb3d790 100644
--- a/gcc/dwarf2out.c
+++ b/gcc/dwarf2out.c
@@ -15606,12 +15606,11 @@ fortran_common (tree decl, HOST_WIDE_INT *value)
   tree offset;
   int volatilep = 0, unsignedp = 0;
 
-  /* If the decl isn't a VAR_DECL, or if it isn't public or static, or if
+  /* If the decl isn't a VAR_DECL, or if it isn't static, or if
      it does not have a value (the offset into the common area), or if it
      is thread local (as opposed to global) then it isn't common, and shouldn't
      be handled as such.  */
   if (TREE_CODE (decl) != VAR_DECL
-      || !TREE_PUBLIC (decl)
       || !TREE_STATIC (decl)
       || !DECL_HAS_VALUE_EXPR_P (decl)
       || !is_fortran ())
diff --git a/gcc/fortran/trans-common.c b/gcc/fortran/trans-common.c
index 5b1952a..1fb3c40 100644
--- a/gcc/fortran/trans-common.c
+++ b/gcc/fortran/trans-common.c
@@ -680,7 +680,6 @@ create_common (gfc_common_head *com, segment_info *head, bool saw_equiv)
       var_decl = build_decl (s->sym->declared_at.lb->location,
 			     VAR_DECL, DECL_NAME (s->field),
 			     TREE_TYPE (s->field));
-      TREE_PUBLIC (var_decl) = TREE_PUBLIC (decl);
       TREE_STATIC (var_decl) = TREE_STATIC (decl);
       TREE_USED (var_decl) = TREE_USED (decl);
       if (s->sym->attr.use_assoc)
@@ -689,7 +688,9 @@ create_common (gfc_common_head *com, segment_info *head, bool saw_equiv)
 	TREE_ADDRESSABLE (var_decl) = 1;
       /* This is a fake variable just for debugging purposes.  */
       TREE_ASM_WRITTEN (var_decl) = 1;
-      
+      /* Fake variables are not visible from other translation units. */
+      TREE_PUBLIC (var_decl) = 0;
+
       /* To preserve identifier names in COMMON, chain to procedure
          scope unless at top level in a module definition.  */
       if (com