From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12578 invoked by alias); 27 Oct 2009 23:49:02 -0000 Received: (qmail 12558 invoked by uid 22791); 27 Oct 2009 23:49:00 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Oct 2009 23:48:56 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id n9RNmrjY002969 for ; Tue, 27 Oct 2009 16:48:54 -0700 Received: from pzk12 (pzk12.prod.google.com [10.243.19.140]) by wpaz33.hot.corp.google.com with ESMTP id n9RNmPaK022068 for ; Tue, 27 Oct 2009 16:48:51 -0700 Received: by pzk12 with SMTP id 12so182867pzk.13 for ; Tue, 27 Oct 2009 16:48:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.250.3 with SMTP id x3mr1428595wfh.23.1256687331007; Tue, 27 Oct 2009 16:48:51 -0700 (PDT) In-Reply-To: <38a0d8450910261141i5f4dda4erfd4122c388f2f240@mail.gmail.com> References: <38a0d8450910211055g4968b06fie72550732e1dcf4c@mail.gmail.com> <38a0d8450910211517j4af51106qf3f81c169a7e830c@mail.gmail.com> <38a0d8450910261141i5f4dda4erfd4122c388f2f240@mail.gmail.com> Date: Wed, 28 Oct 2009 04:24:00 -0000 Message-ID: <38a0d8450910271648m76a92c3as1b8a8ee9404cc7e1@mail.gmail.com> Subject: Re: [patch] Fix PR41764 From: Rafael Espindola To: GCC Patches Cc: Richard Guenther , Diego Novillo , Paul Brook Content-Type: multipart/mixed; boundary=001636ed6835f55de90476f3517e X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01643.txt.bz2 --001636ed6835f55de90476f3517e Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 530 > Debugging... The joys of duplicated code... The attached patch fixes the PR, bootstraps and passes the regression tests. Is it OK? gcc/ 2009-10-27 Rafael Avila de Espindola * dbxout.c (dbxout_common_check): Accept non public trees. * dwarf2out.c (fortran_common): Accept non public trees. gcc/fortran/ 2009-10-27 Rafael Avila de Espindola * trans-common.c (create_common): Set TREE_PUBLIC to false on fake variables. Cheers, --=20 Rafael =C3=81vila de Esp=C3=ADndola --001636ed6835f55de90476f3517e Content-Type: text/x-diff; charset=US-ASCII; name="fake.patch" Content-Disposition: attachment; filename="fake.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g1b4v8f91 Content-length: 3669 ZGlmZiAtLWdpdCBhL2djYy9kYnhvdXQuYyBiL2djYy9kYnhvdXQuYwppbmRl eCBiNTY4OGQ5Li4wYmY1ZTNjIDEwMDY0NAotLS0gYS9nY2MvZGJ4b3V0LmMK KysrIGIvZ2NjL2RieG91dC5jCkBAIC0zMTg5LDcgKzMxODksNyBAQCBkYnhv dXRfY29tbW9uX2NoZWNrICh0cmVlIGRlY2wsIGludCAqdmFsdWUpCiAgIHJ0 eCBzeW1fYWRkcjsKICAgY29uc3QgY2hhciAqbmFtZSA9IE5VTEw7CiAgIAot ICAvKiBJZiB0aGUgZGVjbCBpc24ndCBhIFZBUl9ERUNMLCBvciBpZiBpdCBp c24ndCBwdWJsaWMgb3Igc3RhdGljLCBvciBpZgorICAvKiBJZiB0aGUgZGVj bCBpc24ndCBhIFZBUl9ERUNMLCBvciBpZiBpdCBpc24ndCBzdGF0aWMsIG9y IGlmCiAgICAgIGl0IGRvZXMgbm90IGhhdmUgYSB2YWx1ZSAodGhlIG9mZnNl dCBpbnRvIHRoZSBjb21tb24gYXJlYSksIG9yIGlmIGl0CiAgICAgIGlzIHRo cmVhZCBsb2NhbCAoYXMgb3Bwb3NlZCB0byBnbG9iYWwpIHRoZW4gaXQgaXNu J3QgY29tbW9uLCBhbmQgc2hvdWxkbid0CiAgICAgIGJlIGhhbmRsZWQgYXMg c3VjaC4KQEAgLTMxOTgsNyArMzE5OCw2IEBAIGRieG91dF9jb21tb25fY2hl Y2sgKHRyZWUgZGVjbCwgaW50ICp2YWx1ZSkKICAgICAgZm9yIHRocmVhZC1s b2NhbCBzeW1ib2xzLiAgQ2FuIGJlIGhhbmRsZWQgdmlhIHNhbWUgbWVjaGFu aXNtIGFzIHVzZWQKICAgICAgaW4gZHdhcmYyb3V0LmMuICAqLwogICBpZiAo VFJFRV9DT0RFIChkZWNsKSAhPSBWQVJfREVDTAotICAgICAgfHwgIVRSRUVf UFVCTElDKGRlY2wpCiAgICAgICB8fCAhVFJFRV9TVEFUSUMoZGVjbCkKICAg ICAgIHx8ICFERUNMX0hBU19WQUxVRV9FWFBSX1AoZGVjbCkKICAgICAgIHx8 IERFQ0xfVEhSRUFEX0xPQ0FMX1AgKGRlY2wpCmRpZmYgLS1naXQgYS9nY2Mv ZHdhcmYyb3V0LmMgYi9nY2MvZHdhcmYyb3V0LmMKaW5kZXggMTI5YmE3ZC4u NzMyYjZhNiAxMDA2NDQKLS0tIGEvZ2NjL2R3YXJmMm91dC5jCisrKyBiL2dj Yy9kd2FyZjJvdXQuYwpAQCAtMTU2MjEsMTIgKzE1NjIxLDExIEBAIGZvcnRy YW5fY29tbW9uICh0cmVlIGRlY2wsIEhPU1RfV0lERV9JTlQgKnZhbHVlKQog ICB0cmVlIG9mZnNldDsKICAgaW50IHZvbGF0aWxlcCA9IDAsIHVuc2lnbmVk cCA9IDA7CiAKLSAgLyogSWYgdGhlIGRlY2wgaXNuJ3QgYSBWQVJfREVDTCwg b3IgaWYgaXQgaXNuJ3QgcHVibGljIG9yIHN0YXRpYywgb3IgaWYKKyAgLyog SWYgdGhlIGRlY2wgaXNuJ3QgYSBWQVJfREVDTCwgb3IgaWYgaXQgaXNuJ3Qg c3RhdGljLCBvciBpZgogICAgICBpdCBkb2VzIG5vdCBoYXZlIGEgdmFsdWUg KHRoZSBvZmZzZXQgaW50byB0aGUgY29tbW9uIGFyZWEpLCBvciBpZiBpdAog ICAgICBpcyB0aHJlYWQgbG9jYWwgKGFzIG9wcG9zZWQgdG8gZ2xvYmFsKSB0 aGVuIGl0IGlzbid0IGNvbW1vbiwgYW5kIHNob3VsZG4ndAogICAgICBiZSBo YW5kbGVkIGFzIHN1Y2guICAqLwogICBpZiAoVFJFRV9DT0RFIChkZWNsKSAh PSBWQVJfREVDTAotICAgICAgfHwgIVRSRUVfUFVCTElDIChkZWNsKQogICAg ICAgfHwgIVRSRUVfU1RBVElDIChkZWNsKQogICAgICAgfHwgIURFQ0xfSEFT X1ZBTFVFX0VYUFJfUCAoZGVjbCkKICAgICAgIHx8ICFpc19mb3J0cmFuICgp KQpkaWZmIC0tZ2l0IGEvZ2NjL2ZvcnRyYW4vdHJhbnMtY29tbW9uLmMgYi9n Y2MvZm9ydHJhbi90cmFucy1jb21tb24uYwppbmRleCA1YjE5NTJhLi4xZmIz YzQwIDEwMDY0NAotLS0gYS9nY2MvZm9ydHJhbi90cmFucy1jb21tb24uYwor KysgYi9nY2MvZm9ydHJhbi90cmFucy1jb21tb24uYwpAQCAtNjgwLDcgKzY4 MCw2IEBAIGNyZWF0ZV9jb21tb24gKGdmY19jb21tb25faGVhZCAqY29tLCBz ZWdtZW50X2luZm8gKmhlYWQsIGJvb2wgc2F3X2VxdWl2KQogICAgICAgdmFy X2RlY2wgPSBidWlsZF9kZWNsIChzLT5zeW0tPmRlY2xhcmVkX2F0LmxiLT5s b2NhdGlvbiwKIAkJCSAgICAgVkFSX0RFQ0wsIERFQ0xfTkFNRSAocy0+Zmll bGQpLAogCQkJICAgICBUUkVFX1RZUEUgKHMtPmZpZWxkKSk7Ci0gICAgICBU UkVFX1BVQkxJQyAodmFyX2RlY2wpID0gVFJFRV9QVUJMSUMgKGRlY2wpOwog ICAgICAgVFJFRV9TVEFUSUMgKHZhcl9kZWNsKSA9IFRSRUVfU1RBVElDIChk ZWNsKTsKICAgICAgIFRSRUVfVVNFRCAodmFyX2RlY2wpID0gVFJFRV9VU0VE IChkZWNsKTsKICAgICAgIGlmIChzLT5zeW0tPmF0dHIudXNlX2Fzc29jKQpA QCAtNjg5LDcgKzY4OCw5IEBAIGNyZWF0ZV9jb21tb24gKGdmY19jb21tb25f aGVhZCAqY29tLCBzZWdtZW50X2luZm8gKmhlYWQsIGJvb2wgc2F3X2VxdWl2 KQogCVRSRUVfQUREUkVTU0FCTEUgKHZhcl9kZWNsKSA9IDE7CiAgICAgICAv KiBUaGlzIGlzIGEgZmFrZSB2YXJpYWJsZSBqdXN0IGZvciBkZWJ1Z2dpbmcg cHVycG9zZXMuICAqLwogICAgICAgVFJFRV9BU01fV1JJVFRFTiAodmFyX2Rl Y2wpID0gMTsKLSAgICAgIAorICAgICAgLyogRmFrZSB2YXJpYWJsZXMgYXJl IG5vdCB2aXNpYmxlIGZyb20gb3RoZXIgdHJhbnNsYXRpb24gdW5pdHMuICov CisgICAgICBUUkVFX1BVQkxJQyAodmFyX2RlY2wpID0gMDsKKwogICAgICAg LyogVG8gcHJlc2VydmUgaWRlbnRpZmllciBuYW1lcyBpbiBDT01NT04sIGNo YWluIHRvIHByb2NlZHVyZQogICAgICAgICAgc2NvcGUgdW5sZXNzIGF0IHRv cCBsZXZlbCBpbiBhIG1vZHVsZSBkZWZpbml0aW9uLiAgKi8KICAgICAgIGlm IChjb20K --001636ed6835f55de90476f3517e--